td-firmware

firmware

Clone Tools

Stats

Commits this week: 23
Total Committers: 18
Last Commit: 09 Jul
Commits this week: 23

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Sean Nash

Is rinseback completed an indication that we've done a blood prime following a temporary break? If so, I guess this makes sense, but we have to do more than increase the UF volume. We have to adjus...

Is rinseback completed an indication that we've done a blood prime following a temporary break?
If so, I guess this makes sense, but we have to do more than increase the UF volume. We have to adjust the UF rate so that we will reach the new (larger) UF volume when the treatment completes.
We also need to add RB volume to UF volume in pre-tx when treatment parameters are given/validated (for the final rinseback which we will always have so we should just plan for it before treatment starts).

1 hr ago

Sean Nash

What if multiple confirmations pending? Which ID will this function return?

What if multiple confirmations pending? Which ID will this function return?

1 hr ago

Sean Nash

Align comments. Should substitution pump data be moved down to 0xBA instead of commented out?

Align comments.
Should substitution pump data be moved down to 0xBA instead of commented out?

Thursday 09 Jul
4:22 pm

Vendor - TEL - Praneeth Bunne and Sean Nash

2:07 pm

Sean Nash

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

1:36 pm

Sean Nash

Do we really need these setup functions for each state? They all look very simple - just 1 or 2 lines of code.

Do we really need these setup functions for each state? They all look very simple - just 1 or 2 lines of code.

1:33 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4040_Rinseback - FW Implementation - 3/10:
LEAHI-TD-FIRMWARE-LDT-4040_Rinseback - FW Implementation - 3/10:
1:32 pm

Sean Nash

I believe the SyringePump controller will trigger this alarm at end of seek operation.

I believe the SyringePump controller will trigger this alarm at end of seek operation.

1:28 pm

Sean Nash

Syringe pump should already be stopped if preload is done. Do we need to call this here?

Syringe pump should already be stopped if preload is done. Do we need to call this here?

1:24 pm

Sean Nash

This is called from preload state. Not needed here I think.

This is called from preload state. Not needed here I think.

1:22 pm

Sean Nash

Don't put comments on function prototypes. Doxygen gets details of functions from the function header.

Don't put comments on function prototypes. Doxygen gets details of functions from the function header.

1:20 pm

Sean Nash

Why (void)?

Why (void)?

1:16 pm

Sean Nash

Where is this being called? Should be called from pre-treatment init I think.

Where is this being called? Should be called from pre-treatment init I think.

1:13 pm

Sean Nash

Confirmation signal sounds like a message handler from UI. Message handlers must accept a message as parameter and return BOOL. They must also be added to the message handler table in Messaging.c.

Confirmation signal sounds like a message handler from UI. Message handlers must accept a message as parameter and return BOOL. They must also be added to the message handler table in Messaging.c.

1:11 pm

Sean Nash

Why are we signaling syringe load confirmed here?

Why are we signaling syringe load confirmed here?

1:11 pm

Sean Nash

Do these states need to be public?

Do these states need to be public?

1:08 pm

Sean Nash

Move up one row to alphabetize.

Move up one row to alphabetize.

11:44 am

Vendor - TEL - Praneeth Bunne

LDT-4040: Add rinseback realted code

Options
    • -77
    • +167
    ./App/Modes/ModeTreatment.c
    • -0
    • +5
    ./App/Modes/ModeTreatment.h
    • -82
    • +129
    ./App/Modes/OperationModes.c
    • -0
    • +15
    ./App/Modes/OperationModes.h
    • -0
    • +1
    ./App/Modes/StateTxBloodPrime.c
    • -0
    • +1
    ./App/Modes/StateTxDialysis.c
    • -1
    • +3
    ./App/Modes/StateTxPaused.c
    • -0
    • +584
    ./App/Modes/StateTxRecirc.c
    • -0
    • +51
    ./App/Modes/StateTxRecirc.h
    • -0
    • +969
    ./App/Modes/StateTxRinseback.c
    • -0
    • +67
    ./App/Modes/StateTxRinseback.h
    • -0
    • +3
    ./App/Services/AlarmMgmtSWFaults.h
    • -8
    • +68
    ./App/Services/AlarmMgmtTD.c
    • -1
    • +4
    ./App/Services/AlarmMgmtTD.h
    • -0
    • +65
    ./App/Services/Messaging.c
    • -0
    • +3
    ./App/Services/Messaging.h
    • -1
    • +2
    ./App/Services/TxParams.c
10:38 am

Vendor - TEL - Varshini Nagabooshanam

New featre

Options
    • -8
    • +8
    ./App/Drivers/PinchValve.c
10:35 am

Vendor - TEL - Varshini Nagabooshanam

New featre

Options
    • -0
    • +608
    ./App/Drivers/PinchValve.c
    • -0
    • +69
    ./App/Drivers/PinchValve.h
  3. … 1 more file in changeset.
9:40 am

Vendor - TEL - Vijay Pamula

LDT-4029: Pre-Treatment Heparin Setup State Implementation

Options
    • -5
    • +55
    ./App/Modes/ModePreTreat.c
    • -1
    • +2
    ./App/Modes/ModePreTreat.h
    • -0
    • +539
    ./App/Modes/StatePreTxHeparinSetup.c
    • -0
    • +62
    ./App/Modes/StatePreTxHeparinSetup.h
    • -0
    • +1
    ./App/Services/AlarmMgmtSWFaults.h
9:00 am

Sean Nash

If this reserved2 is a U32, next register would be at 288 (not 285). Should we make reserved2 a U08?

If this reserved2 is a U32, next register would be at 288 (not 285). Should we make reserved2 a U08?

Wednesday 08 Jul
10:29 am

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/TDCommon.h
10:29 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./App/Services/AlarmMgmtTD.c
    • -2
    • +2
    ./App/Services/AlarmMgmtTD.h
    • -2
    • +2
    ./App/Services/Messaging.c
Tuesday 07 Jul
4:13 pm

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/TDCommon.h
3:16 pm

Sean Nash

3:16 pm

Sean Nash

3:10 pm

Vendor - TEL - Vijay Pamula

LDT-4028: Adressed Review Comment foro Install State

Options
    • -1
    • +0
    ./App/Modes/ModePreTreat.c
2:45 pm

Vendor - TEL - Varshini Nagabooshanam

New add ons in FPGA

Options
    • -12
    • +175
    ./App/Services/FpgaTD.c
    • -4
    • +20
    ./App/Services/FpgaTD.h
11:59 am

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'staging' of bitbucket.org:diality-cloud/td-firmware into LDT-4149-pinch-valves-fw-implementation

Options
    • -13
    • +1
    ./App/Services/FpgaTD.c
    • -2
    • +1
    ./App/Services/FpgaTD.h