firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3970: Implemented edit treatment parameters

LDT-1886: addressed code review comments

    • -110
    • +112
    ./App/Modes/ModePostTreat.c
LDT-2240-disposable-tube-set-self-test

Removed

Removed

Removed

Removed

updated

updated

added

added

Added

Added

Removed

Removed

Updated

Updated

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

LDT-3959 merged branch into develop and resolved conflicts

LDT-2240-disposable-tube-set-self-test

    • -42
    • +40
    ./App/Modes/StatePreTxDrySelfTests.c
LDT-2240-disposable-tube-set-self-test

LDT-2240-disposable-tube-set-self-test

    • -288
    • +254
    ./App/Modes/StatePreTxDrySelfTests.c
LDT-3959 fixed s/w fault ids in staging

Not necessary

Not necessary

This command should be given once on way out of prior state instead of every 50ms while in this state. We also need to zero the timer counter at same time so the timeout check below works.

This command should be given once on way out of prior state instead of every 50ms while in this state.
We also need to zero the timer counter at same time so the timeout check below works.

Response needs to be sent immediately (in message handler function). This is too late.

Response needs to be sent immediately (in message handler function). This is too late.

We shouldn't need to do this door check if you've required door be closed for the state. Call the doorClosedRequired( TRUE ) function on transition into a state that requires the door to be closed ...

We shouldn't need to do this door check if you've required door be closed for the state.
Call the doorClosedRequired( TRUE ) function on transition into a state that requires the door to be closed and call with ( FALSE ) on transition into a state that doesn't require door to be closed. When required = TRUE, the switch monitor will trigger the door open alarm for you.

Same organization comment that I had for post-tx mode. Let's keep functions related to each pre-tx state together separated by some kind of comment banner.

Same organization comment that I had for post-tx mode. Let's keep functions related to each pre-tx state together separated by some kind of comment banner.

Remove extra blank line.

Remove extra blank line.

Looks like there's plans for 4 post-tx states and we only have your auto eject state implemented here below. Since all of these 4 states will be implemented in this file, maybe we should organize t...

Looks like there's plans for 4 post-tx states and we only have your auto eject state implemented here below.
Since all of these 4 states will be implemented in this file, maybe we should organize them - keep functions related to each state together separated by some kind of comment banner.

Not necessary if you give retract command on way out of prior state.

Not necessary if you give retract command on way out of prior state.