Fisheye on dd-firmware/firmware/App https://devapps.diality.us/changelog/~br%3DBambooSetup/dd-firmware/firmware/App Recent activity in "dd-firmware" under directory /firmware/App LEAHI-DD-FIRMWARE-LDT-4733-1: reviewers finished Thu, 09 Jul 2026 15:40:26 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1 Vinayakam Mani and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-4733-1 LEAHI-DD-FIRMWARE-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data ]]> LEAHI-DD-FIRMWARE-LDT-4734-1: reviewers finished Thu, 09 Jul 2026 14:13:11 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-4734-1 LEAHI-DD-FIRMWARE-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4: ]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "fixed. thanks!" Thu, 09 Jul 2026 11:22:22 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30396 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30396 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4733-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "fixed. thanks!" Thu, 09 Jul 2026 11:22:14 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30395 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30395 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4733-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "fixed. thanks!" Thu, 09 Jul 2026 11:22:10 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30394 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30394 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4733-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "fixed. thanks!" Thu, 09 Jul 2026 11:22:06 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30393 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30393 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4733-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "fixed. thanks!" Thu, 09 Jul 2026 11:22:02 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30392 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30392 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4733-1

fixed. thanks!

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Michael Garthwaite "this would be out of scope of the original tick..." Thu, 09 Jul 2026 10:12:51 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30391 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30391 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4733-1

this would be out of scope of the original ticket. https://diality.atlassian.net/browse/LDT-4733

Looking at the debug data, this alarm would still trigger. Voltage values are still reporting 0.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Sean Nash "TODO?" Wed, 08 Jul 2026 14:55:55 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30389 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30389 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4614-1

TODO?

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Remove empty line" Wed, 08 Jul 2026 14:21:52 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30388 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30388 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Remove empty line

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Remove empty line." Wed, 08 Jul 2026 14:20:23 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30387 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30387 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Remove empty line.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Please add the details what is post and pre in ..." Wed, 08 Jul 2026 13:58:46 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30385 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30385 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Please add the details what is post and pre in the comments. Also update the return type with additional details, instead of just conducitivity.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Remove extra line." Wed, 08 Jul 2026 14:01:37 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30386 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30386 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Remove extra line.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Is this TODO still valid?" Wed, 08 Jul 2026 13:52:40 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30384 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30384 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Is this TODO still valid?

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Space inside parenthesis. update across the fil..." Wed, 08 Jul 2026 13:50:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30383 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30383 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Space inside parenthesis. update across the file.

]]> LEAHI-DD-FIRMWARE-LDT-4734-1: reviewers finished Wed, 08 Jul 2026 13:48:01 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 Vinayakam Mani and Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-4734-1 LEAHI-DD-FIRMWARE-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4: ]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Vinayakam Mani "Did you get a chance to test this alarm and unc..." Wed, 08 Jul 2026 13:45:29 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30382 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30382 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4733-1

Did you get a chance to test this alarm and uncomment the code?

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Vinayakam Mani "Remove empty space." Wed, 08 Jul 2026 13:44:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30381 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30381 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4733-1

Remove empty space.

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Vinayakam Mani "ACToDC?" Wed, 08 Jul 2026 13:44:09 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30380 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30380 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4733-1

ACToDC?

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Vinayakam Mani "Count datatype seems to be integer. Type case t..." Wed, 08 Jul 2026 13:41:59 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30379 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30379 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4733-1

Count datatype seems to be integer. Type case to F32 to match with denominator data type.

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Sean Nash "Align comment. Clarify (at least in comments) ..." Wed, 08 Jul 2026 10:39:46 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30378 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30378 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4733-1

Align comment.
Clarify (at least in comments) that these macros are for FPGA count conversions.

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: comment by Sean Nash "Remove extra blank lines." Wed, 08 Jul 2026 10:38:22 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30377 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1/#c30377 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4733-1

Remove extra blank lines.

]]> LEAHI-DD-FIRMWARE-LDT-4539-1: closed by Vendor - TEL - Santhoshkumar Reddy Alasandagutti Tue, 07 Jul 2026 09:04:04 -0700 Vendor - TEL - Santhoshkumar Reddy Alasandagutti https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1 Vendor - TEL - Santhoshkumar Reddy Alasandagutti Closed LEAHI-DD-FIRMWARE-LDT-4539-1 ]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Sean Nash "What is 4 (or 2)? Should be #define or enum or..." Mon, 06 Jul 2026 12:59:07 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30364 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30364 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4410-3

What is 4 (or 2)? Should be #define or enum or const.

]]> LEAHI-DD-FIRMWARE-LDT-4539-1: reviewers finished Thu, 02 Jul 2026 15:39:25 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-4539-1 LEAHI-DD-FIRMWARE-LDT-4539_Provide event on Service state change ]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Add comments." Thu, 02 Jul 2026 15:26:48 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30356 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30356 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Add comments.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Update Comments." Thu, 02 Jul 2026 15:24:32 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30354 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30354 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Update Comments.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Siemens. Space after and before paranthesis." Thu, 02 Jul 2026 15:22:09 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30353 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30353 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Siemens. Space after and before paranthesis.

]]> LEAHI-DD-FIRMWARE-LDT-4873-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to... Thu, 02 Jul 2026 14:05:50 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-1 Sean Nash added Zoltan Miskolci to LEAHI-DD-FIRMWARE-LDT-4873-1 LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault ]]> LEAHI-DD-FIRMWARE-LDT-4011-2: closed by Vendor - TEL - Jashwant Gantyada Thu, 02 Jul 2026 10:29:24 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4011-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4011-2 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-4011-2 ]]>