Updated

Added

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

I was thinking that comment should go above the first if statement.

Updated

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below:
#define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall condition must persist before alarming.

OR use persistent alarm.

Added

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

Added

Should probably initialize your new stall counter variable.

Sean Nash I need your help for writing this Alarm properties.

fixed in latest code

implemented

fixed

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

Fixed

removed from here

fixed

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

Add blank line after declarations.

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().