· /firmware/App/Controllers/AirPump.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AirPump.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmAudio.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmAudio.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmLamp.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmLamp.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/BloodFlow.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/BloodFlow.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Ejector.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Ejector.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/BubbleDetector.c	(-1, +1)	| History	| Source	| Diff
… 76 more files in changeset.

]]> Fri, 19 Dec 2025 13:57:43 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-1 Dara Navaei Closed LEAHI-TD-FIRMWARE-LDT-1886-1 ]]> Fri, 19 Dec 2025 12:16:13 -0800 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-1 Vendor - TEL - Sameer Poyil and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-1886-1 LEAHI-TD-FIRMWARE-LDT-1886_Blood Set Auto-Load and Auto-Eject - TD ]]> Thu, 18 Dec 2025 15:08:24 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-1/#c25949 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-1/#c25949 Dara Navaei replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1886-1

We tend to initialize the local variables as a standard practice.

These don't need to be initialized to zero.

Done

Done

Done

Done

Done

Done.

No. It is permanent, I would like to know the value for the homing.

The else in this trinary looks wrong - doesn't round up to multiple of 8.

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

Declarations should be at top of scope.

Is this temporary?

Done

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

Done

move static function after public function

let public function on top

Let all public functions come on top for all files

Should we comment this out before merging?

Done

Done

Align =

Should be 2 blank lines above/below test banner.

Done

Should we initialize to inactive (and use #define)?

· /firmware/App/Controllers/AirPump.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/AirPump.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmAudio.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmAudio.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmLamp.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmLamp.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/BloodFlow.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/BloodFlow.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/Ejector.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/Ejector.h	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Drivers/BubbleDetector.c	(-4, +4)	| History	| Source	| Diff
… 76 more files in changeset.

]]>