Fisheye on td-firmware/firmware/App/Monitors/Buttons.h https://devapps.diality.us/changelog/~br%3DBambooSetup/td-firmware/firmware/App/Monitors/Buttons.h Recent activity in "td-firmware" under directory /firmware/App/Monitors/Buttons.h TD-LEAH-47-1: closed by Sean Nash Mon, 30 Sep 2024 17:07:23 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-47-1 https://devapps.diality.us/cru/TD-LEAH-47-1 Sean Nash Closed TD-LEAH-47-1 ]]> TD-LEAH-47-1: reviewers finished Mon, 30 Sep 2024 10:41:04 -0700 https://devapps.diality.us/cru/TD-LEAH-47-1 https://devapps.diality.us/cru/TD-LEAH-47-1 Michael Garthwaite and Vinayakam Mani finished reviewing TD-LEAH-47-1 TD-LEAH-47_FW TD Buttons Monitor ]]> TD-LEAH-47-1: comment by Sean Nash "Removed." Thu, 26 Sep 2024 09:44:33 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-47-1/#c20292 https://devapps.diality.us/cru/TD-LEAH-47-1/#c20292 Sean Nash replied to Vinayakam Mani in TD-LEAH-47-1

Removed.

]]> TD-LEAH-47-1: comment by Sean Nash "No. Button press/release events will be sent a..." Thu, 26 Sep 2024 09:43:21 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-47-1/#c20291 https://devapps.diality.us/cru/TD-LEAH-47-1/#c20291 Sean Nash replied to Vinayakam Mani in TD-LEAH-47-1

No. Button press/release events will be sent as asynchronous events.

]]> TD-LEAH-47-1: comment by Sean Nash "This one is different. Not using standard over..." Thu, 26 Sep 2024 09:41:23 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-47-1/#c20290 https://devapps.diality.us/cru/TD-LEAH-47-1/#c20290 Sean Nash replied to Vinayakam Mani in TD-LEAH-47-1

This one is different. Not using standard override payload as it is not an override - it's a set command.

]]> TD-LEAH-47-1: comment by Sean Nash "I thought about that but decided to keep the co..." Thu, 26 Sep 2024 09:39:41 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-47-1/#c20289 https://devapps.diality.us/cru/TD-LEAH-47-1/#c20289 Sean Nash replied to Vinayakam Mani in TD-LEAH-47-1

I thought about that but decided to keep the common functions simple by calling the param a maximum.

]]> TD-LEAH-47-1: comment by Sean Nash "Fixed." Thu, 26 Sep 2024 09:38:19 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-47-1/#c20288 https://devapps.diality.us/cru/TD-LEAH-47-1/#c20288 Sean Nash replied to Vinayakam Mani in TD-LEAH-47-1

Fixed.

]]> TD-LEAH-47-1: comment by Sean Nash "Fixed." Thu, 26 Sep 2024 09:36:35 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-47-1/#c20287 https://devapps.diality.us/cru/TD-LEAH-47-1/#c20287 Sean Nash replied to Vinayakam Mani in TD-LEAH-47-1

Fixed.

]]> TD-LEAH-47-1: comment by Vinayakam Mani "are we not publishing the buttons state?" Wed, 25 Sep 2024 16:43:54 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-47-1/#c20286 https://devapps.diality.us/cru/TD-LEAH-47-1/#c20286 Vinayakam Mani commented on TD-LEAH-47-1

are we not publishing the buttons state?

]]> TD-LEAH-47-1: comment by Vinayakam Mani "extra blank line" Wed, 25 Sep 2024 16:25:33 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-47-1/#c20285 https://devapps.diality.us/cru/TD-LEAH-47-1/#c20285 Vinayakam Mani commented on TD-LEAH-47-1

extra blank line

]]> TD-LEAH-47-1: comment by Vinayakam Mani "initilalizes the Airpump driver? Also, the outp..." Wed, 25 Sep 2024 15:11:22 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-47-1/#c20282 https://devapps.diality.us/cru/TD-LEAH-47-1/#c20282 Vinayakam Mani commented on TD-LEAH-47-1

initilalizes the Airpump driver? Also, the outputs to mention unit variables initialized instead detailed list.

]]> TD-LEAH-47-1: comment by Vinayakam Mani "Needs to be updated per latest testsupport rout..." Wed, 25 Sep 2024 15:47:43 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-47-1/#c20284 https://devapps.diality.us/cru/TD-LEAH-47-1/#c20284 Vinayakam Mani commented on TD-LEAH-47-1

Needs to be updated per latest testsupport routine?

]]> TD-LEAH-47-1: comment by Vinayakam Mani "can we modify the routine to take index, max va..." Wed, 25 Sep 2024 15:41:23 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-47-1/#c20283 https://devapps.diality.us/cru/TD-LEAH-47-1/#c20283 Vinayakam Mani commented on TD-LEAH-47-1

can we modify the routine to take index, max variables as it is ( without subtracting -1) and adjust the conditions inside the routine ( by removing = in the <= )?

]]> TD-LEAH-47-1: comment by Vinayakam Mani "I guess this code is common for all stacks. can..." Wed, 25 Sep 2024 15:06:42 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-47-1/#c20281 https://devapps.diality.us/cru/TD-LEAH-47-1/#c20281 Vinayakam Mani commented on TD-LEAH-47-1

I guess this code is common for all stacks. can we remove TD reference across the functions?

]]> TD-LEAH-47-1: started by Dara Navaei Wed, 25 Sep 2024 09:12:49 -0700 Dara Navaei https://devapps.diality.us/cru/TD-LEAH-47-1 https://devapps.diality.us/cru/TD-LEAH-47-1 Dara Navaei started review TD-LEAH-47-1 ]]>