Fisheye on td-firmware/firmware/App/Monitors/Pressures.h

LEAHI-TD-FIRMWARE-LDT-3970-1: started by Dara Navaei

Dara Navaei — Thu, 16 Apr 2026 19:32:48 -0700

Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-3970-1

LEAHI-TD-FIRMWARE-LDT-1840-1: closed by Vendor - TEL - Varshini Nagabooshanam

Vendor - TEL - Varshini Nagabooshanam — Fri, 13 Mar 2026 14:59:08 -0700

Vendor - TEL - Varshini Nagabooshanam Closed LEAHI-TD-FIRMWARE-LDT-1840-1

LEAHI-TD-FIRMWARE-LDT-1840-1: reviewers finished

Fri, 13 Mar 2026 14:58:07 -0700

Zoltan Miskolci and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-1840-1

LEAHI-TD-FIRMWARE-LDT-1840_Transmembrane Pressure Dialin Updates

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Vendor - TEL - Varshini Nagabooshanam "Removed"

Vendor - TEL - Varshini Nagabooshanam — Fri, 13 Mar 2026 14:39:59 -0700

Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1840-1

Removed

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Vendor - TEL - Varshini Nagabooshanam "Updated"

Vendor - TEL - Varshini Nagabooshanam — Fri, 13 Mar 2026 14:39:43 -0700

Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1840-1

Updated

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Sean Nash "Still not packed."

Sean Nash — Fri, 13 Mar 2026 14:26:47 -0700

Sean Nash replied to Vendor - TEL - Varshini Nagabooshanam in LEAHI-TD-FIRMWARE-LDT-1840-1

Still not packed.

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Sean Nash "Remove extra blank line."

Sean Nash — Fri, 13 Mar 2026 14:25:36 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1840-1

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Vendor - TEL - Varshini Nagabooshanam "Sure"

Vendor - TEL - Varshini Nagabooshanam — Fri, 13 Mar 2026 14:18:54 -0700

Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1840-1

Sure

LEAHI-TD-FIRMWARE-LDT-1415-3: closed by Vendor - TEL - Varshini Nagabooshanam

Vendor - TEL - Varshini Nagabooshanam — Tue, 10 Mar 2026 14:25:59 -0700

Vendor - TEL - Varshini Nagabooshanam Closed LEAHI-TD-FIRMWARE-LDT-1415-3

LEAHI-TD-FIRMWARE-LDT-1415-3: reviewers finished

Tue, 10 Mar 2026 13:52:35 -0700

Vendor - TEL - Jashwant Gantyada and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-1415-3

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD

LEAHI-TD-FIRMWARE-LDT-1415-3: comment by Vendor - TEL - Varshini Nagabooshanam "Removed"

Vendor - TEL - Varshini Nagabooshanam — Fri, 06 Mar 2026 14:02:27 -0800

Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1415-3

Removed

LEAHI-TD-FIRMWARE-LDT-1415-3: comment by Sean Nash "I don't think we need to call setPressureLimits..."

Sean Nash — Fri, 06 Mar 2026 13:56:34 -0800

Sean Nash replied to Vendor - TEL - Varshini Nagabooshanam in LEAHI-TD-FIRMWARE-LDT-1415-3

I don't think we need to call setPressureLimitsToOuterBounds() either. The signal function will indirectly cause that function to be called later.

LEAHI-TD-FIRMWARE-LDT-1415-3: comment by Vendor - TEL - Varshini Nagabooshanam "Updated"

Vendor - TEL - Varshini Nagabooshanam — Fri, 06 Mar 2026 11:41:29 -0800

Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1415-3

Updated

LEAHI-TD-FIRMWARE-LDT-1415-3: comment by Sean Nash "I think we should just call signalInitiatePress..."

Sean Nash — Fri, 06 Mar 2026 09:53:21 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1415-3

I think we should just call signalInitiatePressureStabilization( USE_NORMAL_STABILIZATION_PERIOD );

LEAHI-TD-FIRMWARE-LDT-1415-3: reviewers added to LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - ...

Fri, 06 Mar 2026 09:50:02 -0800

Sean Nash added Vendor - TEL - Arpita Srivastava and Vendor - TEL - Jashwant Gantyada to LEAHI-TD-FIRMWARE-LDT-1415-3

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD

LEAHI-TD-FIRMWARE-LDT-1415-3: started by Dara Navaei

Dara Navaei — Thu, 05 Mar 2026 15:47:19 -0800

Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-1415-3

td-firmware (BambooSetup): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Sat, 21 Feb 2026 15:49:20 -0800

Dara Navaei committed e86a744 on branch BambooSetup in td-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmAudio.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmAudio.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Ejector.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Ejector.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/BubbleDetector.c

(-1, +1)

| History

| Source

| Diff

… 76 more files in changeset.

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Sean Nash "This is a msg payload structure. Even though a..."

Sean Nash — Fri, 20 Feb 2026 13:44:33 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1840-1

This is a msg payload structure. Even though all fields are 4 bytes, we should still pack it in case we add smaller fields later.

LEAHI-TD-FIRMWARE-LDT-1840-1: reviewers resumed

Thu, 19 Feb 2026 11:54:15 -0800

Vendor - TEL - Jashwant Gantyada resumed reviewing LEAHI-TD-FIRMWARE-LDT-1840-1

LEAHI-TD-FIRMWARE-LDT-1840_Transmembrane Pressure Dialin Updates

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Vendor - TEL - Varshini Nagabooshanam "Removed"

Vendor - TEL - Varshini Nagabooshanam — Thu, 12 Feb 2026 14:25:52 -0800

Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1840-1

Removed

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Vendor - TEL - Varshini Nagabooshanam "Updated"

Vendor - TEL - Varshini Nagabooshanam — Thu, 12 Feb 2026 14:25:39 -0800

Vendor - TEL - Varshini Nagabooshanam replied to Zoltan Miskolci in LEAHI-TD-FIRMWARE-LDT-1840-1

Updated

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Vendor - TEL - Varshini Nagabooshanam "Not required I guess"

Vendor - TEL - Varshini Nagabooshanam — Thu, 12 Feb 2026 14:23:45 -0800

Vendor - TEL - Varshini Nagabooshanam replied to Zoltan Miskolci in LEAHI-TD-FIRMWARE-LDT-1840-1

Not required I guess

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Zoltan Miskolci "There is no override for the TMP long filtered ..."

Zoltan Miskolci — Thu, 12 Feb 2026 10:53:20 -0800

Zoltan Miskolci commented on LEAHI-TD-FIRMWARE-LDT-1840-1

There is no override for the TMP long filtered pressure value. Please add a new one for it.

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Zoltan Miskolci "Please update the documentations too."

Zoltan Miskolci — Thu, 12 Feb 2026 10:32:07 -0800

Zoltan Miskolci commented on LEAHI-TD-FIRMWARE-LDT-1840-1

Please update the documentations too.

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Sean Nash "Remove blank line."

Sean Nash — Thu, 12 Feb 2026 10:29:37 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1840-1

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Sean Nash "Now I don't see .data being set anywhere. Shou..."

Sean Nash — Thu, 12 Feb 2026 10:28:10 -0800

Sean Nash replied to Vendor - TEL - Varshini Nagabooshanam in LEAHI-TD-FIRMWARE-LDT-1840-1

Now I don't see .data being set anywhere. Shouldn't we have tmpPressure.data = tmpPres;

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Vendor - TEL - Varshini Nagabooshanam "Updated"

Vendor - TEL - Varshini Nagabooshanam — Thu, 12 Feb 2026 10:19:59 -0800

Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1840-1

Updated

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Vendor - TEL - Varshini Nagabooshanam "Passed tmpPres"

Vendor - TEL - Varshini Nagabooshanam — Thu, 12 Feb 2026 10:19:43 -0800

Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1840-1

Passed tmpPres

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Vendor - TEL - Varshini Nagabooshanam "Updated"

Vendor - TEL - Varshini Nagabooshanam — Thu, 12 Feb 2026 10:19:28 -0800

Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1840-1

Updated

LEAHI-TD-FIRMWARE-LDT-1840-1: comment by Vendor - TEL - Varshini Nagabooshanam "Removed and updated"

Vendor - TEL - Varshini Nagabooshanam — Thu, 12 Feb 2026 10:19:17 -0800

Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1840-1

Removed and updated