Fisheye on td-firmware/firmware/App/Tasks/TaskPriority.c https://devapps.diality.us/changelog/~br%3DBambooSetup/td-firmware/firmware/App/Tasks/TaskPriority.c Recent activity in "td-firmware" under directory /firmware/App/Tasks/TaskPriority.c TD-LDT-469-1: closed by Sean Nash Mon, 09 Jun 2025 15:12:48 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1 https://devapps.diality.us/cru/TD-LDT-469-1 Sean Nash Closed TD-LDT-469-1 ]]> TD-LDT-469-1: reviewers finished Mon, 09 Jun 2025 10:16:17 -0700 https://devapps.diality.us/cru/TD-LDT-469-1 https://devapps.diality.us/cru/TD-LDT-469-1 Michael Garthwaite and Vinayakam Mani finished reviewing TD-LDT-469-1 TD-LDT-469_Treatment Parameters Create RX ]]> TD-LDT-469-1: comment by Sean Nash "Fixed." Tue, 20 May 2025 10:00:11 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1/#c22036 https://devapps.diality.us/cru/TD-LDT-469-1/#c22036 Sean Nash replied to Vinayakam Mani in TD-LDT-469-1

Fixed.

]]> TD-LDT-469-1: comment by Sean Nash "Fixed." Tue, 20 May 2025 09:57:27 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1/#c22035 https://devapps.diality.us/cru/TD-LDT-469-1/#c22035 Sean Nash replied to Vinayakam Mani in TD-LDT-469-1

Fixed.

]]> TD-LDT-469-1: comment by Sean Nash "Fixed." Tue, 20 May 2025 09:55:50 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1/#c22034 https://devapps.diality.us/cru/TD-LDT-469-1/#c22034 Sean Nash replied to Vinayakam Mani in TD-LDT-469-1

Fixed.

]]> TD-LDT-469-1: comment by Sean Nash "Fixed." Tue, 20 May 2025 09:53:56 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1/#c22033 https://devapps.diality.us/cru/TD-LDT-469-1/#c22033 Sean Nash replied to Vinayakam Mani in TD-LDT-469-1

Fixed.

]]> TD-LDT-469-1: comment by Sean Nash "Fixed." Tue, 20 May 2025 09:53:21 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1/#c22032 https://devapps.diality.us/cru/TD-LDT-469-1/#c22032 Sean Nash replied to Vinayakam Mani in TD-LDT-469-1

Fixed.

]]> TD-LDT-469-1: comment by Sean Nash "Added." Tue, 20 May 2025 09:52:30 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1/#c22031 https://devapps.diality.us/cru/TD-LDT-469-1/#c22031 Sean Nash replied to Vinayakam Mani in TD-LDT-469-1

Added.

]]> TD-LDT-469-1: comment by Sean Nash "Fixed." Tue, 20 May 2025 09:49:04 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-469-1/#c22030 https://devapps.diality.us/cru/TD-LDT-469-1/#c22030 Sean Nash replied to Vinayakam Mani in TD-LDT-469-1

Fixed.

]]> TD-LDT-469-1: comment by Vinayakam Mani "DD. Search DG and replace in file." Mon, 19 May 2025 14:00:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-469-1/#c22029 https://devapps.diality.us/cru/TD-LDT-469-1/#c22029 Vinayakam Mani commented on TD-LDT-469-1

DD. Search DG and replace in file.

]]> TD-LDT-469-1: comment by Vinayakam Mani "Fill in outputs." Mon, 19 May 2025 13:37:14 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-469-1/#c22028 https://devapps.diality.us/cru/TD-LDT-469-1/#c22028 Vinayakam Mani commented on TD-LDT-469-1

Fill in outputs.

]]> TD-LDT-469-1: comment by Vinayakam Mani "Current Eject motor set speed?" Mon, 19 May 2025 13:32:07 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-469-1/#c22027 https://devapps.diality.us/cru/TD-LDT-469-1/#c22027 Vinayakam Mani commented on TD-LDT-469-1

Current Eject motor set speed?

]]> TD-LDT-469-1: comment by Vinayakam Mani "Update header" Mon, 19 May 2025 13:28:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-469-1/#c22026 https://devapps.diality.us/cru/TD-LDT-469-1/#c22026 Vinayakam Mani commented on TD-LDT-469-1

Update header

]]> TD-LDT-469-1: comment by Vinayakam Mani "Please add header." Mon, 19 May 2025 13:25:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-469-1/#c22025 https://devapps.diality.us/cru/TD-LDT-469-1/#c22025 Vinayakam Mani commented on TD-LDT-469-1

Please add header.

]]> TD-LDT-469-1: comment by Vinayakam Mani "Update Message ID and I/O sections." Mon, 19 May 2025 13:24:17 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-469-1/#c22024 https://devapps.diality.us/cru/TD-LDT-469-1/#c22024 Vinayakam Mani commented on TD-LDT-469-1

Update Message ID and I/O sections.

]]> TD-LDT-469-1: comment by Vinayakam Mani "ejector driver/module. Update the Outputs below..." Mon, 19 May 2025 10:48:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LDT-469-1/#c22023 https://devapps.diality.us/cru/TD-LDT-469-1/#c22023 Vinayakam Mani commented on TD-LDT-469-1

ejector driver/module. Update the Outputs below.

]]> TD-LDT-469-1: started by Dara Navaei Thu, 01 May 2025 09:07:38 -0700 Dara Navaei https://devapps.diality.us/cru/TD-LDT-469-1 https://devapps.diality.us/cru/TD-LDT-469-1 Dara Navaei started review TD-LDT-469-1 ]]> TD-LDT-94-3: closed by Sean Nash Tue, 22 Apr 2025 10:51:27 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3 https://devapps.diality.us/cru/TD-LDT-94-3 Sean Nash Closed TD-LDT-94-3 ]]> TD-LDT-94-3: reviewers finished Tue, 22 Apr 2025 10:31:05 -0700 https://devapps.diality.us/cru/TD-LDT-94-3 https://devapps.diality.us/cru/TD-LDT-94-3 Vinayakam Mani and Michael Garthwaite finished reviewing TD-LDT-94-3 TD-LDT-94_Main Treatment Screen Implement ]]> TD-LDT-94-3: comment by Michael Garthwaite "RESOLVED." Tue, 22 Apr 2025 09:39:33 -0700 Michael Garthwaite https://devapps.diality.us/cru/TD-LDT-94-3/#c21963 https://devapps.diality.us/cru/TD-LDT-94-3/#c21963 Michael Garthwaite replied to Sean Nash in TD-LDT-94-3

RESOLVED.

]]> TD-LDT-94-3: comment by Michael Garthwaite "RESOLVED." Tue, 22 Apr 2025 09:39:21 -0700 Michael Garthwaite https://devapps.diality.us/cru/TD-LDT-94-3/#c21962 https://devapps.diality.us/cru/TD-LDT-94-3/#c21962 Michael Garthwaite replied to Sean Nash in TD-LDT-94-3

RESOLVED.

]]> TD-LDT-94-3: comment by Sean Nash "These get set (lines 485 and 488) before they a..." Tue, 22 Apr 2025 09:34:34 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21961 https://devapps.diality.us/cru/TD-LDT-94-3/#c21961 Sean Nash replied to Michael Garthwaite in TD-LDT-94-3

These get set (lines 485 and 488) before they are used (line 491). No need to initialize before then.

]]> TD-LDT-94-3: comment by Sean Nash "OperationModes.c init function is only at power..." Tue, 22 Apr 2025 09:31:54 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21960 https://devapps.diality.us/cru/TD-LDT-94-3/#c21960 Sean Nash replied to Michael Garthwaite in TD-LDT-94-3

OperationModes.c init function is only at power up. This call to init treatment mode is intended to re-init treatment mode before each treatment starts.

]]> TD-LDT-94-3: comment by Michael Garthwaite "Shouldn't these bools be set to a specific valu..." Tue, 22 Apr 2025 09:21:59 -0700 Michael Garthwaite https://devapps.diality.us/cru/TD-LDT-94-3/#c21959 https://devapps.diality.us/cru/TD-LDT-94-3/#c21959 Michael Garthwaite commented on TD-LDT-94-3

Shouldn't these bools be set to a specific value?

]]> TD-LDT-94-3: comment by Michael Garthwaite "this init is already being called in operationm..." Tue, 22 Apr 2025 09:19:39 -0700 Michael Garthwaite https://devapps.diality.us/cru/TD-LDT-94-3/#c21958 https://devapps.diality.us/cru/TD-LDT-94-3/#c21958 Michael Garthwaite commented on TD-LDT-94-3

this init is already being called in operationmode.c's init function. Do we need the redundancy?

]]> TD-LDT-94-3: comment by Sean Nash "Done." Tue, 22 Apr 2025 08:41:23 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21955 https://devapps.diality.us/cru/TD-LDT-94-3/#c21955 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Done.

]]> TD-LDT-94-3: comment by Sean Nash "Fixed." Mon, 21 Apr 2025 17:16:05 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21946 https://devapps.diality.us/cru/TD-LDT-94-3/#c21946 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Fixed.

]]> TD-LDT-94-3: comment by Sean Nash "Fixed." Mon, 21 Apr 2025 17:15:31 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21945 https://devapps.diality.us/cru/TD-LDT-94-3/#c21945 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Fixed.

]]> TD-LDT-94-3: comment by Sean Nash "Fixed." Mon, 21 Apr 2025 17:14:10 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21944 https://devapps.diality.us/cru/TD-LDT-94-3/#c21944 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Fixed.

]]> TD-LDT-94-3: comment by Sean Nash "Removed. Not necessary." Mon, 21 Apr 2025 17:13:05 -0700 Sean Nash https://devapps.diality.us/cru/TD-LDT-94-3/#c21943 https://devapps.diality.us/cru/TD-LDT-94-3/#c21943 Sean Nash replied to Vinayakam Mani in TD-LDT-94-3

Removed. Not necessary.

]]>