Fisheye on hdfirmware/firmware/App/Controllers/DialOutFlow.h https://devapps.diality.us/changelog/~br%3DDEN-14589-DIAL-211/hdfirmware/firmware/App/Controllers/DialOutFlow.h Recent activity in "hdfirmware" under directory /firmware/App/Controllers/DialOutFlow.h HD-DEN-16499-2: closed by Dara Navaei Tue, 06 Feb 2024 13:21:41 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16499-2 https://devapps.diality.us/cru/HD-DEN-16499-2 Dara Navaei Closed HD-DEN-16499-2 ]]> HD-DEN-16499-2: reviewers finished Tue, 06 Feb 2024 13:05:34 -0800 https://devapps.diality.us/cru/HD-DEN-16499-2 https://devapps.diality.us/cru/HD-DEN-16499-2 Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16499-2 HD-DEN-16499_FW Message List Testing Issues 2 ]]> HD-DEN-16499-2: started by Dara Navaei Tue, 06 Feb 2024 10:16:23 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16499-2 https://devapps.diality.us/cru/HD-DEN-16499-2 Dara Navaei started review HD-DEN-16499-2 ]]> HD-DEN-16499-1: closed by Dara Navaei Fri, 02 Feb 2024 14:07:43 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16499-1 https://devapps.diality.us/cru/HD-DEN-16499-1 Dara Navaei Closed HD-DEN-16499-1 ]]> HD-DEN-16499-1: reviewers finished Fri, 02 Feb 2024 14:07:13 -0800 https://devapps.diality.us/cru/HD-DEN-16499-1 https://devapps.diality.us/cru/HD-DEN-16499-1 Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16499-1 HD-DEN-16499_FW Message List Testing Issues ]]> HD-DEN-16499-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 02 Feb 2024 09:31:10 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16499-1/#c19389 https://devapps.diality.us/cru/HD-DEN-16499-1/#c19389 Sean Nash replied to Dara Navaei in HD-DEN-16499-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16499-1: comment by Dara Navaei "Fixed the code." Fri, 02 Feb 2024 08:45:21 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16499-1/#c19372 https://devapps.diality.us/cru/HD-DEN-16499-1/#c19372 Dara Navaei replied to Sean Nash in HD-DEN-16499-1

Fixed the code.

]]> HD-DEN-16499-1: comment by Sean Nash "This looks wrong." Thu, 25 Jan 2024 08:56:55 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16499-1/#c19355 https://devapps.diality.us/cru/HD-DEN-16499-1/#c19355 Sean Nash commented on HD-DEN-16499-1

This looks wrong.

]]> HD-DEN-16499-1: started by Dara Navaei Tue, 23 Jan 2024 15:13:40 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16499-1 https://devapps.diality.us/cru/HD-DEN-16499-1 Dara Navaei started review HD-DEN-16499-1 ]]> HD-DEN-16512-2: closed by Vinayakam Mani Mon, 18 Dec 2023 10:24:33 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16512-2 https://devapps.diality.us/cru/HD-DEN-16512-2 Vinayakam Mani Closed HD-DEN-16512-2 ]]> HD-DEN-16512-2: reviewers finished Mon, 18 Dec 2023 09:51:51 -0800 https://devapps.diality.us/cru/HD-DEN-16512-2 https://devapps.diality.us/cru/HD-DEN-16512-2 Sean Nash and Dara Navaei finished reviewing HD-DEN-16512-2 HD-DEN-16512_Dpo Stops During Treatment After Reconfirming Dialysate Flow Rate ]]> HD-DEN-16512-1: closed by Dara Navaei Sun, 17 Dec 2023 15:54:13 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16512-1 https://devapps.diality.us/cru/HD-DEN-16512-1 Dara Navaei Closed HD-DEN-16512-1 ]]> HD-DEN-16512-2: started by Dara Navaei Fri, 15 Dec 2023 11:55:51 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16512-2 https://devapps.diality.us/cru/HD-DEN-16512-2 Dara Navaei started review HD-DEN-16512-2 ]]> HD-DEN-16512-1: reviewers finished Thu, 14 Dec 2023 13:10:40 -0800 https://devapps.diality.us/cru/HD-DEN-16512-1 https://devapps.diality.us/cru/HD-DEN-16512-1 Dara Navaei finished reviewing HD-DEN-16512-1 HD-DEN-16512_Dpo Stops During Treatment After Reconfirming Dialysate Flow Rate ]]> HD-DEN-16512-1: reviewers finished Thu, 07 Dec 2023 09:44:37 -0800 https://devapps.diality.us/cru/HD-DEN-16512-1 https://devapps.diality.us/cru/HD-DEN-16512-1 Sean Nash finished reviewing HD-DEN-16512-1 HD-DEN-16512_Dpo Stops During Treatment After Reconfirming Dialysate Flow Rate ]]> HD-DEN-16512-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 07 Dec 2023 09:41:09 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16512-1/#c19304 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19304 Sean Nash replied to Vinayakam Mani in HD-DEN-16512-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16512-1: comment by Vinayakam Mani "Done." Wed, 06 Dec 2023 16:05:03 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16512-1/#c19303 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19303 Vinayakam Mani replied to Sean Nash in HD-DEN-16512-1

Done.

]]> HD-DEN-16512-1: reviewers resumed Wed, 06 Dec 2023 15:42:53 -0800 https://devapps.diality.us/cru/HD-DEN-16512-1 https://devapps.diality.us/cru/HD-DEN-16512-1 jtaylor  (deleted user) resumed reviewing HD-DEN-16512-1 HD-DEN-16512_Dpo Stops During Treatment After Reconfirming Dialysate Flow Rate ]]> HD-DEN-16512-1: comment by Sean Nash "Consider splitting this if and the setDialysisP..." Mon, 04 Dec 2023 14:22:47 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16512-1/#c19302 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19302 Sean Nash commented on HD-DEN-16512-1

Consider splitting this if and the setDialysisParams() function into two: 1) blood flow rate changed and 2) dialysate flow rate changed.

]]> HD-DEN-16512-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 28 Nov 2023 09:25:29 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16512-1/#c19283 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19283 Sean Nash replied to Vinayakam Mani in HD-DEN-16512-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16512-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 28 Nov 2023 09:24:08 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16512-1/#c19282 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19282 Sean Nash replied to Vinayakam Mani in HD-DEN-16512-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16512-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 28 Nov 2023 09:23:58 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16512-1/#c19281 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19281 Sean Nash replied to Vinayakam Mani in HD-DEN-16512-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16512-1: comment by Vinayakam Mani "Done." Mon, 27 Nov 2023 13:35:09 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16512-1/#c19279 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19279 Vinayakam Mani replied to Sean Nash in HD-DEN-16512-1

Done.

]]> HD-DEN-16512-1: comment by Vinayakam Mani "Done." Mon, 27 Nov 2023 13:34:58 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16512-1/#c19278 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19278 Vinayakam Mani replied to Sean Nash in HD-DEN-16512-1

Done.

]]> HD-DEN-16512-1: comment by Vinayakam Mani "Done." Mon, 27 Nov 2023 13:34:49 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16512-1/#c19277 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19277 Vinayakam Mani replied to Sean Nash in HD-DEN-16512-1

Done.

]]> HD-DEN-16512-1: comment by Sean Nash "5% seems like a reasonable max step. I don't t..." Mon, 27 Nov 2023 09:26:15 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16512-1/#c19264 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19264 Sean Nash commented on HD-DEN-16512-1

5% seems like a reasonable max step. I don't think we want to go to ramp up/down states if > 5% change. I think we just want to limit the change to max 5% for a single control interval.

]]> HD-DEN-16512-1: comment by Sean Nash "Remove blank line." Mon, 27 Nov 2023 09:25:50 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16512-1/#c19263 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19263 Sean Nash commented on HD-DEN-16512-1

Remove blank line.

]]> HD-DEN-16512-1: comment by Sean Nash "Add space after if." Mon, 27 Nov 2023 09:24:45 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16512-1/#c19262 https://devapps.diality.us/cru/HD-DEN-16512-1/#c19262 Sean Nash commented on HD-DEN-16512-1

Add space after if.

]]> HD-DEN-16512-1: started by Dara Navaei Tue, 21 Nov 2023 10:00:47 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16512-1 https://devapps.diality.us/cru/HD-DEN-16512-1 Dara Navaei started review HD-DEN-16512-1 ]]> HD-DEN-11750-2: closed by Dara Navaei Thu, 19 Oct 2023 09:48:02 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2 https://devapps.diality.us/cru/HD-DEN-11750-2 Dara Navaei Closed HD-DEN-11750-2 ]]>