Fisheye on dgfirmware/firmware/App/Tasks/TaskTimer.h https://devapps.diality.us/changelog/~br%3DDEN-14645-dry-self-tests-do-not-start-complete/dgfirmware/firmware/App/Tasks/TaskTimer.h Recent activity in "dgfirmware" under directory /firmware/App/Tasks/TaskTimer.h DG-UCOMMITS-37: closed by Sean Nash Thu, 03 Aug 2023 13:21:06 -0700 Sean Nash https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash Closed DG-UCOMMITS-37 ]]> DG-UCOMMITS-37: reviewers finished Thu, 03 Aug 2023 10:09:19 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: reviewers finished Wed, 02 Aug 2023 16:01:41 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: started by Dara Navaei Mon, 08 May 2023 09:44:32 -0700 Dara Navaei https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei started review DG-UCOMMITS-37 ]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 03 Jan 2023 10:10:54 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=6499ea25921fcf67826fa0c35bb03caf411ba542 https://devapps.diality.us/changelog/dgfirmware?cs=6499ea25921fcf67826fa0c35bb03caf411ba542 Dara Navaei committed 6499ea2 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 174 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-1, +1) | History | Source | Diff
… 84 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 05 Jan 2022 20:16:06 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=025612ad77fe630889a364586de54bffe5262d56 https://devapps.diality.us/changelog/dgfirmware?cs=025612ad77fe630889a364586de54bffe5262d56 Dara Navaei committed 025612a on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 204 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DialysateFlow.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/DialysateFlow.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-2, +2) | History | Source | Diff
… 80 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Thu, 11 Nov 2021 10:57:02 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=94a190522ce398399c7b93c59f788d7666ec0060 https://devapps.diality.us/changelog/dgfirmware?cs=94a190522ce398399c7b93c59f788d7666ec0060 Dara Navaei committed 94a1905 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-0, +16) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-0, +16) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.h (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.h (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-6, +6) | History | Source | Diff
… 78 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces Mon, 31 Aug 2020 13:43:47 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=54f45c387430e440ab4607451fc84dea61f273f1 https://devapps.diality.us/changelog/dgfirmware?cs=54f45c387430e440ab4607451fc84dea61f273f1 Dara Navaei committed 54f45c3 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 231 more in dgfirmware Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-2, +2) | History | Source | Diff
… 61 more files in changeset.
]]> DG-DEN-4322-1: closed by qnguyen Fri, 28 Aug 2020 17:19:28 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1 https://devapps.diality.us/cru/DG-DEN-4322-1 qnguyen  (deleted user) Closed DG-DEN-4322-1 ]]> DG-DEN-4322-1: reviewers finished Fri, 28 Aug 2020 16:43:38 -0700 https://devapps.diality.us/cru/DG-DEN-4322-1 https://devapps.diality.us/cru/DG-DEN-4322-1 Sean Nash and pmontazemi  (deleted user) finished reviewing DG-DEN-4322-1 DG-DEN-4322_DG Water RO Rejection ]]> DG-DEN-4322-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 28 Aug 2020 16:33:08 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4322-1/#c4244 https://devapps.diality.us/cru/DG-DEN-4322-1/#c4244 pmontazemi  (deleted user) replied to qnguyen  (deleted user) in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4322-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 28 Aug 2020 16:32:49 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4322-1/#c4243 https://devapps.diality.us/cru/DG-DEN-4322-1/#c4243 pmontazemi  (deleted user) replied to qnguyen  (deleted user) in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4322-1: comment by qnguyen "Done." Wed, 26 Aug 2020 11:45:04 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3998 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3998 qnguyen  (deleted user) replied to pmontazemi  (deleted user) in DG-DEN-4322-1

Done.

]]> DG-DEN-4322-1: comment by qnguyen "Done." Wed, 26 Aug 2020 11:44:53 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3997 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3997 qnguyen  (deleted user) replied to pmontazemi  (deleted user) in DG-DEN-4322-1

Done.

]]> DG-DEN-4322-1: comment by pmontazemi "Insert extra line before return." Wed, 26 Aug 2020 10:45:48 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4322-1/#c3962 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3962 pmontazemi  (deleted user) commented on DG-DEN-4322-1

Insert extra line before return.

]]> DG-DEN-4322-1: comment by pmontazemi "{ at next line based on C Coding Standard" Wed, 26 Aug 2020 10:40:16 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4322-1/#c3957 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3957 pmontazemi  (deleted user) commented on DG-DEN-4322-1

{ at next line based on C Coding Standard

]]> DG-DEN-4322-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 26 Aug 2020 10:36:27 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3954 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3954 Sean Nash replied to Dara Navaei in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4322-1: comment by Dara Navaei "This has been fixed in Sprint26." Wed, 26 Aug 2020 10:36:14 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4322-1/#c3953 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3953 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-4322-1

This has been fixed in Sprint26.

]]> DG-DEN-4322-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 26 Aug 2020 10:35:08 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3952 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3952 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4322-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 26 Aug 2020 10:34:41 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3951 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3951 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4322-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 26 Aug 2020 10:34:25 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3950 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3950 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4322-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 26 Aug 2020 10:34:01 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3949 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3949 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4322-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 26 Aug 2020 10:32:53 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4322-1/#c3947 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3947 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-4322-1

RESOLVED in CODE WALKTHROUGH.

]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4322: Added more description to tasks Wed, 26 Aug 2020 10:08:36 -0700 Quang Nguyen <qnguyen@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=fea9457eb78e1c39fa4eb35780d2ac7c43f12ce0 https://devapps.diality.us/changelog/dgfirmware?cs=fea9457eb78e1c39fa4eb35780d2ac7c43f12ce0 Quang Nguyen <qnguyen@diality.com> committed fea9457 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 232 more in dgfirmware DEN-4322: Added more description to tasks

· /firmware/App/Controllers/Heaters.c (-4, +4) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
· /firmware/App/Tasks/TaskBG.h (-1, +1) | History | Source | Diff
· /firmware/App/Tasks/TaskGeneral.h (-1, +2) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.h (-1, +2) | History | Source | Diff
· /firmware/App/Tasks/TaskTimer.h (-1, +1) | History | Source | Diff
]]> DG-DEN-4322-1: comment by qnguyen "Fixed." Wed, 26 Aug 2020 00:31:02 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3938 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3938 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-4322-1

Fixed.

]]> DG-DEN-4322-1: comment by qnguyen "Fixed. Module Pressure should use these definit..." Wed, 26 Aug 2020 00:27:33 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3937 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3937 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-4322-1

Fixed. Module Pressure should use these definitions rather than defining its own.

]]> DG-DEN-4322-1: comment by qnguyen "Done." Wed, 26 Aug 2020 00:23:14 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3936 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3936 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-4322-1

Done.

]]> DG-DEN-4322-1: comment by qnguyen "Done." Wed, 26 Aug 2020 00:21:38 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3935 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3935 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-4322-1

Done.

]]> DG-DEN-4322-1: comment by qnguyen "Yes, it should be one blank line at the end. I ..." Wed, 26 Aug 2020 00:12:23 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3933 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3933 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-4322-1

Yes, it should be one blank line at the end. I do see in code composer there is one blank line at the end of these files.

]]> DG-DEN-4322-1: comment by qnguyen "[~dnavaei] Can you please respond to this chang..." Wed, 26 Aug 2020 00:10:53 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-4322-1/#c3932 https://devapps.diality.us/cru/DG-DEN-4322-1/#c3932 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-4322-1

Dara Navaei Can you please respond to this change?

]]>