DG-DEN-4322-1 DG-DEN-4322_DG Water RO Rejection

closed on 28 Aug 20

Author

Moderator

Reviewers

DG-DEN-4322_DG Water RO Rejection

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 83

common 0
- File AlarmDefs.h 0 Remove
- File HDDefs.h 0 Remove
- File MsgDefs.h 7 Remove
dgfirmware 0
- Folder firmware/App 0
  - Folder Controllers 0
    - File ConductivitySensors.c 24 Remove
    - File ConductivitySensors.h 0 Remove
    - File DrainPump.c 3 Remove
    - File DrainPump.h 0 Remove
    - File Heaters.c 0 Remove
    - File Heaters.h 0 Remove
    - File LoadCell.c 3 Remove
    - File LoadCell.h 0 Remove
    - File Pressures.c 0 Remove
    - File Pressures.h 0 Remove
    - File ROPump.c 0 Remove
    - File ROPump.h 0 Remove
    - File TemperatureSensors.c 12 Remove
    - File TemperatureSensors.h 0 Remove
    - File Valves.c 0 Remove
    - File Valves.h 0 Remove
  - Folder Drivers 0
    - File CPLD.c 0 Remove
    - File CPLD.h 0 Remove
    - File Comm.c 0 Remove
    - File Comm.h 0 Remove
    - File InternalADC.c 0 Remove
    - File InternalADC.h 3 Remove
    - File SafetyShutdown.c 0 Remove
    - File SafetyShutdown.h 0 Remove
  - Folder Modes 0
    - File ModeChemicalDisinfect.c 0 Remove
    - File ModeChemicalDisinfect.h 0 Remove
    - File ModeDrain.c 0 Remove
    - File ModeDrain.h 0 Remove
    - File ModeFault.c 0 Remove
    - File ModeFault.h 0 Remove
    - File ModeFill.c 0 Remove
    - File ModeFill.h 0 Remove
    - File ModeFlush.c 0 Remove
    - File ModeFlush.h 0 Remove
    - File ModeHeatDisinfect.c 0 Remove
    - File ModeHeatDisinfect.h 0 Remove
    - File ModeInitPOST.c 0 Remove
    - File ModeInitPOST.h 0 Remove
    - File ModeRecirculate.c 0 Remove
    - File ModeRecirculate.h 0 Remove
    - File ModeService.c 0 Remove
    - File ModeService.h 0 Remove
    - File ModeSolo.c 0 Remove
    - File ModeSolo.h 0 Remove
    - File ModeStandby.c 0 Remove
    - File ModeStandby.h 0 Remove
    - File OperationModes.c 0 Remove
    - File OperationModes.h 0 Remove
  - Folder Services 0
    - File AlarmMgmt.c 3 Remove
    - File AlarmMgmt.h 0 Remove
    - File CommBuffers.c 0 Remove
    - File CommBuffers.h 0 Remove
    - File FPGA.c 6 Remove
    - File FPGA.h 3 Remove
    - File Interrupts.c 0 Remove
    - File MessagePayloads.h 3 Remove
    - File MsgQueues.c 0 Remove
    - File MsgQueues.h 0 Remove
    - File PIControllers.c 0 Remove
    - File PIControllers.h 0 Remove
    - File PersistentAlarm.c 26 Remove
    - File PersistentAlarm.h 9 Remove
    - File Reservoirs.c 0 Remove
    - File Reservoirs.h 0 Remove
    - File SystemComm.c 0 Remove
    - File SystemComm.h 0 Remove
    - File SystemCommMessages.c 0 Remove
    - File SystemCommMessages.h 3 Remove
    - File WatchdogMgmt.c 0 Remove
    - File WatchdogMgmt.h 0 Remove
  - Folder Tasks 0
    - File TaskBG.c 0 Remove
    - File TaskBG.h 0 Remove
    - File TaskGeneral.c 0 Remove
    - File TaskGeneral.h 0 Remove
    - File TaskPriority.c 0 Remove
    - File TaskPriority.h 0 Remove
    - File TaskTimer.c 0 Remove
    - File TaskTimer.h 0 Remove
fwcommon 0
- File PersistentAlarm.c 2 Remove
- File PersistentAlarm.h 3 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
qnguyen (deleted user)	Author & Moderator	2h 14m	37	Done.
Sean Nash	Reviewer - Complete	2h 34m	56	RESOLVED in CODE WALKTHROUGH.
Dara Navaei	Reviewer - 100% reviewed	1h 3m	3	This has been fixed in Sprint26.
pmontazemi (deleted user)	Reviewer - Complete	1h	14	RESOLVED in CODE WALKTHROUGH.
Total		6h 53m	110

Linked issues
- DEN-4322

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/firmware/App/Services/PersistentAlarm.c Deleted 26 (0)

Click to load diff

/firmware/App/Services/PersistentAlarm.h Deleted 9 (0)

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DG-DEN-4322-1

DG-DEN-4322_DG Water RO Rejection

DG-DEN-4322-1 110

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

DG-DEN-4322_DG Water RO Rejection

DG-DEN-4322-1 110

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time