Fisheye on fwcommon/NVDataMgmtDGRecords.h https://devapps.diality.us/changelog/~br%3DDEN-15183-in-treatment-rinseback-workflow-changes/fwcommon/NVDataMgmtDGRecords.h Recent activity in "fwcommon" under directory /NVDataMgmtDGRecords.h DG-DEN-17220-1: closed by Dara Navaei Fri, 07 Feb 2025 16:12:39 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17220-1 https://devapps.diality.us/cru/DG-DEN-17220-1 Dara Navaei Closed DG-DEN-17220-1 ]]> DG-DEN-17220-1: reviewers finished Fri, 07 Feb 2025 10:03:27 -0800 https://devapps.diality.us/cru/DG-DEN-17220-1 https://devapps.diality.us/cru/DG-DEN-17220-1 jpaguio  (deleted user) and Sean Nash finished reviewing DG-DEN-17220-1 DG-DEN-17220_Release 20 P1B Staging ]]> DG-DEN-17220-1: started by Dara Navaei Thu, 06 Feb 2025 14:19:30 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17220-1 https://devapps.diality.us/cru/DG-DEN-17220-1 Dara Navaei started review DG-DEN-17220-1 ]]> DG-DEN-17135-1: closed by Dara Navaei Fri, 31 Jan 2025 16:57:30 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1 Dara Navaei Closed DG-DEN-17135-1 ]]> DG-DEN-17135-1: reviewers finished Thu, 30 Jan 2025 10:39:28 -0800 https://devapps.diality.us/cru/DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1 Sean Nash finished reviewing DG-DEN-17135-1 DG-DEN-17135_Concentrate Pump Calibration Staging ]]> DG-DEN-17135-1: reviewers finished Wed, 29 Jan 2025 17:32:19 -0800 https://devapps.diality.us/cru/DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1 Vinayakam Mani finished reviewing DG-DEN-17135-1 DG-DEN-17135_Concentrate Pump Calibration Staging ]]> DG-DEN-17135-1: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH" Wed, 29 Jan 2025 17:32:01 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-17135-1/#c21294 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21294 Vinayakam Mani replied to Dara Navaei in DG-DEN-17135-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-17135-1: comment by Dara Navaei "Updated the trigger condition. This is a calibr..." Wed, 29 Jan 2025 17:22:53 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17135-1/#c21292 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21292 Dara Navaei replied to Vinayakam Mani in DG-DEN-17135-1

Updated the trigger condition. This is a calibration and is checked in POST. The titles are POST.

]]> DG-DEN-17135-1: comment by Vinayakam Mani "The Trigger condition is little confusing. coul..." Wed, 29 Jan 2025 17:12:35 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-17135-1/#c21289 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21289 Vinayakam Mani commented on DG-DEN-17135-1

The Trigger condition is little confusing. could you please reword it? Also In title, do you want to add " fault", if it is DG fault property?

]]> DG-DEN-17135-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 29 Jan 2025 17:14:25 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-17135-1/#c21291 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21291 Sean Nash replied to Dara Navaei in DG-DEN-17135-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-17135-1: comment by Dara Navaei "Removed the typecast." Wed, 29 Jan 2025 16:28:49 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17135-1/#c21277 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21277 Dara Navaei replied to Sean Nash in DG-DEN-17135-1

Removed the typecast.

]]> DG-DEN-17135-1: comment by Sean Nash "Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T..." Wed, 29 Jan 2025 16:26:37 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-17135-1/#c21276 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21276 Sean Nash commented on DG-DEN-17135-1

Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T*) necessary? Seems like &concPump->concentratePumps[ i ] is already that type.

]]> DG-DEN-17135-1: started by Dara Navaei Wed, 20 Nov 2024 09:54:26 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1 Dara Navaei started review DG-DEN-17135-1 ]]> DG-UCOMMITS-46: closed by Dara Navaei Wed, 28 Aug 2024 09:22:21 -0700 Dara Navaei https://devapps.diality.us/cru/DG-UCOMMITS-46 https://devapps.diality.us/cru/DG-UCOMMITS-46 Dara Navaei Closed DG-UCOMMITS-46 ]]> DG-UCOMMITS-46: started by Dara Navaei Tue, 27 Aug 2024 16:38:54 -0700 Dara Navaei https://devapps.diality.us/cru/DG-UCOMMITS-46 https://devapps.diality.us/cru/DG-UCOMMITS-46 Dara Navaei started review DG-UCOMMITS-46 ]]> DG-DEN-16674-2: closed by Dara Navaei Fri, 01 Mar 2024 16:31:05 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-2 https://devapps.diality.us/cru/DG-DEN-16674-2 Dara Navaei Closed DG-DEN-16674-2 ]]> DG-DEN-16674-2: reviewers finished Fri, 01 Mar 2024 16:21:45 -0800 https://devapps.diality.us/cru/DG-DEN-16674-2 https://devapps.diality.us/cru/DG-DEN-16674-2 Vinayakam Mani and Sean Nash finished reviewing DG-DEN-16674-2 DG-DEN-16674_Td2 Calibration Feature ]]> DG-DEN-16674-2: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH" Fri, 01 Mar 2024 16:21:27 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-16674-2/#c19552 https://devapps.diality.us/cru/DG-DEN-16674-2/#c19552 Vinayakam Mani replied to Dara Navaei in DG-DEN-16674-2

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-16674-2: comment by Dara Navaei "Done" Fri, 01 Mar 2024 15:50:52 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-2/#c19551 https://devapps.diality.us/cru/DG-DEN-16674-2/#c19551 Dara Navaei replied to Vinayakam Mani in DG-DEN-16674-2

Done

]]> DG-DEN-16674-2: comment by Vinayakam Mani "Can we bring a parenthesis for better readabili..." Fri, 01 Mar 2024 13:38:40 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-16674-2/#c19550 https://devapps.diality.us/cru/DG-DEN-16674-2/#c19550 Vinayakam Mani commented on DG-DEN-16674-2

Can we bring a parenthesis for better readability?

]]> DG-DEN-16674-2: reviewers added to DG-DEN-16674_Td2 Calibration Feature Fri, 01 Mar 2024 10:54:45 -0800 https://devapps.diality.us/cru/DG-DEN-16674-2 https://devapps.diality.us/cru/DG-DEN-16674-2 Dara Navaei added Behrouz NematiPour to DG-DEN-16674-2 DG-DEN-16674_Td2 Calibration Feature ]]> DG-DEN-16674-2: started by Dara Navaei Fri, 01 Mar 2024 08:41:42 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-2 https://devapps.diality.us/cru/DG-DEN-16674-2 Dara Navaei started review DG-DEN-16674-2 ]]> DG-DEN-16674-1: closed by Dara Navaei Thu, 29 Feb 2024 14:45:27 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-1 https://devapps.diality.us/cru/DG-DEN-16674-1 Dara Navaei Closed DG-DEN-16674-1 ]]> DG-DEN-16674-1: reviewers finished Thu, 29 Feb 2024 13:45:11 -0800 https://devapps.diality.us/cru/DG-DEN-16674-1 https://devapps.diality.us/cru/DG-DEN-16674-1 Sean Nash finished reviewing DG-DEN-16674-1 DG-DEN-16674_Td2 Calibration Feature ]]> DG-DEN-16674-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 29 Feb 2024 13:44:32 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16674-1/#c19548 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19548 Sean Nash replied to Dara Navaei in DG-DEN-16674-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-16674-1: comment by Dara Navaei "Done" Thu, 29 Feb 2024 13:04:04 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-1/#c19547 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19547 Dara Navaei replied to Sean Nash in DG-DEN-16674-1

Done

]]> DG-DEN-16674-1: comment by Sean Nash "But this comment also asked that you remove the..." Thu, 29 Feb 2024 12:59:26 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16674-1/#c19546 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19546 Sean Nash replied to Dara Navaei in DG-DEN-16674-1

But this comment also asked that you remove the transition to fill mode here and add it to the fill mode function called above. It's still here.

]]> DG-DEN-16674-1: comment by Dara Navaei "No I will check the Dialin check in the functio..." Thu, 29 Feb 2024 12:51:48 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-1/#c19545 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19545 Dara Navaei replied to Sean Nash in DG-DEN-16674-1

No I will check the Dialin check in the function like the rest of the commands from Dialin.

]]> DG-DEN-16674-1: comment by Sean Nash "I don't see change. Did you push?" Thu, 29 Feb 2024 12:50:36 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16674-1/#c19544 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19544 Sean Nash replied to Dara Navaei in DG-DEN-16674-1

I don't see change. Did you push?

]]> DG-DEN-16674-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 29 Feb 2024 12:50:11 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16674-1/#c19543 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19543 Sean Nash replied to Dara Navaei in DG-DEN-16674-1

RESOLVED in CODE WALKTHROUGH.

]]>