Fisheye on application/.gitignore https://devapps.diality.us/changelog/~br%3DDEN-15287-UI-VD-S97-BPCompareBug/application/.gitignore Recent activity in "application" under directory /.gitignore UI-LEAH-1884-4: closed by Behrouz NematiPour Tue, 24 Jun 2025 15:49:19 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-LEAH-1884-4 https://devapps.diality.us/cru/UI-LEAH-1884-4 Behrouz NematiPour Closed UI-LEAH-1884-4 ]]> UI-LEAH-1884-4: started by Dara Navaei Fri, 14 Feb 2025 17:01:42 -0800 Dara Navaei https://devapps.diality.us/cru/UI-LEAH-1884-4 https://devapps.diality.us/cru/UI-LEAH-1884-4 Dara Navaei started review UI-LEAH-1884-4 ]]> UI-DEN-SUNRISE-1: closed by Dara Navaei Fri, 15 Nov 2024 12:54:28 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 Dara Navaei Closed UI-DEN-SUNRISE-1 ]]> UI-DEN-SUNRISE-1: reviewers removed from UI-DEN-SUNRISE Fri, 07 Jun 2024 09:05:01 -0700 https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 Dara Navaei removed Sean Nash and vduong  (deleted user) from UI-DEN-SUNRISE-1 UI-DEN-SUNRISE ]]> UI-DEN-SUNRISE-1: started by Dara Navaei Fri, 07 Jun 2024 09:04:34 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 https://devapps.diality.us/cru/UI-DEN-SUNRISE-1 Dara Navaei started review UI-DEN-SUNRISE-1 ]]> UI-DEN-3253-1: closed by Dara Navaei Thu, 19 Oct 2023 10:51:12 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-3253-1 https://devapps.diality.us/cru/UI-DEN-3253-1 Dara Navaei Closed UI-DEN-3253-1 ]]> UI-DEN-3253-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:51:01 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-3253-1/#c19162 https://devapps.diality.us/cru/UI-DEN-3253-1/#c19162 Dara Navaei replied to plucia  (deleted user) in UI-DEN-3253-1

RESOLVED

]]> UI-DEN-3253-1: started by Dara Navaei Thu, 19 Oct 2023 10:46:23 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-3253-1 https://devapps.diality.us/cru/UI-DEN-3253-1 Dara Navaei started review UI-DEN-3253-1 ]]> UI-UCOMMITS-5: closed by Dara Navaei Thu, 14 Sep 2023 09:49:54 -0700 Dara Navaei https://devapps.diality.us/cru/UI-UCOMMITS-5 https://devapps.diality.us/cru/UI-UCOMMITS-5 Dara Navaei Closed UI-UCOMMITS-5 ]]> UI-UCOMMITS-5: reviewers finished Thu, 14 Sep 2023 09:34:21 -0700 https://devapps.diality.us/cru/UI-UCOMMITS-5 https://devapps.diality.us/cru/UI-UCOMMITS-5 Dara Navaei finished reviewing UI-UCOMMITS-5 UI Staging Unreviewed Commits ]]> UI-UCOMMITS-5: reviewers finished Thu, 17 Aug 2023 08:39:14 -0700 https://devapps.diality.us/cru/UI-UCOMMITS-5 https://devapps.diality.us/cru/UI-UCOMMITS-5 Sean Nash finished reviewing UI-UCOMMITS-5 UI Staging Unreviewed Commits ]]> UI-UCOMMITS-5: started by Dara Navaei Sun, 06 Aug 2023 12:23:06 -0700 Dara Navaei https://devapps.diality.us/cru/UI-UCOMMITS-5 https://devapps.diality.us/cru/UI-UCOMMITS-5 Dara Navaei started review UI-UCOMMITS-5 ]]> UI-UCOMMITS-3: closed by Sean Nash Thu, 03 Aug 2023 14:23:52 -0700 Sean Nash https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Sean Nash Closed UI-UCOMMITS-3 ]]> UI-UCOMMITS-3: reviewers finished Thu, 03 Aug 2023 14:05:13 -0700 https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Dara Navaei finished reviewing UI-UCOMMITS-3 UI Staging Unreviewed Commits ]]> UI-UCOMMITS-3: reviewers finished Wed, 02 Aug 2023 09:33:38 -0700 https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Sean Nash finished reviewing UI-UCOMMITS-3 UI Staging Unreviewed Commits ]]> UI-UCOMMITS-3: started by Dara Navaei Mon, 08 May 2023 08:49:03 -0700 Dara Navaei https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Dara Navaei started review UI-UCOMMITS-3 ]]> UI-DEN-14517-1: closed by Behrouz NematiPour Fri, 10 Feb 2023 09:23:43 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-14517-1 https://devapps.diality.us/cru/UI-DEN-14517-1 Behrouz NematiPour Closed UI-DEN-14517-1 ]]> UI-DEN-14517-1: reviewers finished Fri, 10 Feb 2023 09:23:22 -0800 https://devapps.diality.us/cru/UI-DEN-14517-1 https://devapps.diality.us/cru/UI-DEN-14517-1 Michael Garthwaite , vduong  (deleted user) and jishii  (deleted user) finished reviewing UI-DEN-14517-1 UI-DEN-14517_UI BN S88 ]]> UI-DEN-14517-1: comment by vduong "Ok, sounds good. RESOLVED" Fri, 10 Feb 2023 09:17:24 -0800 vduong https://devapps.diality.us/cru/UI-DEN-14517-1/#c16480 https://devapps.diality.us/cru/UI-DEN-14517-1/#c16480 vduong  (deleted user) replied to Behrouz NematiPour in UI-DEN-14517-1

Ok, sounds good.

RESOLVED

]]> UI-DEN-14517-1: comment by Behrouz NematiPour "Good point, I agree with the two intervals, it..." Fri, 10 Feb 2023 08:03:55 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-14517-1/#c16475 https://devapps.diality.us/cru/UI-DEN-14517-1/#c16475 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-14517-1

Good point,
I agree with the two intervals, it would be clarifying.
For the counter, though, it might not be always the case.
I will start doing it in my next task, since I would like to change all, to be consistent across the entire code base.

]]> UI-DEN-14517-1: comment by vduong "Only a suggestion: It is a good idea to append..." Fri, 10 Feb 2023 07:37:51 -0800 vduong https://devapps.diality.us/cru/UI-DEN-14517-1/#c16473 https://devapps.diality.us/cru/UI-DEN-14517-1/#c16473 vduong  (deleted user) commented on UI-DEN-14517-1

Only a suggestion:
It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity.

For instance, here, we have ms and the next one, _pendingInterval is in seconds. and I believe _pendingCounter is in minutes based on the .cpp file's comment.

_interval_ms
_pendingInterval_sec
_pendingCounter_min

]]> UI-DEN-14517-1: comment by vduong "RESOLVED" Fri, 10 Feb 2023 07:16:23 -0800 vduong https://devapps.diality.us/cru/UI-DEN-14517-1/#c16472 https://devapps.diality.us/cru/UI-DEN-14517-1/#c16472 vduong  (deleted user) replied to Behrouz NematiPour in UI-DEN-14517-1

RESOLVED

]]> UI-DEN-14517-1: comment by Behrouz NematiPour "Thanks for the feedback. Fixed." Fri, 10 Feb 2023 07:12:48 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-14517-1/#c16471 https://devapps.diality.us/cru/UI-DEN-14517-1/#c16471 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-14517-1

Thanks for the feedback.
Fixed.

]]> UI-DEN-14517-1: comment by vduong "The variable, destination, itself is a QString,..." Fri, 10 Feb 2023 07:03:29 -0800 vduong https://devapps.diality.us/cru/UI-DEN-14517-1/#c16470 https://devapps.diality.us/cru/UI-DEN-14517-1/#c16470 vduong  (deleted user) commented on UI-DEN-14517-1

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.

]]> UI-DEN-14733-1: closed by Dara Navaei Fri, 03 Feb 2023 08:22:47 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-14733-1 https://devapps.diality.us/cru/UI-DEN-14733-1 Dara Navaei Closed UI-DEN-14733-1 ]]> UI-DEN-14733-1: reviewers finished Thu, 02 Feb 2023 17:19:57 -0800 https://devapps.diality.us/cru/UI-DEN-14733-1 https://devapps.diality.us/cru/UI-DEN-14733-1 vduong  (deleted user) , jishii  (deleted user) , Michael Garthwaite and Dara Navaei finished reviewing UI-DEN-14733-1 UI-DEN-14733_UI BN S90 ]]> UI-DEN-14733-1: reviewers added to UI-DEN-14733_UI BN S90 Thu, 02 Feb 2023 15:50:42 -0800 https://devapps.diality.us/cru/UI-DEN-14733-1 https://devapps.diality.us/cru/UI-DEN-14733-1 Behrouz NematiPour added jreaume  (deleted user) and vduong  (deleted user) to UI-DEN-14733-1 UI-DEN-14733_UI BN S90 ]]> application (bugfix/DEN-16597-UI-BN-S114): DEN-14736 IMP: Update states... Thu, 02 Feb 2023 13:53:16 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/application?cs=e699d00afc964052ec0e91ca72e101d21aa00413 https://devapps.diality.us/changelog/application?cs=e699d00afc964052ec0e91ca72e101d21aa00413 Behrouz NematiPour committed e699d00 on branch master, @Environement_Swith and 179 more in application DEN-14736 IMP: Update states

- Updated states regarding changes have been made in FW Common

- \sa : http://devapps.diality.us:8060/cru/HD-DEN-14549-1
· /.gitignore (-0, +2) | History | Source | Diff
· /imake.sh (-2, +10) | History | Source | Diff
· /sources/gui/qml/pages/pretreatment/PreTreatmentConsumablesStack.qml (-1, +1) | History | Source | Diff
· /sources/gui/qml/pages/pretreatment/PreTreatmentDisposablesStack.qml (-1, +0) | History | Source | Diff
· /sources/gui/qml/pages/pretreatment/PreTreatmentPrimeStack.qml (-1, +1) | History | Source | Diff
· /sources/gui/qml/pages/pretreatment/PreTreatmentStack.qml (-1, +1) | History | Source | Diff
· /sources/view/hd/data/pretreatment/VPreTreatmentStatesData.cpp (-8, +2) | History | Source | Diff
· /sources/view/hd/data/pretreatment/VPreTreatmentStatesData.h (-6, +3) | History | Source | Diff
· /sources/view/hd/data/treatment/VHDTreatmentStatesData.cpp (-4, +0) | History | Source | Diff
· /sources/view/hd/data/treatment/VHDTreatmentStatesData.h (-5, +0) | History | Source | Diff
]]> UI-DEN-14733-1: started by Dara Navaei Thu, 02 Feb 2023 13:01:26 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-14733-1 https://devapps.diality.us/cru/UI-DEN-14733-1 Dara Navaei started review UI-DEN-14733-1 ]]> UI-DEN-7044-2: closed by Behrouz NematiPour Wed, 01 Feb 2023 00:00:46 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-7044-2 https://devapps.diality.us/cru/UI-DEN-7044-2 Behrouz NematiPour Closed UI-DEN-7044-2 ]]>