UI-DEN-3253-1 UI-DEN-3253_UI Alarm Design

closed on 19 Oct 23

Author

Moderator

Reviewers

Michael Garthwaite
Dara Navaei
Tiffany Mejia
vduong (deleted user)
msuleiman (deleted user)

UI-DEN-3253_UI Alarm Design

Activity

Details
Objectives
General Comments 3
Unresolved
Resolved
Number of files included: 44

application 0
- Folder resources/images 0
  - File alarm.svg 10 Remove
  - File bell-off.svg 11 Remove
  - File bell.svg 8 Remove
- Folder scripts 0
  - File run.sh 0 Remove
- Folder sources 0
  - Folder canbus 0
    - File messagedispatcher.cpp 0 Remove
    - File messagedispatcher.h 3 Remove
    - File messageglobals.h 3 Remove
    - File messageinterpreter.cpp 12 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File ModalDialog.qml 3 Remove
        
        File NotificationBar.qml 39 Remove
        
        File NotificationBar2.qml 0 Remove
        
        File NotificationBarSmall.qml 6 Remove
        
        File SettingsItem.qml 5 Remove
        
        File TouchArea.qml 5 Remove
        
        File TouchRect.qml 0 Remove
      - Folder dialogs 0
        
        File Alarm.qml 6 Remove
        
        File NotificationDialog.qml 13 Remove
      - Folder globals 0
        
        File Colors.qml 8 Remove
        
        File Fonts.qml 4 Remove
        
        File Variables.qml 0 Remove
      - Folder pages 0
        
        Folder treatment/adjustments 0
        
        File TreatmentAdjustmentBase.qml 7 Remove
        
        File Diagnostics.qml 14 Remove
        
        File SettingsHome.qml 9 Remove
      - File main.qml 3 Remove
    - File guicontroller.cpp 0 Remove
    - File guicontroller.h 3 Remove
    - File guiglobals.h 5 Remove
    - File guiview.h 3 Remove
  - Folder model 0
    - File malarmstatus.cpp 16 Remove
    - File malarmstatus.h 0 Remove
  - Folder view 0
    - File valarmstatus.cpp 8 Remove
    - File valarmstatus.h 3 Remove
  - File applicationcontroller.cpp 0 Remove
  - File applicationcontroller.h 14 Remove
  - File main.h 0 Remove
- Folder unittests 0
  - File tst_messaging.cpp 6 Remove
  - File tst_messaging.h 0 Remove
  - File tst_models.cpp 3 Remove
  - File tst_models.h 3 Remove
- File .gitignore 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
- File main.cpp 8 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
plucia (deleted user)	Author & Moderator	7h 20m	90	Done
Behrouz NematiPour	Reviewer - Complete	8h 57m	107	RESOLVED
pmontazemi (deleted user)	Reviewer - Complete	1h 18m	46	RESOLVED.
Sean Nash	Reviewer - 0% reviewed
Michael Garthwaite	Reviewer - 0% reviewed
Dara Navaei	Reviewer - 0% reviewed		1	RESOLVED
Tiffany Mejia	Reviewer - 0% reviewed
vduong (deleted user)	Reviewer - 0% reviewed
msuleiman (deleted user)	Reviewer - 0% reviewed
Total		17h 36m	244

Linked issues
- DEN-3253

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Behrouz NematiPour

It seems Jira is doing its best to confuse the user with this whole slider of...

It seems Jira is doing its best to confuse the user with this whole slider of commits and not showing the comments in order and sometimes even hiding comments.
I totally don't understand the purpose of these confusing features.
Source versioning is so simple and don't need to be complicated by this unnecessary features.

So please forgive me if because of this <not a good adjective> features I put some comments which are irrelevant.
Thanks,

26 Jun 20

Behrouz NematiPour

Resolved

06 Jul 20

plucia (deleted user)

No problem Behrouz. Your comment is noted. Since there is no action item in ...

No problem Behrouz. Your comment is noted.

Since there is no action item in this comment could you resolve it?

01 Jul 20

Behrouz NematiPour

RESOLVED

06 Jul 20

Click to load diff

/sources/.../components/NotificationBar2.qml Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-3253-1

UI-DEN-3253_UI Alarm Design

UI-DEN-3253-1 244

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

plucia (deleted user)

Behrouz NematiPour

Log time

UI-DEN-3253_UI Alarm Design

UI-DEN-3253-1 244

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

plucia (deleted user)

Behrouz NematiPour

Log time