Fisheye on hdfirmware/firmware/App/Controllers/Switches.c https://devapps.diality.us/changelog/~br%3DDEN-15792-hd-software-design-description/hdfirmware/firmware/App/Controllers/Switches.c Recent activity in "hdfirmware" under directory /firmware/App/Controllers/Switches.c HD-DEN-16693-2: closed by Dara Navaei Fri, 15 Mar 2024 08:57:33 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-2 https://devapps.diality.us/cru/HD-DEN-16693-2 Dara Navaei Closed HD-DEN-16693-2 ]]> HD-DEN-16693-2: reviewers finished Thu, 14 Mar 2024 17:25:52 -0700 https://devapps.diality.us/cru/HD-DEN-16693-2 https://devapps.diality.us/cru/HD-DEN-16693-2 Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16693-2 HD-DEN-16693_Institutional Settings Implementation ]]> HD-DEN-16693-2: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH." Thu, 14 Mar 2024 17:24:43 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16693-2/#c19630 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19630 Vinayakam Mani replied to Dara Navaei in HD-DEN-16693-2

RESOLVED IN CODE WALKTHROUGH.

]]> HD-DEN-16693-2: comment by Vinayakam Mani "RESOLVED IN CODEWALKTHROUGH" Thu, 14 Mar 2024 17:23:07 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16693-2/#c19629 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19629 Vinayakam Mani replied to Dara Navaei in HD-DEN-16693-2

RESOLVED IN CODEWALKTHROUGH

]]> HD-DEN-16693-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 14 Mar 2024 17:20:08 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-2/#c19628 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19628 Sean Nash replied to Dara Navaei in HD-DEN-16693-2

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16693-2: comment by Dara Navaei "Done" Thu, 14 Mar 2024 17:17:42 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-2/#c19627 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19627 Dara Navaei replied to Vinayakam Mani in HD-DEN-16693-2

Done

]]> HD-DEN-16693-2: comment by Dara Navaei "This is in a different function. I can remove." Thu, 14 Mar 2024 17:17:08 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-2/#c19626 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19626 Dara Navaei replied to Sean Nash in HD-DEN-16693-2

This is in a different function. I can remove.

]]> HD-DEN-16693-2: comment by Dara Navaei "Done" Thu, 14 Mar 2024 17:16:22 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-2/#c19625 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19625 Dara Navaei replied to Vinayakam Mani in HD-DEN-16693-2

Done

]]> HD-DEN-16693-2: comment by Sean Nash "I thought we weren't going to do this anymore?" Thu, 14 Mar 2024 17:16:04 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-2/#c19624 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19624 Sean Nash commented on HD-DEN-16693-2

I thought we weren't going to do this anymore?

]]> HD-DEN-16693-2: comment by Vinayakam Mani "Let's keep "///" 3 line comment for doxygen gen..." Thu, 14 Mar 2024 17:08:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16693-2/#c19623 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19623 Vinayakam Mani commented on HD-DEN-16693-2

Let's keep "///" 3 line comment for doxygen generation.

]]> HD-DEN-16693-2: comment by Vinayakam Mani "lets keep "///" comment for doxygen generation." Thu, 14 Mar 2024 17:06:30 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16693-2/#c19622 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19622 Vinayakam Mani commented on HD-DEN-16693-2

lets keep "///" comment for doxygen generation.

]]> HD-DEN-16693-2: started by Dara Navaei Thu, 14 Mar 2024 14:11:34 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-2 https://devapps.diality.us/cru/HD-DEN-16693-2 Dara Navaei started review HD-DEN-16693-2 ]]> HD-DEN-16693-1: closed by Dara Navaei Fri, 08 Mar 2024 15:42:16 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-1 https://devapps.diality.us/cru/HD-DEN-16693-1 Dara Navaei Closed HD-DEN-16693-1 ]]> HD-DEN-16693-1: reviewers finished Fri, 08 Mar 2024 15:42:00 -0800 https://devapps.diality.us/cru/HD-DEN-16693-1 https://devapps.diality.us/cru/HD-DEN-16693-1 Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16693-1 HD-DEN-16693_Institutional Settings Implementation ]]> HD-DEN-16693-1: comment by pvedantam "RESOLVED IN CODE WALKTHGROUGH" Fri, 08 Mar 2024 15:33:10 -0800 pvedantam https://devapps.diality.us/cru/HD-DEN-16693-1/#c19597 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19597 pvedantam  (deleted user) replied to pvedantam  (deleted user) in HD-DEN-16693-1

RESOLVED IN CODE WALKTHGROUGH

]]> HD-DEN-16693-1: comment by pvedantam "We did not check for the upper limit in the pas..." Fri, 08 Mar 2024 15:16:10 -0800 pvedantam https://devapps.diality.us/cru/HD-DEN-16693-1/#c19596 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19596 pvedantam  (deleted user) commented on HD-DEN-16693-1

We did not check for the upper limit in the past, does this add new rejection scenarios

]]> HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 07 Mar 2024 15:13:57 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19589 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19589 Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16693-1: comment by Dara Navaei "Done" Thu, 07 Mar 2024 15:02:02 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-1/#c19588 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19588 Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

]]> HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 07 Mar 2024 14:59:10 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19587 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19587 Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16693-1: comment by Sean Nash "Add minimum check here too." Thu, 07 Mar 2024 14:58:16 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19586 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19586 Sean Nash commented on HD-DEN-16693-1

Add minimum check here too.

]]> HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 07 Mar 2024 14:56:47 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19585 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19585 Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16693-1: comment by Dara Navaei "Done" Thu, 07 Mar 2024 14:46:22 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-1/#c19584 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19584 Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

]]> HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 07 Mar 2024 14:41:12 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19583 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19583 Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16693-1: comment by Dara Navaei "Done" Thu, 07 Mar 2024 14:38:48 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-1/#c19582 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19582 Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

]]> HD-DEN-16693-1: comment by Sean Nash "Do we need to add check for minimum treatment d..." Thu, 07 Mar 2024 14:35:48 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19581 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19581 Sean Nash commented on HD-DEN-16693-1

Do we need to add check for minimum treatment duration?

]]> HD-DEN-16693-1: comment by Sean Nash "Cast constant as (F32) as before." Thu, 07 Mar 2024 14:32:54 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19580 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19580 Sean Nash commented on HD-DEN-16693-1

Cast constant as (F32) as before.

]]> HD-DEN-16693-1: comment by Dara Navaei "Done" Thu, 07 Mar 2024 14:14:14 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-1/#c19579 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19579 Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

]]> HD-DEN-16693-1: comment by Sean Nash "dialVolume is a volume (not a flow). Use const..." Thu, 07 Mar 2024 14:10:47 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19578 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19578 Sean Nash commented on HD-DEN-16693-1

dialVolume is a volume (not a flow). Use constant (as before) for dialVolume check.

]]> HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 Mar 2024 10:14:39 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19556 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19556 Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16693-1: comment by Dara Navaei "Done" Mon, 04 Mar 2024 12:55:19 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-1/#c19554 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19554 Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

]]>