Fisheye on hdfirmware/firmware/App/Controllers/Valves.c https://devapps.diality.us/changelog/~br%3DDEN-15792-hd-software-design-description/hdfirmware/firmware/App/Controllers/Valves.c Recent activity in "hdfirmware" under directory /firmware/App/Controllers/Valves.c HD-DEN-16693-2: closed by Dara Navaei Fri, 15 Mar 2024 08:57:33 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-2 https://devapps.diality.us/cru/HD-DEN-16693-2 Dara Navaei Closed HD-DEN-16693-2 ]]> HD-DEN-16693-2: reviewers finished Thu, 14 Mar 2024 17:25:52 -0700 https://devapps.diality.us/cru/HD-DEN-16693-2 https://devapps.diality.us/cru/HD-DEN-16693-2 Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16693-2 HD-DEN-16693_Institutional Settings Implementation ]]> HD-DEN-16693-2: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH." Thu, 14 Mar 2024 17:24:43 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16693-2/#c19630 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19630 Vinayakam Mani replied to Dara Navaei in HD-DEN-16693-2

RESOLVED IN CODE WALKTHROUGH.

]]> HD-DEN-16693-2: comment by Vinayakam Mani "RESOLVED IN CODEWALKTHROUGH" Thu, 14 Mar 2024 17:23:07 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16693-2/#c19629 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19629 Vinayakam Mani replied to Dara Navaei in HD-DEN-16693-2

RESOLVED IN CODEWALKTHROUGH

]]> HD-DEN-16693-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 14 Mar 2024 17:20:08 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-2/#c19628 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19628 Sean Nash replied to Dara Navaei in HD-DEN-16693-2

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16693-2: comment by Dara Navaei "Done" Thu, 14 Mar 2024 17:17:42 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-2/#c19627 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19627 Dara Navaei replied to Vinayakam Mani in HD-DEN-16693-2

Done

]]> HD-DEN-16693-2: comment by Dara Navaei "This is in a different function. I can remove." Thu, 14 Mar 2024 17:17:08 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-2/#c19626 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19626 Dara Navaei replied to Sean Nash in HD-DEN-16693-2

This is in a different function. I can remove.

]]> HD-DEN-16693-2: comment by Dara Navaei "Done" Thu, 14 Mar 2024 17:16:22 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-2/#c19625 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19625 Dara Navaei replied to Vinayakam Mani in HD-DEN-16693-2

Done

]]> HD-DEN-16693-2: comment by Sean Nash "I thought we weren't going to do this anymore?" Thu, 14 Mar 2024 17:16:04 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-2/#c19624 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19624 Sean Nash commented on HD-DEN-16693-2

I thought we weren't going to do this anymore?

]]> HD-DEN-16693-2: comment by Vinayakam Mani "Let's keep "///" 3 line comment for doxygen gen..." Thu, 14 Mar 2024 17:08:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16693-2/#c19623 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19623 Vinayakam Mani commented on HD-DEN-16693-2

Let's keep "///" 3 line comment for doxygen generation.

]]> HD-DEN-16693-2: comment by Vinayakam Mani "lets keep "///" comment for doxygen generation." Thu, 14 Mar 2024 17:06:30 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16693-2/#c19622 https://devapps.diality.us/cru/HD-DEN-16693-2/#c19622 Vinayakam Mani commented on HD-DEN-16693-2

lets keep "///" comment for doxygen generation.

]]> HD-DEN-16693-2: started by Dara Navaei Thu, 14 Mar 2024 14:11:34 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-2 https://devapps.diality.us/cru/HD-DEN-16693-2 Dara Navaei started review HD-DEN-16693-2 ]]> HD-DENBUG-200-2: closed by Sean Nash Tue, 13 Feb 2024 09:05:26 -0800 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-200-2 https://devapps.diality.us/cru/HD-DENBUG-200-2 Sean Nash Closed HD-DENBUG-200-2 ]]> HD-DENBUG-200-1: closed by Sean Nash Tue, 13 Feb 2024 08:56:36 -0800 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-200-1 https://devapps.diality.us/cru/HD-DENBUG-200-1 Sean Nash Closed HD-DENBUG-200-1 ]]> HD-DENBUG-200-2: reviewers finished Mon, 12 Feb 2024 15:17:49 -0800 https://devapps.diality.us/cru/HD-DENBUG-200-2 https://devapps.diality.us/cru/HD-DENBUG-200-2 Vinayakam Mani and Dara Navaei finished reviewing HD-DENBUG-200-2 HD-DENBUG-200_Alarm 58 Triggers When Cartri ]]> HD-DENBUG-200-1: reviewers finished Mon, 12 Feb 2024 15:15:39 -0800 https://devapps.diality.us/cru/HD-DENBUG-200-1 https://devapps.diality.us/cru/HD-DENBUG-200-1 Vinayakam Mani and Dara Navaei finished reviewing HD-DENBUG-200-1 HD-DENBUG-200_Alarm 58 Triggers When Cartri ]]> HD-DENBUG-200-2: reviewers joined HD-DENBUG-200_Alarm 58 Triggers When Cartri Mon, 12 Feb 2024 14:12:14 -0800 https://devapps.diality.us/cru/HD-DENBUG-200-2 https://devapps.diality.us/cru/HD-DENBUG-200-2 Dara Navaei joined HD-DENBUG-200-2 HD-DENBUG-200_Alarm 58 Triggers When Cartri ]]> HD-DENBUG-200-2: reviewers removed from HD-DENBUG-200_Alarm 58 Triggers When Cartri Mon, 12 Feb 2024 14:12:14 -0800 https://devapps.diality.us/cru/HD-DENBUG-200-2 https://devapps.diality.us/cru/HD-DENBUG-200-2 Dara Navaei removed Sean Nash from HD-DENBUG-200-2 HD-DENBUG-200_Alarm 58 Triggers When Cartri ]]> HD-DENBUG-200-1: reviewers joined HD-DENBUG-200_Alarm 58 Triggers When Cartri Mon, 12 Feb 2024 14:11:26 -0800 https://devapps.diality.us/cru/HD-DENBUG-200-1 https://devapps.diality.us/cru/HD-DENBUG-200-1 Dara Navaei joined HD-DENBUG-200-1 HD-DENBUG-200_Alarm 58 Triggers When Cartri ]]> HD-DENBUG-200-1: reviewers removed from HD-DENBUG-200_Alarm 58 Triggers When Cartri Mon, 12 Feb 2024 14:11:26 -0800 https://devapps.diality.us/cru/HD-DENBUG-200-1 https://devapps.diality.us/cru/HD-DENBUG-200-1 Dara Navaei removed Sean Nash from HD-DENBUG-200-1 HD-DENBUG-200_Alarm 58 Triggers When Cartri ]]> HD-DENBUG-200-2: started by Dara Navaei Mon, 12 Feb 2024 14:10:26 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-200-2 https://devapps.diality.us/cru/HD-DENBUG-200-2 Dara Navaei started review HD-DENBUG-200-2 ]]> HD-DENBUG-200-1: started by Dara Navaei Mon, 12 Feb 2024 14:10:16 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-200-1 https://devapps.diality.us/cru/HD-DENBUG-200-1 Dara Navaei started review HD-DENBUG-200-1 ]]> HD-DEN-16446-2: closed by Dara Navaei Fri, 20 Oct 2023 09:23:54 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 Dara Navaei Closed HD-DEN-16446-2 ]]> HD-DEN-16446-2: reviewers finished Fri, 20 Oct 2023 08:15:29 -0700 https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 Sean Nash finished reviewing HD-DEN-16446-2 HD-DEN-16446_HD Dev Test Clean UP Vectorcast ]]> HD-DEN-16446-2: reviewers finished Thu, 19 Oct 2023 16:37:30 -0700 https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 wbracken  (deleted user) finished reviewing HD-DEN-16446-2 HD-DEN-16446_HD Dev Test Clean UP Vectorcast ]]> HD-DEN-16446-2: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Thu, 19 Oct 2023 16:36:33 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-16446-2/#c19222 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19222 wbracken  (deleted user) replied to Dara Navaei in HD-DEN-16446-2

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-16446-2: comment by Dara Navaei "The result will be an unsigned integer" Thu, 19 Oct 2023 14:23:26 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16446-2/#c19206 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19206 Dara Navaei replied to wbracken  (deleted user) in HD-DEN-16446-2

The result will be an unsigned integer

]]> HD-DEN-16446-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 19 Oct 2023 14:11:04 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16446-2/#c19205 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19205 Sean Nash replied to Vinayakam Mani in HD-DEN-16446-2

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16446-2: comment by Vinayakam Mani "In the If conditions, we check "uFVolume > colU..." Thu, 19 Oct 2023 13:33:29 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16446-2/#c19204 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19204 Vinayakam Mani replied to Sean Nash in HD-DEN-16446-2

In the If conditions, we check "uFVolume > colUFVol" conditions, that makes uFRate always positive and hence the condition for minimum check is not required.

]]> HD-DEN-11750-2: closed by Dara Navaei Thu, 19 Oct 2023 09:48:02 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2 https://devapps.diality.us/cru/HD-DEN-11750-2 Dara Navaei Closed HD-DEN-11750-2 ]]>