Fisheye on application/sources/gui/qml/components/TimeText.qml

UI-UCOMMITS-3: closed by Sean Nash

Sean Nash — Thu, 03 Aug 2023 14:23:52 -0700

Sean Nash Closed UI-UCOMMITS-3

UI-UCOMMITS-3: reviewers finished

Thu, 03 Aug 2023 14:05:13 -0700

Dara Navaei finished reviewing UI-UCOMMITS-3

UI Staging Unreviewed Commits

UI-UCOMMITS-3: reviewers finished

Wed, 02 Aug 2023 09:33:38 -0700

Sean Nash finished reviewing UI-UCOMMITS-3

UI Staging Unreviewed Commits

UI-UCOMMITS-3: started by Dara Navaei

Dara Navaei — Mon, 08 May 2023 08:49:03 -0700

Dara Navaei started review UI-UCOMMITS-3

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 04 Jan 2023 16:48:39 -0800

Dara Navaei committed c9f8f8c on branch master, @Environement_Swith and 181 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /alarmMapping.sh

(-1, +1)

| History

| Source

| Diff

· /cppcheck.sh

(-2, +2)

| History

| Source

| Diff

· /cr_objectives.sh

(-1, +1)

| History

| Source

| Diff

· /imake.sh

(-1, +1)

| History

| Source

| Diff

· /main.cpp

(-1, +1)

| History

| Source

| Diff

· /remove-exra-emptylines.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/autostart

(-2, +2)

| History

| Source

| Diff

· /scripts/bluetooth_paired_clear.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/bluetooth_paired_query.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/brightness_get.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/brightness_set.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/date_time_set.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/export_logs.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/globals.sh

(-3, +4)

| History

| Source

| Diff

· /scripts/run.sh

(-3, +3)

| History

| Source

| Diff

… 594 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 28 Sep 2022 16:41:05 -0700

Dara Navaei committed 265ce74 on branch master, @Environement_Swith and 191 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /main.cpp

(-1, +1)

| History

| Source

| Diff

· /scripts/run.sh

(-1, +1)

| History

| Source

| Diff

· /sources/AlarmGenerator.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/AlarmGenerator.h

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationController.h

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationPost.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationPost.h

(-1, +1)

| History

| Source

| Diff

· /sources/MainTimer.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/Threads.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/Threads.h

(-1, +1)

| History

| Source

| Diff

· /sources/bluetooth/BluetoothInterface.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/FrameInterface.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageDispatcher.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageDispatcher.h

(-1, +1)

| History

| Source

| Diff

… 81 more files in changeset.

UI-DEN-13198-1: closed by Behrouz NematiPour

Behrouz NematiPour — Wed, 28 Sep 2022 16:26:44 -0700

Behrouz NematiPour Closed UI-DEN-13198-1

UI-DEN-13198-1: reviewers finished

Mon, 26 Sep 2022 08:13:58 -0700

Tiffany Mejia finished reviewing UI-DEN-13198-1

UI-DEN-13198_UI BN 75

UI-DEN-13198-1: comment by jishii "RESOLVED"

jishii — Mon, 26 Sep 2022 07:47:23 -0700

jishii (deleted user) replied to Behrouz NematiPour in UI-DEN-13198-1

RESOLVED

UI-DEN-13198-1: comment by jishii "RESOLVED"

jishii — Mon, 26 Sep 2022 07:47:06 -0700

jishii (deleted user) replied to Behrouz NematiPour in UI-DEN-13198-1

RESOLVED

UI-DEN-13198-1: comment by Behrouz NematiPour "A bug has been created for that. I need to wor..."

Behrouz NematiPour — Sun, 25 Sep 2022 21:56:56 -0700

Behrouz NematiPour replied to jishii (deleted user) in UI-DEN-13198-1

A bug has been created for that.
I need to work on it and test it.
Please resolve and will follow up under the bug: DEN-14006

UI-DEN-13198-1: comment by Behrouz NematiPour "A bug has been created for that. I need to wor..."

Behrouz NematiPour — Sun, 25 Sep 2022 21:56:26 -0700

Behrouz NematiPour replied to jishii (deleted user) in UI-DEN-13198-1

A bug has been created for that.
I need to work on it and test it.
Please resolve and will follow up under the bug: DEN-14006

UI-DEN-13198-1: reviewers finished

Fri, 23 Sep 2022 09:16:17 -0700

jishii (deleted user) finished reviewing UI-DEN-13198-1

UI-DEN-13198_UI BN 75

UI-DEN-13198-1: comment by jishii "Missing square brackets around equality check"

jishii — Mon, 19 Sep 2022 15:58:13 -0700

jishii (deleted user) commented on UI-DEN-13198-1

Missing square brackets around equality check

UI-DEN-13198-1: comment by jishii "During installation last week was having issues..."

jishii — Mon, 19 Sep 2022 15:55:33 -0700

jishii (deleted user) commented on UI-DEN-13198-1

During installation last week was having issues where this check seems to be looking for $CLOUDSYNC_FOLDER in root directory, whereas instructions say to install cloudsync folder in home directory, if I'm understanding correctly the condition should be $HOME$CLOUDSYNC_FOLDER

UI-DEN-13198-1: reviewers added to UI-DEN-13198_UI BN 75

Mon, 19 Sep 2022 14:12:04 -0700

Dara Navaei added jishii (deleted user) to UI-DEN-13198-1

UI-DEN-13198_UI BN 75

UI-DEN-13198-1: reviewers finished

Fri, 16 Sep 2022 10:12:01 -0700

Sean Nash finished reviewing UI-DEN-13198-1

UI-DEN-13198_UI BN 75

UI-DEN-13198-1: started by Dara Navaei

Dara Navaei — Thu, 08 Sep 2022 18:05:58 -0700

Dara Navaei started review UI-DEN-13198-1

application (bugfix/DEN-16597-UI-BN-S114): DEN-13743: IMP: Mostly worked on Alarm Dialog/Bar...

Behrouz NematiPour — Tue, 30 Aug 2022 19:25:33 -0700

Behrouz NematiPour committed efb549a on branch master, @Environement_Swith and 192 more in application

DEN-13743: IMP: Mostly worked on Alarm Dialog/Bar

- Changed the Alarm Dialog (Title decreased by 4, Description increased by 4) / Bar (increased by 6) font size,

- Adjusted the AlarmDialog Timer position and layout.

- Removed the mouseArea from the WaitDone component.

- Added titel/description fontPixedSize for the NotificationDialog and NotificationBar

- Clear the reasontext on home screen when is not visible anymore.

- Clear the reasontext on SettingsDG when is not visible anymore.

- Used NotificationBarSmall instead of NotificationBar in:

- ModalDialog

- MainHome

- TreatmentAdjustmentBase

- TreatmentFlowBase

· /AlarmMapping.csv	(-1, +1)	\| History	\| Source	\| Diff
· /denali.pro.user	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/AlarmItem.qml	(-0, +3)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/ModalDialog.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/NotificationBar.qml	(-0, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/TimeText.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/WaitDone.qml	(-4, +0)	\| History	\| Source	\| Diff
· /sources/gui/qml/dialogs/NotificationDialog.qml	(-4, +10)	\| History	\| Source	\| Diff
· /sources/gui/qml/globals/Fonts.qml	(-0, +4)	\| History	\| Source	\| Diff
· /sources/gui/qml/main.qml	(-0, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/MainHome.qml	(-2, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/MainStack.qml	(-0, +3)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/TreatmentFlowBase.qml	(-3, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/settings/SettingsDG.qml	(-0, +4)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentBase.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/model/hd/alarm/MAlarmMapping.cpp	(-2, +2)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Feb 2022 10:10:27 -0800

Dara Navaei committed 27cc308 on branch master, @Environement_Swith and 200 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /alarmMapping.sh

(-7, +6)

| History

| Source

| Diff

· /cppcheck.sh

(-6, +6)

| History

| Source

| Diff

· /cr_objectives.sh

(-0, +15)

| History

| Source

| Diff

· /main.cpp

(-6, +6)

| History

| Source

| Diff

· /remove-exra-emptylines.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/autostart

(-6, +6)

| History

| Source

| Diff

· /scripts/bluetooth_paired_clear.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/bluetooth_paired_query.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/brightness_get.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/brightness_set.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/date_time_set.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/export_logs.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/run.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/setup.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/start.sh

(-6, +6)

| History

| Source

| Diff

… 570 more files in changeset.

UI-DEN-8914-1: closed by Behrouz NematiPour

Behrouz NematiPour — Tue, 06 Jul 2021 00:59:29 -0700

Behrouz NematiPour Closed UI-DEN-8914-1

UI-DEN-8914-1: reviewers finished

Tue, 06 Jul 2021 00:17:14 -0700

pmontazemi (deleted user) finished reviewing UI-DEN-8914-1

UI-DEN-8914_UI Dev BP HR Manual Entry

UI-DEN-8914-1: reviewers finished

Fri, 02 Jul 2021 11:13:02 -0700

plucia (deleted user) finished reviewing UI-DEN-8914-1

UI-DEN-8914_UI Dev BP HR Manual Entry

application (bugfix/DEN-16597-UI-BN-S114): DEN-DEN-8937: Meetings & Support - General Support...

Behrouz NematiPour — Mon, 28 Jun 2021 14:51:25 -0700

Behrouz NematiPour committed f0cbe4c on branch master, @Environement_Swith and 216 more in application

DEN-DEN-8937: Meetings & Support - General Support

- Disinfection each sub-state timer

· /denali.pro.user	(-2, +2)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/TimeText.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/compounds/CheckListView.qml	(-2, +13)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/TreatmentFlowBase.qml	(-1, +7)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/disinfect/DisinfectStack.qml	(-15, +6)	\| History	\| Source	\| Diff

UI-DEN-8914-1: started by Dara Navaei

Dara Navaei — Fri, 25 Jun 2021 13:00:39 -0700

Dara Navaei started review UI-DEN-8914-1

UI-DEN-8308-1: closed by Behrouz NematiPour

Behrouz NematiPour — Fri, 28 May 2021 17:42:15 -0700

Behrouz NematiPour Closed UI-DEN-8308-1

UI-DEN-8308-1: reviewers finished

Fri, 28 May 2021 17:12:37 -0700

plucia (deleted user) finished reviewing UI-DEN-8308-1

UI-DEN-8308_UI DEV Treatment Log

UI-DEN-8308-1: comment by plucia "RESOLVED"

plucia — Fri, 28 May 2021 17:12:02 -0700

plucia (deleted user) replied to plucia (deleted user) in UI-DEN-8308-1

RESOLVED

UI-DEN-8308-1: comment by plucia "From what I can tell the dg command is separate..."

plucia — Tue, 25 May 2021 12:27:20 -0700

plucia (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

From what I can tell the dg command is separated from the hd command which is good.
Please let me know when your code is ready to be merged to staging and I will handle it.
Also for the next feature you're working on please branch off of the latest staging.

UI-DEN-8308-1: comment by Behrouz NematiPour "I don't have dg_simulator. It would be a merge..."

Behrouz NematiPour — Tue, 25 May 2021 12:04:35 -0700

Behrouz NematiPour replied to plucia (deleted user) in UI-DEN-8308-1

I don't have dg_simulator.
It would be a merge task later to merge this code into the staging, I think it's out of the code review scope.