UI-DEN-13198-1 UI-DEN-13198_UI BN 75

closed on 28 Sep 22

Author

Moderator

Reviewers

UI-DEN-13198_UI BN 75

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 121

application 0
- Folder scripts 0
  - File run.sh 6 Remove
- Folder sources 0
  - Folder bluetooth 0
    - File BluetoothInterface.cpp 0 Remove
  - Folder canbus 0
    - File FrameInterface.cpp 0 Remove
    - File MessageDispatcher.cpp 0 Remove
    - File MessageDispatcher.h 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 0 Remove
  - Folder cloudsync 0
    - File CloudSyncController.cpp 0 Remove
  - Folder device 0
    - File DeviceController.cpp 0 Remove
    - File DeviceController.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File ExportButton.qml 0 Remove
        
        File GridSelection.qml 0 Remove
        
        File ModalDialog.qml 0 Remove
        
        File NotificationBar.qml 0 Remove
        
        File RangeSlider.qml 0 Remove
        
        File Slider.qml 0 Remove
        
        File SliderCreateTreatment.qml 0 Remove
        
        File TimeText.qml 0 Remove
        
        File USBButton.qml 0 Remove
        
        File WaitDone.qml 0 Remove
      - Folder dialogs 0
        
        File NotificationDialog.qml 0 Remove
      - Folder globals 0
        
        File Fonts.qml 0 Remove
        
        File Variables.qml 0 Remove
      - Folder pages 0
        
        Folder disinfect 0
        
        File DisinfectStack.qml 0 Remove
        
        Folder posttreatment 0
        
        File PostTreatmentReview.qml 0 Remove
        
        Folder pretreatment/create 0
        
        File PreTreatmentCreate.qml 0 Remove
        
        File PreTreatmentCreateStack.qml 0 Remove
        
        Folder settings 0
        
        File SettingsDG.qml 0 Remove
        
        File SettingsExportLogs.qml 0 Remove
        
        File SettingsStack.qml 0 Remove
        
        File SettingsVolumeBrightness.qml 0 Remove
        
        Folder treatment 0
        
        Folder adjustments 0
        
        File TreatmentAdjustmentBase.qml 0 Remove
        
        File TreatmentStack.qml 0 Remove
        
        File MainHome.qml 0 Remove
        
        File MainStack.qml 0 Remove
        
        File TreatmentFlowBase.qml 0 Remove
      - File AlarmItem.qml 0 Remove
      - File SDCProgressItem.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiController.cpp 0 Remove
    - File GuiController.h 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 0 Remove
    - File GuiView.cpp 0 Remove
    - File GuiView.h 0 Remove
  - Folder model 0
    - Folder dg/data/disinfect 0
      - File MDisinfectDGChemicalTimeData.cpp 0 Remove
      - File MDisinfectDGChemicalTimeData.h 0 Remove
      - File MDisinfectDGFlushTimeData.cpp 0 Remove
      - File MDisinfectDGFlushTimeData.h 0 Remove
      - File MDisinfectDGHeatTimeData.cpp 0 Remove
      - File MDisinfectDGHeatTimeData.h 0 Remove
      - File MDisinfectStatesData.cpp 0 Remove
      - File MDisinfectStatesData.h 0 Remove
    - Folder hd 0
      - Folder adjustment 0
        
        Folder disinfect 0
        
        File MDisinfectAdjustChemicalConfirmResponse.cpp 0 Remove
        
        File MDisinfectAdjustChemicalConfirmResponse.h 0 Remove
        
        File MDisinfectAdjustModeRequests.h 0 Remove
        
        File MDisinfectAdjustModeResponse.cpp 0 Remove
        
        File MDisinfectAdjustModeResponse.h 0 Remove
        
        File MDisinfectAdjustRequests.h 0 Remove
        
        File MDisinfectAdjustResponse.cpp 0 Remove
        
        File MDisinfectAdjustResponse.h 0 Remove
        
        File MDisinfectAdjustStartRequests.h 0 Remove
        
        File MDisinfectAdjustStartResponse.cpp 0 Remove
        
        File MDisinfectAdjustStartResponse.h 0 Remove
        
        Folder settings 0
        
        File MAdjustHDRequests.h 0 Remove
        
        File MAdjustRequestsBase.h 0 Remove
      - Folder alarm 0
        
        File MAlarmMapping.cpp 0 Remove
        
        File MAlarmTriggered.cpp 0 Remove
      - Folder data 0
        
        Folder post 0
        
        File MUIPostFinalResultHDRequest.cpp 0 Remove
        
        File MUIPostFinalResultHDRequest.h 0 Remove
        
        Folder treatment 0
        
        File MTreatmentBloodPrimeData.cpp 0 Remove
        
        File MTreatmentBloodPrimeData.h 0 Remove
    - Folder settings 0
      - File MSettings.cpp 0 Remove
      - File MSettings.h 0 Remove
    - File MAbstract.cpp 0 Remove
    - File MModel.h 0 Remove
  - Folder storage 0
    - File Logger.cpp 0 Remove
    - File Logger.h 0 Remove
    - File Settings.cpp 0 Remove
    - File Settings.h 0 Remove
    - File StorageGlobals.cpp 0 Remove
    - File StorageGlobals.h 0 Remove
  - Folder view 0
    - Folder dg/data/disinfect 0
      - File VDisinfectDGData.cpp 0 Remove
      - File VDisinfectDGData.h 0 Remove
      - File VDisinfectStatesData.cpp 0 Remove
      - File VDisinfectStatesData.h 0 Remove
    - Folder hd 0
      - Folder adjustment 0
        
        Folder common 0
        
        File VCommonAdjustmentVitals.cpp 0 Remove
        
        File VCommonAdjustmentVitals.h 0 Remove
        
        Folder disinfect 0
        
        File VDisinfectAdjustChemicalConfirm.cpp 0 Remove
        
        File VDisinfectAdjustChemicalConfirm.h 0 Remove
        
        File VDisinfectAdjustDisinfect.cpp 0 Remove
        
        File VDisinfectAdjustDisinfect.h 0 Remove
      - Folder alarm 0
        
        File VAlarmStatus.cpp 0 Remove
        
        File VAlarmStatus.h 0 Remove
      - Folder data 0
        
        Folder treatment 0
        
        File VTreatmentBloodPrimeData.cpp 0 Remove
        
        File VTreatmentBloodPrimeData.h 0 Remove
        
        File VHDOperationModeData.cpp 0 Remove
        
        File VHDOperationModeData.h 0 Remove
    - Folder settings 0
      - File VAdjustmentAlarmVolume.cpp 0 Remove
      - File VSettings.cpp 0 Remove
      - File VSettings.h 0 Remove
    - File VTreatmentCreate.cpp 0 Remove
    - File VTreatmentCreate.h 0 Remove
    - File VView.h 0 Remove
  - File AlarmGenerator.cpp 0 Remove
  - File AlarmGenerator.h 0 Remove
  - File ApplicationController.cpp 0 Remove
  - File ApplicationController.h 0 Remove
  - File ApplicationPost.cpp 0 Remove
  - File ApplicationPost.h 0 Remove
  - File MainTimer.cpp 0 Remove
  - File Threads.cpp 0 Remove
  - File Threads.h 0 Remove
  - File main.h 0 Remove
- Folder unittests 0
  - File tst_threads.cpp 0 Remove
- File AlarmMapping.csv 0 Remove
- File cppcheck.err 0 Remove
- File cppcheck.log 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File main.cpp 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author & Moderator	48m	2	A bug has been created for that. I need to work on it and...
Sean Nash	Reviewer - Complete	6m
Michael Garthwaite	Reviewer - 38% reviewed	32m
Tiffany Mejia	Reviewer - Complete	40m
Dara Navaei	Reviewer - 4% reviewed	7m
jishii (deleted user)	Reviewer - Complete	1h 10m	4	RESOLVED
Total		3h 26m	6

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee
DEN-14006

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/sources/.../disinfect/MDisinfectDGChemicalTimeData.cpp Deleted

Click to load diff

/sources/.../disinfect/MDisinfectDGChemicalTimeData.h Deleted

Click to load diff

/sources/.../disinfect/MDisinfectDGFlushTimeData.cpp Deleted

Click to load diff

/sources/.../disinfect/MDisinfectDGFlushTimeData.h Deleted

Click to load diff

/sources/.../disinfect/MDisinfectDGHeatTimeData.cpp Deleted

Click to load diff

/sources/.../disinfect/MDisinfectDGHeatTimeData.h Deleted

Click to load diff

/sources/.../disinfect/MDisinfectStatesData.cpp Deleted

Click to load diff

/sources/.../disinfect/MDisinfectStatesData.h Deleted

Click to load diff

/sources/.../disinfect/MDisinfectAdjustChemicalConfirmResponse.cpp Deleted

Click to load diff

/sources/.../disinfect/MDisinfectAdjustChemicalConfirmResponse.h Deleted

Click to load diff

/sources/.../disinfect/MDisinfectAdjustRequests.h Deleted

Click to load diff

/sources/.../disinfect/MDisinfectAdjustResponse.cpp Deleted

Click to load diff

/sources/.../disinfect/MDisinfectAdjustResponse.h Deleted

Click to load diff

/sources/.../disinfect/VDisinfectDGData.cpp Deleted

Click to load diff

/sources/view/.../disinfect/VDisinfectDGData.h Deleted

Click to load diff

/sources/.../disinfect/VDisinfectStatesData.cpp Deleted

Click to load diff

/sources/.../disinfect/VDisinfectStatesData.h Deleted

Click to load diff

/sources/.../disinfect/VDisinfectAdjustChemicalConfirm.cpp Deleted

Click to load diff

/sources/.../disinfect/VDisinfectAdjustChemicalConfirm.h Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-13198-1

UI-DEN-13198_UI BN 75

UI-DEN-13198-1 6

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-13198_UI BN 75

UI-DEN-13198-1 6

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time