· /cppcheck.sh	(-1, +1)	| History	| Source	| Diff
· /imake.sh	(-1, +1)	| History	| Source	| Diff
· /main.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/canbus/CanInterface.h	(-1, +1)	| History	| Source	| Diff
· /sources/canbus/FrameInterface.h	(-1, +1)	| History	| Source	| Diff
· /sources/canbus/MessageAcknowModel.h	(-1, +1)	| History	| Source	| Diff
· /sources/canbus/MessageGlobals.h	(-1, +1)	| History	| Source	| Diff
· /sources/canbus/MessageInterpreter.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/cloudsync/CloudSyncController.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/cloudsync/CloudSyncController.h	(-1, +1)	| History	| Source	| Diff
· /sources/device/DeviceController.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/gui/GuiController.cpp	(-1, +1)	| History	| Source	| Diff
· /sources/gui/GuiView.h	(-1, +1)	| History	| Source	| Diff
· /sources/gui/qml/PowerItem.qml	(-1, +1)	| History	| Source	| Diff
· /sources/gui/qml/components/DebugDataColumn.qml	(-1, +1)	| History	| Source	| Diff
… 36 more files in changeset.

]]> Fri, 10 Feb 2023 09:23:43 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-14517-1 https://devapps.diality.us/cru/UI-DEN-14517-1 Behrouz NematiPour Closed UI-DEN-14517-1 ]]> Fri, 10 Feb 2023 09:23:22 -0800 https://devapps.diality.us/cru/UI-DEN-14517-1 https://devapps.diality.us/cru/UI-DEN-14517-1 Michael Garthwaite , vduong  (deleted user) and jishii  (deleted user) finished reviewing UI-DEN-14517-1 UI-DEN-14517_UI BN S88 ]]> Fri, 10 Feb 2023 09:17:24 -0800 vduong https://devapps.diality.us/cru/UI-DEN-14517-1/#c16480 https://devapps.diality.us/cru/UI-DEN-14517-1/#c16480 vduong  (deleted user) replied to Behrouz NematiPour in UI-DEN-14517-1

Ok, sounds good.

RESOLVED

Good point,
I agree with the two intervals, it would be clarifying.
For the counter, though, it might not be always the case.
I will start doing it in my next task, since I would like to change all, to be consistent across the entire code base.

Only a suggestion:
It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity.

For instance, here, we have ms and the next one, _pendingInterval is in seconds. and I believe _pendingCounter is in minutes based on the .cpp file's comment.

_interval_ms
_pendingInterval_sec
_pendingCounter_min

RESOLVED

Thanks for the feedback.
Fixed.

The variable, destination, itself is a QString, you don't need to do QString("%1").arg(destination), you can pass destination in directly.

- Fixed CppCheck error for Qt Macros

· /cppcheck.err	(-77, +1228)	| History	| Source	| Diff
· /cppcheck.log	(-628, +884)	| History	| Source	| Diff
· /cppcheck.sh	(-0, +3)	| History	| Source	| Diff
· /sources/canbus/FrameInterface.h	(-4, +3)	| History	| Source	| Diff
· /sources/canbus/MessageAcknowModel.h	(-5, +4)	| History	| Source	| Diff

]]> Tue, 17 Jan 2023 09:01:32 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-14517-1 https://devapps.diality.us/cru/UI-DEN-14517-1 Dara Navaei started review UI-DEN-14517-1 ]]> Wed, 04 Jan 2023 16:48:39 -0800 Dara Navaei https://devapps.diality.us/changelog/application?cs=c9f8f8cf3c6c37fc6460d8675c62c9442c4d4263 https://devapps.diality.us/changelog/application?cs=c9f8f8cf3c6c37fc6460d8675c62c9442c4d4263 Dara Navaei committed c9f8f8c on branch master, @Environement_Swith and 181 more in application Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /alarmMapping.sh	(-1, +1)	| History	| Source	| Diff
· /cppcheck.sh	(-2, +2)	| History	| Source	| Diff
· /cr_objectives.sh	(-1, +1)	| History	| Source	| Diff
· /imake.sh	(-1, +1)	| History	| Source	| Diff
· /main.cpp	(-1, +1)	| History	| Source	| Diff
· /remove-exra-emptylines.sh	(-1, +1)	| History	| Source	| Diff
· /scripts/autostart	(-2, +2)	| History	| Source	| Diff
· /scripts/bluetooth_paired_clear.sh	(-1, +1)	| History	| Source	| Diff
· /scripts/bluetooth_paired_query.sh	(-1, +1)	| History	| Source	| Diff
· /scripts/brightness_get.sh	(-1, +1)	| History	| Source	| Diff
· /scripts/brightness_set.sh	(-1, +1)	| History	| Source	| Diff
· /scripts/date_time_set.sh	(-1, +1)	| History	| Source	| Diff
· /scripts/export_logs.sh	(-1, +1)	| History	| Source	| Diff
· /scripts/globals.sh	(-3, +4)	| History	| Source	| Diff
· /scripts/run.sh	(-3, +3)	| History	| Source	| Diff
… 594 more files in changeset.

]]> Thu, 08 Sep 2022 15:32:53 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-12716-2 https://devapps.diality.us/cru/UI-DEN-12716-2 Behrouz NematiPour Closed UI-DEN-12716-2 ]]> Thu, 08 Sep 2022 15:30:57 -0700 https://devapps.diality.us/cru/UI-DEN-12716-2 https://devapps.diality.us/cru/UI-DEN-12716-2 Tiffany Mejia finished reviewing UI-DEN-12716-2 UI-DEN-12716_UI BN S70 ]]> Tue, 06 Sep 2022 11:20:55 -0700 https://devapps.diality.us/cru/UI-DEN-12716-2 https://devapps.diality.us/cru/UI-DEN-12716-2 Michael Garthwaite finished reviewing UI-DEN-12716-2 UI-DEN-12716_UI BN S70 ]]> Tue, 12 Jul 2022 11:52:14 -0700 https://devapps.diality.us/cru/UI-DEN-12716-2 https://devapps.diality.us/cru/UI-DEN-12716-2 Sean Nash finished reviewing UI-DEN-12716-2 UI-DEN-12716_UI BN S70 ]]> Tue, 12 Jul 2022 11:51:46 -0700 Sean Nash https://devapps.diality.us/cru/UI-DEN-12716-2/#c13278 https://devapps.diality.us/cru/UI-DEN-12716-2/#c13278 Sean Nash replied to Behrouz NematiPour in UI-DEN-12716-2

RESOLVED.

Sure Sean, if that is the decision, will do it soon and create a case for that.
I also believe some other CL Switches need to be removed, which were only implemented for our testing at the time (CANBus).

Issue DEN-13441 - MR: Make the Dialin log permanent with no switch [CL switches review/removal] has been successfully created

If this is to log Dialin messages, we should always do that (no switch). If a Dialin command is given/responded to, we definitely want to know about that - so want to see it in the log. Dialin commands are always one-shot type messages, so will not impact log size.

RESOLVED.

RESOLVED.