1. UI-DEN-12716

UI-DEN-12716-2

Join Review Tools
closed on 08 Sep 22
Author
Moderator
Reviewers

UI-DEN-12716_UI BN S70

Activity

UI-DEN-12716-2 14

Keyboard shortcuts  
    • Summarize the review outcomes (optional)
    Preview wiki syntax help
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Behrouz NematiPour
    		Author & Moderator 1h 5m 5 Sure Sean, if that is the decision, will do it soon and c...
    Michael Garthwaite
    Reviewer completed
    		Reviewer - Complete 53m    
    Sean Nash
    Reviewer completed
    		Reviewer - Complete 43m 7 RESOLVED.
    Dara Navaei
    		Reviewer - 0% reviewed 6m    
    Tiffany Mejia
    Reviewer completed
    		Reviewer - Complete 1h 24m 2 RESOLVED
    Total   4h 13m 14  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /scripts/run.sh Changed 5
    /scripts/setup.sh Changed 3
    /scripts/start.sh Changed
    /sources/_wip_/fileCopy/main.cpp Added 3
    Open in IDE #permalink
    /sources/bluetooth/BluetoothInterface.cpp Changed
    /sources/bluetooth/BluetoothInterface.h Changed
    /sources/canbus/CanInterface.cpp Changed
    /sources/canbus/CanInterface.h Changed
    /sources/canbus/FrameInterface.cpp Changed
    /sources/canbus/FrameInterface.h Changed
    /sources/canbus/MessageAcknowModel.cpp Changed
    /sources/canbus/MessageAcknowModel.h Changed
    /sources/canbus/MessageBuilder.cpp Changed
    /sources/canbus/MessageDispatcher.cpp Changed
    /sources/canbus/MessageDispatcher.h Changed
    /sources/canbus/MessageGlobals.h Changed
    /sources/canbus/MessageInterpreter.cpp Changed
    /sources/cloudsync/CloudSyncController.cpp Changed
    /sources/cloudsync/CloudSyncController.h Changed
    /sources/device/DeviceController.cpp Changed
    /sources/device/DeviceController.h Changed
    /sources/gui/qml/components/BackButton.qml Changed
    /sources/gui/.../components/ConfirmButton.qml Changed
    /sources/.../components/DebugDataColumn.qml Changed
    /sources/gui/.../components/ExportButton.qml Changed 3
    /sources/gui/.../components/GridSelection.qml Changed
    /sources/gui/qml/components/MainMenu.qml Changed
    /sources/gui/.../components/ModalDialog.qml Changed
    /sources/gui/qml/components/StackItem.qml Changed
    /sources/gui/qml/components/USBButton.qml Changed
    /sources/gui/.../compounds/InstructionView.qml Changed
    /sources/gui/qml/compounds/TouchGrid.qml Changed
    /sources/gui/.../dialogs/DiagnosticsDialog.qml Changed
    /sources/.../dialogs/NotificationDialog.qml Changed
    /sources/gui/qml/globals/Variables.qml Changed
    /sources/.../rinseback/EndTreatmentRinsebackComplete.qml Changed
    /sources/.../posttreatment/PostTreatmentReview.qml Changed
    /sources/.../posttreatment/PostTreatmentStack.qml Changed
    /sources/.../connection/PreTreatmentConnectionStack.qml Changed
    /sources/.../create/PreTreatmentConfirm.qml Changed
    /sources/gui/.../create/PreTreatmentCreate.qml Changed
    /sources/.../create/PreTreatmentCreateStack.qml Changed
    /sources/gui/.../settings/SettingsBase.qml Changed
    /sources/gui/.../pages/settings/SettingsDG.qml Changed
    /sources/.../settings/SettingsExportLogs.qml Added
    Open in IDE #permalink
    /sources/gui/.../settings/SettingsHome.qml Changed
    /sources/gui/.../settings/SettingsStack.qml Changed
    /sources/gui/.../settings/SettingsWiFi.qml Changed
    /sources/gui/.../sections/TreatmentFluid.qml Changed
    /sources/gui/.../sections/TreatmentHeparin.qml Changed
    /sources/gui/.../treatment/TreatmentStack.qml Changed
    /sources/gui/qml/pages/MainStack.qml Changed
    /sources/gui/.../pages/TreatmentFlowBase.qml Changed
    /sources/gui/.../pages/UserConfirmation.qml Changed
    /sources/gui/qml/AlarmItem.qml Changed
    /sources/gui/qml/SDCProgressItem.qml Added
    Open in IDE #permalink
    /sources/gui/qml/SDItem.qml Deleted
    Open in IDE #permalink
    /sources/gui/qml/USBProgressItem.qml Added
    Open in IDE #permalink
    /sources/gui/qml/main.qml Changed
    /sources/gui/GuiController.cpp Changed
    /sources/gui/GuiController.h Changed
    /sources/gui/GuiGlobals.cpp Changed
    /sources/gui/GuiGlobals.h Changed
    /sources/gui/GuiView.cpp Changed
    /sources/gui/GuiView.h Changed
    /sources/.../settings/MAdjustDGRequests.h Changed
    /sources/.../settings/MAdjustDGServiceDatesResponse.cpp Added
    Open in IDE #permalink
    /sources/.../settings/MAdjustDGServiceDatesResponse.h Added
    Open in IDE #permalink
    /sources/.../settings/MAdjustDGServiceResponse.cpp Deleted
    Open in IDE #permalink
    /sources/.../settings/MAdjustDGServiceResponse.h Deleted
    Open in IDE #permalink
    /sources/.../settings/MAdjustDGVersionsResponse.h Changed
    /sources/.../post/MDGPostFinalResultData.h Changed
    /sources/.../post/MDGPostSingleResultData.h Changed
    /sources/.../data/MDGAccelerometerData.cpp Changed
    /sources/model/.../data/MDGAccelerometerData.h Changed
    /sources/model/.../data/MDGConductivityData.h Changed
    /sources/model/dg/data/MDGGeneralEvent.h Changed
    /sources/.../data/MDGTemperaturesData.cpp Changed
    /sources/model/.../data/MDGTemperaturesData.h Changed
    /sources/model/.../data/MDGValvesStatesData.h Changed
    /sources/.../disinfect/MDisinfectAdjustRequests.h Changed
    /sources/.../posttreatment/MPostTreatmentAdjustRequests.h Changed
    /sources/.../pretreatment/MPreTreatmentAdjustPatientConnectionConfirmResponse.h Changed
    /sources/.../pretreatment/MPreTreatmentAdjustRequests.h Changed
    /sources/.../settings/MAdjustHDRequests.h Changed
    /sources/.../settings/MAdjustHDServiceDatesResponse.cpp Added
    Open in IDE #permalink
    /sources/.../settings/MAdjustHDServiceDatesResponse.h Added
    Open in IDE #permalink
    /sources/.../settings/MAdjustHDServiceModeResponse.cpp Added
    Open in IDE #permalink
    /sources/.../settings/MAdjustHDServiceModeResponse.h Added
    Open in IDE #permalink
    /sources/.../settings/MAdjustHDServiceResponse.cpp Deleted
    Open in IDE #permalink
    /sources/.../settings/MAdjustHDServiceResponse.h Deleted
    Open in IDE #permalink
    /sources/.../treatment/MTreatmentAdjustRequests.h Changed
    /sources/model/hd/alarm/MAlarmActiveList.h Changed
    /sources/.../alarm/MAlarmClearedCondition.cpp Changed
    /sources/.../alarm/MAlarmClearedCondition.h Changed
    /sources/model/hd/alarm/MAlarmMapping.cpp Changed
    /sources/model/.../alarm/MAlarmTriggered.cpp Changed
    /sources/model/hd/alarm/MAlarmTriggered.h Changed
    /sources/.../post/MHDPostFinalResultData.h Changed
    /sources/.../post/MHDPostSingleResultData.h Changed
    /sources/.../treatment/MTreatmentBloodPrimeData.h Changed
    /sources/.../treatment/MTreatmentHeparinData.h Changed
    /sources/.../treatment/MTreatmentRecirculateData.h Changed
    /sources/.../treatment/MTreatmentRinsebackData.cpp Changed
    /sources/.../treatment/MTreatmentRinsebackData.h Changed
    /sources/.../treatment/MTreatmentSalineData.h Changed
    /sources/.../treatment/MTreatmentStopData.h Changed
    /sources/.../data/MHDAccelerometerData.cpp Changed
    /sources/model/.../data/MHDAccelerometerData.h Changed
    /sources/model/hd/data/MHDAirBubbleData.h Changed
    /sources/model/hd/data/MHDAirTrapData.h Changed
    /sources/model/hd/data/MHDBloodLeakData.h Changed
    /sources/model/.../data/MHDSyringePumpData.h Changed
    /sources/model/settings/MSettings.cpp Changed
    /sources/model/settings/MSettings.h Changed
    /sources/model/.../data/MUIBloodPressureData.h Changed
    /sources/model/MAbstractDynamic.cpp Changed
    /sources/model/MAbstractDynamic.h Changed
    /sources/model/MModel.h Changed
    /sources/model/uniq.sh Changed
    /sources/storage/FileHandler.cpp Changed
    /sources/storage/Logger.cpp Changed
    /sources/storage/Logger.h Changed
    /sources/storage/Settings.cpp Changed
    /sources/storage/Settings.h Changed
    /sources/storage/StorageGlobals.cpp Changed
    /sources/storage/StorageGlobals.h Changed
    /sources/storage/TreatmentLog.cpp Changed
    /sources/storage/TreatmentLog.h Changed
    /sources/utility/format.cpp Changed
    /sources/utility/format.h Changed
    /sources/utility/types.h Changed
    /sources/view/dg/data/post/VDGPOSTData.h Changed
    /sources/.../data/VDGAccelerometerData.cpp Changed
    /sources/view/.../data/VDGAccelerometerData.h Changed
    /sources/view/.../data/VDGConductivityData.h Changed
    /sources/view/.../data/VDGTemperaturesData.cpp Changed
    /sources/view/.../data/VDGTemperaturesData.h Changed
    /sources/view/.../data/VDGValvesStatesData.cpp Changed
    /sources/view/.../data/VDGValvesStatesData.h Changed
    /sources/.../common/VCommonAdjustmentVitals.cpp Changed
    /sources/.../common/VCommonAdjustmentVitals.h Changed
    /sources/.../disinfect/VDisinfectAdjustChemicalConfirm.h Changed
    /sources/.../disinfect/VDisinfectAdjustDisinfect.h Changed
    /sources/.../posttreatment/VPostTreatmentAdjustDisposablesRemovalConfirm.h Changed
    /sources/.../posttreatment/VPostTreatmentAdjustPatientDisconnectionConfirm.h Changed
    /sources/.../posttreatment/VPostTreatmentAdjustTreatmentLog.cpp Changed
    /sources/.../posttreatment/VPostTreatmentAdjustTreatmentLog.h Changed
    /sources/.../pretreatment/VPreTreatmentAdjustmentConsumablesConfirm.h Changed
    /sources/.../pretreatment/VPreTreatmentAdjustmentDisposablesConfirm.h Changed
    /sources/.../pretreatment/VPreTreatmentAdjustmentDisposablesPrime.h Changed
    /sources/.../pretreatment/VPreTreatmentAdjustmentInitTreatment.h Changed
    /sources/.../pretreatment/VPreTreatmentAdjustmentPatientConnectionBegin.h Changed
    /sources/.../pretreatment/VPreTreatmentAdjustmentPatientConnectionConfirm.h Changed
    /sources/.../pretreatment/VPreTreatmentAdjustmentStartTreatment.h Changed
    /sources/.../pretreatment/VPreTreatmentAdjustmentUltrafiltrationInit.h Changed
    /sources/.../pretreatment/VPreTreatmentAdjustmentWaterSample.h Changed
    /sources/.../treatment/VTreatmentAdjustmentDuration.h Changed
    /sources/.../treatment/VTreatmentAdjustmentEnd.h Changed
    /sources/.../treatment/VTreatmentAdjustmentFlows.h Changed
    /sources/.../treatment/VTreatmentAdjustmentHeparin.h Changed
    /sources/.../treatment/VTreatmentAdjustmentPressuresLimits.h Changed
    /sources/.../treatment/VTreatmentAdjustmentRecirculate.h Changed
    /sources/.../treatment/VTreatmentAdjustmentRinseback.h Changed
    /sources/.../treatment/VTreatmentAdjustmentSaline.h Changed
    /sources/.../treatment/VTreatmentAdjustmentUltrafiltrationConfirm.h Changed
    /sources/.../treatment/VTreatmentAdjustmentUltrafiltrationEdit.h Changed
    /sources/.../treatment/VTreatmentAdjustmentUltrafiltrationState.h Changed
    /sources/view/hd/alarm/VAlarmActiveList.h Changed
    /sources/view/hd/alarm/VAlarmStatus.cpp Changed
    /sources/view/hd/alarm/VAlarmStatus.h Changed
    /sources/view/hd/data/post/VHDPOSTData.h Changed
    /sources/.../pretreatment/VPreTreatmentStatesData.cpp Changed
    /sources/.../pretreatment/VPreTreatmentStatesData.h Changed
    /sources/.../treatment/VHDTreatmentStatesData.cpp Changed
    /sources/.../treatment/VHDTreatmentStatesData.h Changed
    /sources/.../treatment/VTreatmentPressureOcclusion.h Changed
    /sources/.../treatment/VTreatmentRinsebackData.h Changed
    /sources/.../treatment/VTreatmentUltrafiltration.h Changed
    /sources/.../data/VHDAccelerometerData.cpp Changed
    /sources/view/.../data/VHDAccelerometerData.h Changed
    /sources/view/hd/data/VHDAirBubbleData.cpp Changed
    /sources/view/hd/data/VHDAirBubbleData.h Changed
    /sources/view/hd/data/VHDAirTrapData.cpp Changed
    /sources/view/hd/data/VHDAirTrapData.h Changed
    /sources/view/hd/data/VHDBloodLeakData.h Changed
    /sources/.../data/VHDOperationModeData.cpp Changed
    /sources/view/.../data/VHDOperationModeData.h Changed
    /sources/.../settings/VAdjustmentAlarmVolume.h Changed
    /sources/.../settings/VAdjustmentService.cpp Deleted
    Open in IDE #permalink
    /sources/.../settings/VAdjustmentService.h Deleted
    Open in IDE #permalink
    /sources/.../settings/VAdjustmentServiceDates.cpp Added
    Open in IDE #permalink
    /sources/.../settings/VAdjustmentServiceDates.h Added
    Open in IDE #permalink
    /sources/.../settings/VAdjustmentServiceMode.cpp Added
    Open in IDE #permalink
    /sources/.../settings/VAdjustmentServiceMode.h Added
    Open in IDE #permalink
    /sources/.../settings/VAdjustmentVersions.h Changed
    /sources/view/settings/VDateTime.cpp Changed
    /sources/view/settings/VDateTime.h Changed
    /sources/view/VAdjustmentResponseBase.h Changed
    /sources/view/VEventSpy.cpp Changed
    /sources/view/VEventSpy.h Changed
    /sources/view/VGeneralEvent.cpp Changed
    /sources/view/VGeneralEvent.h Changed
    /sources/view/VPowerOff.h Changed
    /sources/view/VTreatmentCreate.cpp Changed
    /sources/view/VTreatmentCreate.h Changed
    /sources/view/VView.h Changed
    /sources/wifi/WifiInterface.cpp Changed
    /sources/wifi/WifiInterface.h Changed
    /sources/AlarmGenerator.cpp Changed
    /sources/ApplicationController.cpp Changed
    /sources/ApplicationController.h Changed
    /sources/ApplicationPost.cpp Changed
    /sources/MainTimer.cpp Changed
    /sources/Threads.cpp Changed
    /sources/main.h Changed
    /unittests/tst_threads.cpp Changed
    /.gitignore Changed
    /AlarmMapping.csv Changed
    /alarmMapping.sh Changed
    /cppcheck.err Changed
    /cppcheck.log Changed
    /cppcheck.sh Changed
    /cr_objectives.sh Changed
    /denali.pro Changed
    /denali.pro.user Changed
    /denali.qrc Changed
    /main.cpp Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time