Fisheye on hdfirmware/firmware/App/Controllers/AirPump.c https://devapps.diality.us/changelog/~br%3DDEN-16446-dg-dev-test-clean-up/hdfirmware/firmware/App/Controllers/AirPump.c Recent activity in "hdfirmware" under directory /firmware/App/Controllers/AirPump.c HD-DEN-16773-2: closed by Dara Navaei Tue, 19 Mar 2024 19:07:45 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-2 https://devapps.diality.us/cru/HD-DEN-16773-2 Dara Navaei Closed HD-DEN-16773-2 ]]> HD-DEN-16773-2: reviewers finished Tue, 19 Mar 2024 18:13:56 -0700 https://devapps.diality.us/cru/HD-DEN-16773-2 https://devapps.diality.us/cru/HD-DEN-16773-2 Sean Nash and Vinayakam Mani finished reviewing HD-DEN-16773-2 HD-DEN-16773_Add Chemical Disinfect Enable Institutional Record 2 ]]> HD-DEN-16773-2: reviewers added to HD-DEN-16773_Add Chemical Disinfect Enable Institu... Tue, 19 Mar 2024 17:26:54 -0700 https://devapps.diality.us/cru/HD-DEN-16773-2 https://devapps.diality.us/cru/HD-DEN-16773-2 Dara Navaei added pvedantam  (deleted user) to HD-DEN-16773-2 HD-DEN-16773_Add Chemical Disinfect Enable Institutional Record 2 ]]> HD-DEN-16773-1: closed by Dara Navaei Tue, 19 Mar 2024 16:26:22 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-1 https://devapps.diality.us/cru/HD-DEN-16773-1 Dara Navaei Closed HD-DEN-16773-1 ]]> HD-DEN-16773-1: reviewers finished Tue, 19 Mar 2024 16:23:26 -0700 https://devapps.diality.us/cru/HD-DEN-16773-1 https://devapps.diality.us/cru/HD-DEN-16773-1 pvedantam  (deleted user) , Sean Nash and Vinayakam Mani finished reviewing HD-DEN-16773-1 HD-DEN-16773_Add Chemical Disinfect Enable TO The Institutional Record ]]> HD-DEN-16773-2: started by Dara Navaei Tue, 19 Mar 2024 16:11:23 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-2 https://devapps.diality.us/cru/HD-DEN-16773-2 Dara Navaei started review HD-DEN-16773-2 ]]> HD-DEN-16773-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 19 Mar 2024 10:03:56 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16773-1/#c19645 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19645 Sean Nash replied to Dara Navaei in HD-DEN-16773-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16773-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 19 Mar 2024 10:03:34 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16773-1/#c19644 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19644 Sean Nash replied to Dara Navaei in HD-DEN-16773-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16773-1: comment by Dara Navaei "Done" Tue, 19 Mar 2024 09:29:59 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-1/#c19643 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19643 Dara Navaei replied to Sean Nash in HD-DEN-16773-1

Done

]]> HD-DEN-16773-1: comment by Dara Navaei "Done" Tue, 19 Mar 2024 09:29:52 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-1/#c19642 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19642 Dara Navaei replied to Sean Nash in HD-DEN-16773-1

Done

]]> HD-DEN-16773-1: comment by Sean Nash "It's 1 line of code either way. Just on top or..." Tue, 19 Mar 2024 08:55:11 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16773-1/#c19641 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19641 Sean Nash replied to Dara Navaei in HD-DEN-16773-1

It's 1 line of code either way. Just on top or below in an else. Vectorcast will see as a branch you need to test either way.
If you put it in an else, the processor does less work and I think it's a lot easier to read.

]]> HD-DEN-16773-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 19 Mar 2024 08:54:00 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16773-1/#c19640 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19640 Sean Nash replied to Dara Navaei in HD-DEN-16773-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16773-1: comment by Dara Navaei "I thought about having an else below but this w..." Tue, 19 Mar 2024 08:28:07 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-1/#c19639 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19639 Dara Navaei replied to Sean Nash in HD-DEN-16773-1

I thought about having an else below but this way we write less code. I have done similar in the past.

]]> HD-DEN-16773-1: comment by Dara Navaei "Done" Tue, 19 Mar 2024 08:23:02 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-1/#c19638 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19638 Dara Navaei replied to Sean Nash in HD-DEN-16773-1

Done

]]> HD-DEN-16773-1: comment by Sean Nash "Put this in an else below." Mon, 18 Mar 2024 21:39:09 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16773-1/#c19637 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19637 Sean Nash commented on HD-DEN-16773-1

Put this in an else below.

]]> HD-DEN-16773-1: comment by Sean Nash "This should probably be in an else below." Mon, 18 Mar 2024 21:38:00 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16773-1/#c19636 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19636 Sean Nash commented on HD-DEN-16773-1

This should probably be in an else below.

]]> HD-DEN-16773-1: comment by Sean Nash "disinfect is misspelled." Mon, 18 Mar 2024 21:35:10 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16773-1/#c19635 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19635 Sean Nash commented on HD-DEN-16773-1

disinfect is misspelled.

]]> HD-DEN-16773-1: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH" Mon, 18 Mar 2024 15:40:18 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16773-1/#c19633 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19633 Vinayakam Mani replied to Dara Navaei in HD-DEN-16773-1

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-16773-1: comment by Dara Navaei "Done" Mon, 18 Mar 2024 15:26:43 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-1/#c19632 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19632 Dara Navaei replied to Vinayakam Mani in HD-DEN-16773-1

Done

]]> HD-DEN-16773-1: comment by Vinayakam Mani "Can we remove the AIR_PUMP_OPERATION_TIMEOUT Ma..." Mon, 18 Mar 2024 15:12:20 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16773-1/#c19631 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19631 Vinayakam Mani commented on HD-DEN-16773-1

Can we remove the AIR_PUMP_OPERATION_TIMEOUT Macro?

]]> HD-DEN-16773-1: reviewers added to HD-DEN-16773_Add Chemical Disinfect Enable TO The ... Mon, 18 Mar 2024 14:40:22 -0700 https://devapps.diality.us/cru/HD-DEN-16773-1 https://devapps.diality.us/cru/HD-DEN-16773-1 Dara Navaei added pvedantam  (deleted user) to HD-DEN-16773-1 HD-DEN-16773_Add Chemical Disinfect Enable TO The Institutional Record ]]> HD-DEN-16773-1: started by Dara Navaei Mon, 18 Mar 2024 14:22:23 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-1 https://devapps.diality.us/cru/HD-DEN-16773-1 Dara Navaei started review HD-DEN-16773-1 ]]> HD-DEN-14344-3: closed by Dara Navaei Wed, 18 Oct 2023 20:49:50 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14344-3 https://devapps.diality.us/cru/HD-DEN-14344-3 Dara Navaei Closed HD-DEN-14344-3 ]]> HD-DEN-14344-3: comment by Dara Navaei "RESOLVED IN CODE WALKTHROUGH" Wed, 18 Oct 2023 20:49:40 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14344-3/#c19056 https://devapps.diality.us/cru/HD-DEN-14344-3/#c19056 Dara Navaei replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-14344-3: reviewers resumed Wed, 18 Oct 2023 20:48:20 -0700 https://devapps.diality.us/cru/HD-DEN-14344-3 https://devapps.diality.us/cru/HD-DEN-14344-3 Dara Navaei resumed reviewing HD-DEN-14344-3 HD-DEN-14344_SW S85 MG Air Pump ]]> HD-DEN-14344-3: started by Dara Navaei Wed, 18 Oct 2023 20:47:55 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14344-3 https://devapps.diality.us/cru/HD-DEN-14344-3 Dara Navaei started review HD-DEN-14344-3 ]]> HD-DEN-15886-1: closed by Sean Nash Wed, 02 Aug 2023 11:44:22 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15886-1 https://devapps.diality.us/cru/HD-DEN-15886-1 Sean Nash Closed HD-DEN-15886-1 ]]> HD-DEN-15886-1: reviewers finished Wed, 02 Aug 2023 11:34:17 -0700 https://devapps.diality.us/cru/HD-DEN-15886-1 https://devapps.diality.us/cru/HD-DEN-15886-1 wbracken  (deleted user) and Dara Navaei finished reviewing HD-DEN-15886-1 HD-DEN-15886_Air Pump Pushes Air Into The Heparin Syringe During Dry Self Tests ]]> HD-DEN-15886-1: reviewers resumed Tue, 01 Aug 2023 16:39:12 -0700 https://devapps.diality.us/cru/HD-DEN-15886-1 https://devapps.diality.us/cru/HD-DEN-15886-1 jtaylor  (deleted user) resumed reviewing HD-DEN-15886-1 HD-DEN-15886_Air Pump Pushes Air Into The Heparin Syringe During Dry Self Tests ]]> HD-DEN-15886-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Tue, 01 Aug 2023 11:34:10 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15886-1/#c18341 https://devapps.diality.us/cru/HD-DEN-15886-1/#c18341 wbracken  (deleted user) replied to Sean Nash in HD-DEN-15886-1

RESOLVED IN CODE WALKTHROUGH

]]>