Fisheye on hdfirmware/firmware/App/Controllers/AirTrap.h https://devapps.diality.us/changelog/~br%3DDEN-16446-dg-dev-test-clean-up/hdfirmware/firmware/App/Controllers/AirTrap.h Recent activity in "hdfirmware" under directory /firmware/App/Controllers/AirTrap.h HD-DEN-16672-1: closed by Vinayakam Mani Tue, 05 Mar 2024 14:04:49 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16672-1 https://devapps.diality.us/cru/HD-DEN-16672-1 Vinayakam Mani Closed HD-DEN-16672-1 ]]> HD-DEN-16672-1: reviewers finished Tue, 05 Mar 2024 09:57:41 -0800 https://devapps.diality.us/cru/HD-DEN-16672-1 https://devapps.diality.us/cru/HD-DEN-16672-1 Michael Garthwaite finished reviewing HD-DEN-16672-1 HD-DEN-16672_Air Trap Level Control Changes ]]> HD-DEN-16672-1: reviewers added to HD-DEN-16672_Air Trap Level Control Changes Tue, 05 Mar 2024 09:49:37 -0800 https://devapps.diality.us/cru/HD-DEN-16672-1 https://devapps.diality.us/cru/HD-DEN-16672-1 Vinayakam Mani added pvedantam  (deleted user) to HD-DEN-16672-1 HD-DEN-16672_Air Trap Level Control Changes ]]> HD-DENBUG-163-2: closed by Vinayakam Mani Sun, 03 Mar 2024 16:24:13 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DENBUG-163-2 https://devapps.diality.us/cru/HD-DENBUG-163-2 Vinayakam Mani Closed HD-DENBUG-163-2 ]]> HD-DEN-16672-1: reviewers finished Wed, 28 Feb 2024 14:02:47 -0800 https://devapps.diality.us/cru/HD-DEN-16672-1 https://devapps.diality.us/cru/HD-DEN-16672-1 Sean Nash finished reviewing HD-DEN-16672-1 HD-DEN-16672_Air Trap Level Control Changes ]]> HD-DEN-16672-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 28 Feb 2024 14:02:39 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16672-1/#c19521 https://devapps.diality.us/cru/HD-DEN-16672-1/#c19521 Sean Nash replied to Vinayakam Mani in HD-DEN-16672-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16672-1: comment by Vinayakam Mani "Since the utility is finding the difference of ..." Tue, 27 Feb 2024 16:04:36 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16672-1/#c19517 https://devapps.diality.us/cru/HD-DEN-16672-1/#c19517 Vinayakam Mani replied to Sean Nash in HD-DEN-16672-1

Since the utility is finding the difference of two numbers, I see the logic is common. for instance, On a positive case, u32DiffWithWrap(9000, 26000) where 9000 is the adjustment number and 26000 is the current timer value, the result is 26000-9000 = 17000. on a negative case, u32DiffWithWrap(9000,4000) where current timer value is 4000, the result would be 0xFFFF FFFF - 9000 + 4000 + 1. i.e: FFFF FFFF - 5000 + 1. Do you still see any concern?

]]> HD-DEN-16672-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 27 Feb 2024 15:25:00 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16672-1/#c19514 https://devapps.diality.us/cru/HD-DEN-16672-1/#c19514 Sean Nash replied to Sean Nash in HD-DEN-16672-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16672-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 27 Feb 2024 15:24:30 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16672-1/#c19513 https://devapps.diality.us/cru/HD-DEN-16672-1/#c19513 Sean Nash replied to Sean Nash in HD-DEN-16672-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16672-1: comment by Sean Nash "This looks backwards and nonsensical to me. Do..." Tue, 27 Feb 2024 15:17:40 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16672-1/#c19512 https://devapps.diality.us/cru/HD-DEN-16672-1/#c19512 Sean Nash commented on HD-DEN-16672-1

This looks backwards and nonsensical to me. Does this work?

]]> HD-DEN-16672-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 27 Feb 2024 15:09:24 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16672-1/#c19511 https://devapps.diality.us/cru/HD-DEN-16672-1/#c19511 Sean Nash replied to Vinayakam Mani in HD-DEN-16672-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DENBUG-163-2: reviewers finished Tue, 27 Feb 2024 11:24:12 -0800 https://devapps.diality.us/cru/HD-DENBUG-163-2 https://devapps.diality.us/cru/HD-DENBUG-163-2 Sean Nash and Michael Garthwaite finished reviewing HD-DENBUG-163-2 HD-DENBUG-163_2 High Venous Pressure Alarm 130 Triggers During Normal Treatment Operation ]]> HD-DEN-16672-1: comment by Vinayakam Mani "Done." Mon, 26 Feb 2024 10:08:15 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16672-1/#c19510 https://devapps.diality.us/cru/HD-DEN-16672-1/#c19510 Vinayakam Mani replied to Sean Nash in HD-DEN-16672-1

Done.

]]> HD-DEN-16672-1: comment by Sean Nash "Why is air pump on state checked here? Seems r..." Fri, 23 Feb 2024 09:02:18 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16672-1/#c19509 https://devapps.diality.us/cru/HD-DEN-16672-1/#c19509 Sean Nash commented on HD-DEN-16672-1

Why is air pump on state checked here? Seems redundant as it is checked again below.

]]> HD-DEN-16672-1: comment by Sean Nash "The lower level sensor doesn't need to be raw h..." Thu, 22 Feb 2024 14:09:27 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16672-1/#c19507 https://devapps.diality.us/cru/HD-DEN-16672-1/#c19507 Sean Nash commented on HD-DEN-16672-1

The lower level sensor doesn't need to be raw here.

]]> HD-DENBUG-163-1: closed by Vinayakam Mani Wed, 21 Feb 2024 15:29:38 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DENBUG-163-1 https://devapps.diality.us/cru/HD-DENBUG-163-1 Vinayakam Mani Closed HD-DENBUG-163-1 ]]> HD-DENBUG-163-1: reviewers finished Wed, 21 Feb 2024 14:47:35 -0800 https://devapps.diality.us/cru/HD-DENBUG-163-1 https://devapps.diality.us/cru/HD-DENBUG-163-1 Dara Navaei and Sean Nash finished reviewing HD-DENBUG-163-1 HD-DENBUG-163_High Venous Pressure Alarm 130 Triggers During Normal Treatment Operation ]]> HD-DENBUG-163-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 Feb 2024 14:33:48 -0800 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19500 https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19500 Sean Nash replied to Vinayakam Mani in HD-DENBUG-163-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DENBUG-163-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 Feb 2024 14:33:21 -0800 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19499 https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19499 Sean Nash replied to Vinayakam Mani in HD-DENBUG-163-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DENBUG-163-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 Feb 2024 14:32:37 -0800 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19498 https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19498 Sean Nash replied to Vinayakam Mani in HD-DENBUG-163-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DENBUG-163-1: comment by Vinayakam Mani "Done." Wed, 21 Feb 2024 14:31:45 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19497 https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19497 Vinayakam Mani replied to Sean Nash in HD-DENBUG-163-1

Done.

]]> HD-DENBUG-163-1: comment by Vinayakam Mani "Done." Wed, 21 Feb 2024 14:31:38 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19496 https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19496 Vinayakam Mani replied to Sean Nash in HD-DENBUG-163-1

Done.

]]> HD-DENBUG-163-1: comment by Vinayakam Mani "Done." Wed, 21 Feb 2024 14:31:23 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19495 https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19495 Vinayakam Mani replied to Sean Nash in HD-DENBUG-163-1

Done.

]]> HD-DENBUG-163-1: comment by Sean Nash "Capitalize first letter of comment." Wed, 21 Feb 2024 13:11:30 -0800 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19494 https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19494 Sean Nash commented on HD-DENBUG-163-1

Capitalize first letter of comment.

]]> HD-DENBUG-163-1: comment by Sean Nash "use new get function for raw levels in this ass..." Wed, 21 Feb 2024 13:09:27 -0800 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19493 https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19493 Sean Nash commented on HD-DENBUG-163-1

use new get function for raw levels in this assignment so that raw override is considered.

]]> HD-DENBUG-163-1: comment by Sean Nash "use new get function for raw levels in this con..." Wed, 21 Feb 2024 13:09:12 -0800 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19492 https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19492 Sean Nash commented on HD-DENBUG-163-1

use new get function for raw levels in this condition so that raw override is considered.

]]> HD-DEN-16672-1: comment by Sean Nash "Is this definition still needed?" Tue, 20 Feb 2024 12:23:07 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16672-1/#c19487 https://devapps.diality.us/cru/HD-DEN-16672-1/#c19487 Sean Nash commented on HD-DEN-16672-1

Is this definition still needed?

]]> HD-DEN-16672-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 20 Feb 2024 12:22:10 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16672-1/#c19486 https://devapps.diality.us/cru/HD-DEN-16672-1/#c19486 Sean Nash replied to Vinayakam Mani in HD-DEN-16672-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16672-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 20 Feb 2024 12:21:36 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16672-1/#c19485 https://devapps.diality.us/cru/HD-DEN-16672-1/#c19485 Sean Nash replied to Vinayakam Mani in HD-DEN-16672-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16672-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 20 Feb 2024 12:21:30 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16672-1/#c19484 https://devapps.diality.us/cru/HD-DEN-16672-1/#c19484 Sean Nash replied to Vinayakam Mani in HD-DEN-16672-1

RESOLVED in CODE WALKTHROUGH.

]]>