Fisheye on hdfirmware/firmware/App/Modes/BloodPrime.h https://devapps.diality.us/changelog/~br%3DDEN-16446-dg-dev-test-clean-up/hdfirmware/firmware/App/Modes/BloodPrime.h Recent activity in "hdfirmware" under directory /firmware/App/Modes/BloodPrime.h HD-DEN-16499-2: closed by Dara Navaei Tue, 06 Feb 2024 13:21:41 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16499-2 https://devapps.diality.us/cru/HD-DEN-16499-2 Dara Navaei Closed HD-DEN-16499-2 ]]> HD-DEN-16499-2: reviewers finished Tue, 06 Feb 2024 13:05:34 -0800 https://devapps.diality.us/cru/HD-DEN-16499-2 https://devapps.diality.us/cru/HD-DEN-16499-2 Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16499-2 HD-DEN-16499_FW Message List Testing Issues 2 ]]> HD-DEN-16499-2: started by Dara Navaei Tue, 06 Feb 2024 10:16:23 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16499-2 https://devapps.diality.us/cru/HD-DEN-16499-2 Dara Navaei started review HD-DEN-16499-2 ]]> HD-DEN-16499-1: closed by Dara Navaei Fri, 02 Feb 2024 14:07:43 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16499-1 https://devapps.diality.us/cru/HD-DEN-16499-1 Dara Navaei Closed HD-DEN-16499-1 ]]> HD-DEN-16499-1: reviewers finished Fri, 02 Feb 2024 14:07:13 -0800 https://devapps.diality.us/cru/HD-DEN-16499-1 https://devapps.diality.us/cru/HD-DEN-16499-1 Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16499-1 HD-DEN-16499_FW Message List Testing Issues ]]> HD-DEN-16499-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 02 Feb 2024 09:31:10 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16499-1/#c19389 https://devapps.diality.us/cru/HD-DEN-16499-1/#c19389 Sean Nash replied to Dara Navaei in HD-DEN-16499-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16499-1: comment by Dara Navaei "Fixed the code." Fri, 02 Feb 2024 08:45:21 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16499-1/#c19372 https://devapps.diality.us/cru/HD-DEN-16499-1/#c19372 Dara Navaei replied to Sean Nash in HD-DEN-16499-1

Fixed the code.

]]> HD-DEN-16499-1: comment by Sean Nash "This looks wrong." Thu, 25 Jan 2024 08:56:55 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16499-1/#c19355 https://devapps.diality.us/cru/HD-DEN-16499-1/#c19355 Sean Nash commented on HD-DEN-16499-1

This looks wrong.

]]> HD-DEN-16499-1: started by Dara Navaei Tue, 23 Jan 2024 15:13:40 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16499-1 https://devapps.diality.us/cru/HD-DEN-16499-1 Dara Navaei started review HD-DEN-16499-1 ]]> HD-DEN-9906-1: closed by Dara Navaei Thu, 19 Oct 2023 08:03:24 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1 https://devapps.diality.us/cru/HD-DEN-9906-1 Dara Navaei Closed HD-DEN-9906-1 ]]> HD-DEN-9906-1: reviewers finished Thu, 19 Oct 2023 08:02:54 -0700 https://devapps.diality.us/cru/HD-DEN-9906-1 https://devapps.diality.us/cru/HD-DEN-9906-1 Dara Navaei finished reviewing HD-DEN-9906-1 HD-DEN-9906_HD Dev Flow Measurement Changes ]]> HD-DEN-9906-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:02:45 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1/#c19091 https://devapps.diality.us/cru/HD-DEN-9906-1/#c19091 Dara Navaei replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-9906-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:02:38 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1/#c19090 https://devapps.diality.us/cru/HD-DEN-9906-1/#c19090 Dara Navaei replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-9906-1: started by Dara Navaei Thu, 19 Oct 2023 08:01:36 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1 https://devapps.diality.us/cru/HD-DEN-9906-1 Dara Navaei started review HD-DEN-9906-1 ]]> HD-DEN-15105-1: closed by Sean Nash Mon, 17 Apr 2023 10:26:54 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15105-1 https://devapps.diality.us/cru/HD-DEN-15105-1 Sean Nash Closed HD-DEN-15105-1 ]]> HD-DEN-15105-1: reviewers finished Mon, 17 Apr 2023 10:25:59 -0700 https://devapps.diality.us/cru/HD-DEN-15105-1 https://devapps.diality.us/cru/HD-DEN-15105-1 jtaylor  (deleted user) and wbracken  (deleted user) finished reviewing HD-DEN-15105-1 HD-DEN-15105_Dialyzer Flip ]]> HD-DEN-15105-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Fri, 14 Apr 2023 09:23:23 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15105-1/#c17124 https://devapps.diality.us/cru/HD-DEN-15105-1/#c17124 wbracken  (deleted user) replied to Sean Nash in HD-DEN-15105-1

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-15105-1: comment by Sean Nash "For init functions, I typically do not itemize ..." Fri, 14 Apr 2023 09:21:05 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15105-1/#c17123 https://devapps.diality.us/cru/HD-DEN-15105-1/#c17123 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15105-1

For init functions, I typically do not itemize variables (list too long) and just say initialize module.

]]> HD-DEN-15105-1: comment by wbracken "Variables in lines 153 to 165 should be in head..." Fri, 14 Apr 2023 09:07:16 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15105-1/#c17119 https://devapps.diality.us/cru/HD-DEN-15105-1/#c17119 wbracken  (deleted user) replied to Sean Nash in HD-DEN-15105-1

Variables in lines 153 to 165 should be in header... unless pre-treatment mode module initialized covers them.

]]> HD-DEN-15105-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Fri, 14 Apr 2023 09:13:06 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15105-1/#c17122 https://devapps.diality.us/cru/HD-DEN-15105-1/#c17122 wbracken  (deleted user) replied to Sean Nash in HD-DEN-15105-1

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-15105-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Fri, 14 Apr 2023 09:12:27 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15105-1/#c17120 https://devapps.diality.us/cru/HD-DEN-15105-1/#c17120 wbracken  (deleted user) replied to Sean Nash in HD-DEN-15105-1

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-15105-1: comment by Sean Nash "What update is required?" Fri, 14 Apr 2023 08:29:27 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15105-1/#c17117 https://devapps.diality.us/cru/HD-DEN-15105-1/#c17117 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15105-1

What update is required?

]]> HD-DEN-15105-1: comment by Sean Nash "Fixed." Fri, 14 Apr 2023 08:28:37 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15105-1/#c17116 https://devapps.diality.us/cru/HD-DEN-15105-1/#c17116 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15105-1

Fixed.

]]> HD-DEN-15105-1: comment by Sean Nash "Fixed." Fri, 14 Apr 2023 08:27:22 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15105-1/#c17115 https://devapps.diality.us/cru/HD-DEN-15105-1/#c17115 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15105-1

Fixed.

]]> HD-DEN-15105-1: comment by wbracken "Update header, setUFVolStatus" Thu, 13 Apr 2023 14:05:24 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15105-1/#c17111 https://devapps.diality.us/cru/HD-DEN-15105-1/#c17111 wbracken  (deleted user) commented on HD-DEN-15105-1

Update header, setUFVolStatus

]]> HD-DEN-15105-1: comment by wbracken "Update header" Thu, 13 Apr 2023 14:04:04 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15105-1/#c17110 https://devapps.diality.us/cru/HD-DEN-15105-1/#c17110 wbracken  (deleted user) commented on HD-DEN-15105-1

Update header

]]> HD-DEN-15105-1: comment by wbracken "Update header." Thu, 13 Apr 2023 14:03:05 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15105-1/#c17109 https://devapps.diality.us/cru/HD-DEN-15105-1/#c17109 wbracken  (deleted user) commented on HD-DEN-15105-1

Update header.

]]> HD-DEN-15105-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Thu, 13 Apr 2023 13:58:54 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15105-1/#c17108 https://devapps.diality.us/cru/HD-DEN-15105-1/#c17108 wbracken  (deleted user) replied to Sean Nash in HD-DEN-15105-1

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-15105-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Thu, 13 Apr 2023 13:58:18 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15105-1/#c17105 https://devapps.diality.us/cru/HD-DEN-15105-1/#c17105 wbracken  (deleted user) replied to Sean Nash in HD-DEN-15105-1

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-15105-1: comment by Sean Nash "Fixed." Thu, 13 Apr 2023 13:52:20 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15105-1/#c17099 https://devapps.diality.us/cru/HD-DEN-15105-1/#c17099 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15105-1

Fixed.

]]>