Fisheye on hdfirmware/firmware/App/Modes/ModeService.c https://devapps.diality.us/changelog/~br%3DDEN-16446-dg-dev-test-clean-up/hdfirmware/firmware/App/Modes/ModeService.c Recent activity in "hdfirmware" under directory /firmware/App/Modes/ModeService.c HD-DEN-16446-2: closed by Dara Navaei Fri, 20 Oct 2023 09:23:54 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 Dara Navaei Closed HD-DEN-16446-2 ]]> HD-DEN-16446-2: reviewers finished Fri, 20 Oct 2023 08:15:29 -0700 https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 Sean Nash finished reviewing HD-DEN-16446-2 HD-DEN-16446_HD Dev Test Clean UP Vectorcast ]]> HD-DEN-16446-2: reviewers finished Thu, 19 Oct 2023 16:37:30 -0700 https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 wbracken  (deleted user) finished reviewing HD-DEN-16446-2 HD-DEN-16446_HD Dev Test Clean UP Vectorcast ]]> HD-DEN-16446-2: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Thu, 19 Oct 2023 16:36:33 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-16446-2/#c19222 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19222 wbracken  (deleted user) replied to Dara Navaei in HD-DEN-16446-2

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-16446-2: comment by Dara Navaei "The result will be an unsigned integer" Thu, 19 Oct 2023 14:23:26 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16446-2/#c19206 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19206 Dara Navaei replied to wbracken  (deleted user) in HD-DEN-16446-2

The result will be an unsigned integer

]]> HD-DEN-16446-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 19 Oct 2023 14:11:04 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16446-2/#c19205 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19205 Sean Nash replied to Vinayakam Mani in HD-DEN-16446-2

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16446-2: comment by Vinayakam Mani "In the If conditions, we check "uFVolume > colU..." Thu, 19 Oct 2023 13:33:29 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16446-2/#c19204 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19204 Vinayakam Mani replied to Sean Nash in HD-DEN-16446-2

In the If conditions, we check "uFVolume > colUFVol" conditions, that makes uFRate always positive and hence the condition for minimum check is not required.

]]> HD-DEN-13460-2: closed by Dara Navaei Thu, 19 Oct 2023 09:43:10 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-13460-2 https://devapps.diality.us/cru/HD-DEN-13460-2 Dara Navaei Closed HD-DEN-13460-2 ]]> HD-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:42:55 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-13460-2/#c19142 https://devapps.diality.us/cru/HD-DEN-13460-2/#c19142 Dara Navaei replied to Dara Navaei in HD-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:42:47 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-13460-2/#c19141 https://devapps.diality.us/cru/HD-DEN-13460-2/#c19141 Dara Navaei replied to wbracken  (deleted user) in HD-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-13460-2: started by Dara Navaei Thu, 19 Oct 2023 09:41:49 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-13460-2 https://devapps.diality.us/cru/HD-DEN-13460-2 Dara Navaei started review HD-DEN-13460-2 ]]> HD-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:22:19 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-13460-2/#c19127 https://devapps.diality.us/cru/HD-DEN-13460-2/#c19127 Dara Navaei replied to Dara Navaei in HD-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:20:09 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-13460-2/#c19126 https://devapps.diality.us/cru/HD-DEN-13460-2/#c19126 Dara Navaei replied to Dara Navaei in HD-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-3115-1: closed by Dara Navaei Thu, 19 Oct 2023 08:40:42 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-3115-1 https://devapps.diality.us/cru/HD-DEN-3115-1 Dara Navaei Closed HD-DEN-3115-1 ]]> HD-DEN-3115-1: reviewers finished Thu, 19 Oct 2023 08:40:34 -0700 https://devapps.diality.us/cru/HD-DEN-3115-1 https://devapps.diality.us/cru/HD-DEN-3115-1 Dara Navaei finished reviewing HD-DEN-3115-1 HD-DEN-3115_HD Blood Flow 3 of 3 ]]> HD-DEN-3115-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:40:25 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-3115-1/#c19111 https://devapps.diality.us/cru/HD-DEN-3115-1/#c19111 Dara Navaei replied to qnguyen  (deleted user) in HD-DEN-3115-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-3115-1: started by Dara Navaei Thu, 19 Oct 2023 08:39:15 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-3115-1 https://devapps.diality.us/cru/HD-DEN-3115-1 Dara Navaei started review HD-DEN-3115-1 ]]> HD-DEN-5674-2: closed by Dara Navaei Thu, 19 Oct 2023 08:18:11 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-5674-2 https://devapps.diality.us/cru/HD-DEN-5674-2 Dara Navaei Closed HD-DEN-5674-2 ]]> HD-DEN-5674-2: reviewers finished Thu, 19 Oct 2023 08:18:03 -0700 https://devapps.diality.us/cru/HD-DEN-5674-2 https://devapps.diality.us/cru/HD-DEN-5674-2 Dara Navaei finished reviewing HD-DEN-5674-2 HD-DEN-5674_Alarm Design (3 of 4) ]]> HD-DEN-5674-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:17:53 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-5674-2/#c19103 https://devapps.diality.us/cru/HD-DEN-5674-2/#c19103 Dara Navaei replied to Sean Nash in HD-DEN-5674-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-5674-2: started by Dara Navaei Thu, 19 Oct 2023 08:16:11 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-5674-2 https://devapps.diality.us/cru/HD-DEN-5674-2 Dara Navaei started review HD-DEN-5674-2 ]]> HD-DEN-9906-1: closed by Dara Navaei Thu, 19 Oct 2023 08:03:24 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1 https://devapps.diality.us/cru/HD-DEN-9906-1 Dara Navaei Closed HD-DEN-9906-1 ]]> HD-DEN-9906-1: reviewers finished Thu, 19 Oct 2023 08:02:54 -0700 https://devapps.diality.us/cru/HD-DEN-9906-1 https://devapps.diality.us/cru/HD-DEN-9906-1 Dara Navaei finished reviewing HD-DEN-9906-1 HD-DEN-9906_HD Dev Flow Measurement Changes ]]> HD-DEN-9906-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:02:45 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1/#c19091 https://devapps.diality.us/cru/HD-DEN-9906-1/#c19091 Dara Navaei replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-9906-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:02:38 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1/#c19090 https://devapps.diality.us/cru/HD-DEN-9906-1/#c19090 Dara Navaei replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-9906-1: started by Dara Navaei Thu, 19 Oct 2023 08:01:36 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-9906-1 https://devapps.diality.us/cru/HD-DEN-9906-1 Dara Navaei started review HD-DEN-9906-1 ]]> HD-DEN-16446-2: reviewers resumed Tue, 17 Oct 2023 15:00:28 -0700 https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 jtaylor  (deleted user) resumed reviewing HD-DEN-16446-2 HD-DEN-16446_HD Dev Test Clean UP Vectorcast ]]> HD-DEN-16446-2: comment by Sean Nash "I think we need the minimum check too. uFRate ..." Mon, 16 Oct 2023 11:04:28 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16446-2/#c19033 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19033 Sean Nash commented on HD-DEN-16446-2

I think we need the minimum check too. uFRate can be negative if user sets volume to something lower than what has already been collected (negative volume) which would yield a negative rate which is < 0.0.

]]> HD-DEN-16446-2: comment by wbracken "Check casting. Result is U32 but could be assi..." Fri, 13 Oct 2023 10:41:25 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-16446-2/#c19029 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19029 wbracken  (deleted user) commented on HD-DEN-16446-2

Check casting. Result is U32 but could be assigned an S32.

]]> HD-DEN-16446-2: started by Dara Navaei Fri, 06 Oct 2023 10:06:10 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 Dara Navaei started review HD-DEN-16446-2 ]]>