Fisheye on hdfirmware/firmware/App/Modes/SampleWater.h

HD-UCOMMITS-19: closed by Sean Nash

Sean Nash — Thu, 03 Aug 2023 08:57:40 -0700

Sean Nash Closed HD-UCOMMITS-19

HD-UCOMMITS-19: reviewers finished

Wed, 02 Aug 2023 21:26:40 -0700

Dara Navaei and Sean Nash finished reviewing HD-UCOMMITS-19

HD Staging Unreviewed Commits

HD-UCOMMITS-19: started by Dara Navaei

Dara Navaei — Mon, 08 May 2023 09:22:08 -0700

Dara Navaei started review HD-UCOMMITS-19

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 02 Jan 2023 15:47:15 -0800

Dara Navaei committed 0a4dcd2 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 295 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DialInFlow.c

(-3, +3)

| History

| Source

| Diff

… 98 more files in changeset.

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 15 Feb 2022 16:27:09 -0800

Dara Navaei committed 3d72b77 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 337 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DialOutFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DialOutFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/PresOccl.c

(-3, +3)

| History

| Source

| Diff

… 45 more files in changeset.

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 04 Jan 2022 10:36:22 -0800

Dara Navaei committed 24b2fe7 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11098-implement-hd-pre-treatment-mode-update and 340 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DialInFlow.c

(-1, +1)

| History

| Source

| Diff

… 98 more files in changeset.

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Sun, 12 Sep 2021 15:39:38 -0700

Dara Navaei committed ccfd155 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 345 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirTrap.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/DialInFlow.c

(-6, +6)

| History

| Source

| Diff

… 97 more files in changeset.

HD-DEN-8103-1: closed by qnguyen

qnguyen — Fri, 25 Jun 2021 10:42:21 -0700

qnguyen (deleted user) Closed HD-DEN-8103-1

HD-DEN-8103-1: reviewers finished

Fri, 25 Jun 2021 10:42:10 -0700

Dara Navaei , Sean Nash and pmontazemi (deleted user) finished reviewing HD-DEN-8103-1

HD-DEN-8103_DG HD Dev Alarm Design

HD-DEN-8103-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH."

pmontazemi — Fri, 25 Jun 2021 10:35:16 -0700

pmontazemi (deleted user) replied to qnguyen (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 25 Jun 2021 10:34:27 -0700

Sean Nash replied to qnguyen (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1: comment by qnguyen "Duplicate declaration from line 330."

qnguyen — Wed, 23 Jun 2021 10:07:06 -0700

qnguyen (deleted user) replied to Sean Nash in HD-DEN-8103-1

Duplicate declaration from line 330.

HD-DEN-8103-1: comment by qnguyen "Done."

qnguyen — Wed, 23 Jun 2021 10:08:02 -0700

qnguyen (deleted user) replied to pmontazemi (deleted user) in HD-DEN-8103-1

Done.

HD-DEN-8103-1: comment by Sean Nash "Why removed?"

Sean Nash — Wed, 23 Jun 2021 09:28:27 -0700

Sean Nash commented on HD-DEN-8103-1

Why removed?

HD-DEN-8103-1: comment by pmontazemi "Add empty line before return."

pmontazemi — Mon, 21 Jun 2021 13:58:17 -0700

pmontazemi (deleted user) commented on HD-DEN-8103-1

Add empty line before return.

HD-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Mon, 07 Jun 2021 10:35:59 -0700

Sean Nash replied to qnguyen (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Mon, 07 Jun 2021 10:34:57 -0700

Sean Nash replied to qnguyen (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1: comment by qnguyen "Per [~dnavaei], we will need to implement this ..."

qnguyen — Mon, 07 Jun 2021 10:34:44 -0700

qnguyen (deleted user) replied to Sean Nash in HD-DEN-8103-1

Per Dara Navaei, we will need to implement this functions.

HD-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Mon, 07 Jun 2021 10:34:33 -0700

Sean Nash replied to qnguyen (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Mon, 07 Jun 2021 10:34:18 -0700

Sean Nash replied to qnguyen (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1: comment by qnguyen "The flag is latched by using OR with the local ..."

qnguyen — Fri, 04 Jun 2021 10:18:13 -0700

qnguyen (deleted user) replied to Sean Nash in HD-DEN-8103-1

The flag is latched by using OR with the local updated noNewTreatment status.

HD-DEN-8103-1: comment by Sean Nash "But now in order to use the status flag, I thin..."

Sean Nash — Fri, 04 Jun 2021 10:15:04 -0700

Sean Nash replied to qnguyen (deleted user) in HD-DEN-8103-1

But now in order to use the status flag, I think we can't allow that flag to go from TRUE to FALSE - need to latch it.

HD-DEN-8103-1: comment by qnguyen "Removed this extra flag and used alarm status n..."

qnguyen — Thu, 03 Jun 2021 10:55:16 -0700

qnguyen (deleted user) replied to Sean Nash in HD-DEN-8103-1

Removed this extra flag and used alarm status noNewTreatment flag.

HD-DEN-8103-1: comment by qnguyen "Removed this extra flag."

qnguyen — Thu, 03 Jun 2021 10:54:55 -0700

qnguyen (deleted user) replied to Sean Nash in HD-DEN-8103-1

Removed this extra flag.

HD-DEN-8103-1: comment by qnguyen "Done."

qnguyen — Thu, 03 Jun 2021 10:51:54 -0700

qnguyen (deleted user) replied to Sean Nash in HD-DEN-8103-1

Done.

HD-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 03 Jun 2021 10:33:42 -0700

Sean Nash replied to qnguyen (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 03 Jun 2021 10:32:45 -0700

Sean Nash replied to qnguyen (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1: comment by qnguyen "Yes, and we checked for DG restarted (after it ..."

qnguyen — Thu, 03 Jun 2021 10:23:39 -0700

qnguyen (deleted user) replied to Sean Nash in HD-DEN-8103-1

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface.
Sample water sub-mode has to check before DG started.

HD-DEN-8103-1: comment by Sean Nash "Looks like you are latching the noEndTreatment ..."

Sean Nash — Thu, 03 Jun 2021 09:06:42 -0700

Sean Nash commented on HD-DEN-8103-1

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

HD-DEN-8103-1: comment by Sean Nash "Is this different than alarmStatus.noNewTreatme..."

Sean Nash — Thu, 03 Jun 2021 09:03:05 -0700

Sean Nash commented on HD-DEN-8103-1

Is this different than alarmStatus.noNewTreatment?