HD-DEN-8103_DG HD Dev Alarm Design

Activity

HD-DEN-8103-1 56

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    qnguyen  (deleted user)
    Author & Moderator 2h 5m 19 Duplicate declaration from line 330.
    Reviewer - Complete 2h 21m 35 RESOLVED in CODE WALKTHROUGH.
    Reviewer - Complete 1m    
    pmontazemi  (deleted user)
    Reviewer completed
    Reviewer - Complete 1h 18m 2 RESOLVED in CODE WALKTHROUGH.
    Total   5h 46m 56  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /AlarmDefs.h Changed 3
    /DGDefs.h Changed
    /HDDefs.h Changed
    /MsgDefs.h Changed
    /Common.h Changed
    Open in IDE #permalink
    /Integrity.c Added
    /Integrity.h Added
    Open in IDE #permalink
    /NVDataMgmt.c Changed
    /RTC.c Changed 9
    /Utilities.c Changed
    /Utilities.h Changed
    Open in IDE #permalink
    /firmware/App/Controllers/AirTrap.c Changed
    Open in IDE #permalink
    /firmware/App/Controllers/AirTrap.h Changed
    /firmware/App/Controllers/BloodFlow.c Changed
    /firmware/App/Controllers/Bubble.c Changed
    /firmware/App/Controllers/DGInterface.c Changed
    /firmware/App/Controllers/DialInFlow.c Changed
    /firmware/App/Controllers/DialOutFlow.c Changed
    Open in IDE #permalink
    /firmware/App/Controllers/SyringePump.c Changed
    /firmware/App/Controllers/Valves.c Changed
    Open in IDE #permalink
    /firmware/App/Drivers/Battery.c Changed
    /firmware/App/Drivers/Battery.h Changed
    /firmware/App/Modes/BloodPrime.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ConsumableSelfTest.c Changed
    /firmware/App/Modes/Dialysis.c Changed
    /firmware/App/Modes/Dialysis.h Changed
    /firmware/App/Modes/ModeInitPOST.c Changed
    /firmware/App/Modes/ModePostTreat.c Changed 9
    /firmware/App/Modes/ModePostTreat.h Changed 3
    /firmware/App/Modes/ModePreTreat.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeStandby.c Changed
    /firmware/App/Modes/ModeTreatment.c Changed 9
    /firmware/App/Modes/ModeTreatment.h Changed
    /firmware/App/Modes/OperationModes.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/OperationModes.h Changed
    Open in IDE #permalink
    /firmware/App/Modes/PreTreatmentRecirc.c Changed
    /firmware/App/Modes/Prime.c Changed
    /firmware/App/Modes/Prime.h Changed
    /firmware/App/Modes/Rinseback.c Changed
    /firmware/App/Modes/SampleWater.c Changed 3
    /firmware/App/Modes/SampleWater.h Changed
    /firmware/App/Modes/SelfTests.c Changed
    /firmware/App/Modes/TreatmentEnd.c Changed
    /firmware/App/Modes/TreatmentStop.c Changed
    Open in IDE #permalink
    /firmware/App/Services/AlarmMgmt.c Changed 8
    /firmware/App/Services/AlarmMgmt.h Changed 3
    Open in IDE #permalink
    /firmware/App/Services/AlarmMgmtSWFaults.h Added
    /firmware/App/Services/FPGA.c Changed
    /firmware/App/Services/FPGA.h Changed
    /firmware/App/Services/Integrity.c Deleted 3
    Open in IDE #permalink
    /firmware/App/Services/Integrity.h Deleted
    Open in IDE #permalink
    /firmware/App/Services/Interrupts.c Changed
    Open in IDE #permalink
    /firmware/App/Services/SystemComm.c Changed
    /firmware/.../Services/SystemCommMessages.c Changed
    /firmware/.../Services/SystemCommMessages.h Changed 6
    /firmware/App/HDCommon.h Changed
    /firmware/include/i2c.h Changed
    Open in IDE #permalink
    /firmware/source/i2c.c Changed
    Open in IDE #permalink
    /firmware/source/sys_link.cmd Changed
    /firmware/source/sys_main.c Changed
    /firmware/.cproject Changed
    Open in IDE #permalink
    /firmware/HD.dil Changed
    Open in IDE #permalink
    /firmware/checkAlarms.sh Added

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time