Fisheye on hdfirmware/firmware/App/Modes

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16446 addressed a code review comment

Dara Navaei — Tue, 03 Oct 2023 13:17:27 -0700

Dara Navaei committed b98fd5e on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2 and 112 more in hdfirmware

DEN-16446 addressed a code review comment

· /firmware/App/Modes/ModePostTreat.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 03 Oct 2023 08:21:40 -0700

Dara Navaei committed d1604ca on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2 and 113 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/Prime.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16090: Fixed comment.

Sean Nash — Mon, 02 Oct 2023 09:26:02 -0700

Sean Nash committed f7606ab on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2 and 115 more in hdfirmware

DEN-16090: Fixed comment.

· /firmware/App/Modes/Prime.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16090: slow BP on subsequent returns to purge air state.

Sean Nash — Mon, 02 Oct 2023 09:21:07 -0700

Sean Nash committed 84cac67 on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2 and 115 more in hdfirmware

DEN-16090: slow BP on subsequent returns to purge air state.

· /firmware/App/Modes/Prime.c

(-9, +17)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16090: small changes to blood side prime to try to prevent bubbles from getting up into PBo line.

Sean Nash — Mon, 02 Oct 2023 09:08:31 -0700

Sean Nash committed fbb77f3 on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2 and 115 more in hdfirmware

DEN-16090: small changes to blood side prime to try to prevent bubbles from getting up into PBo line.

· /firmware/App/Modes/Prime.c

(-2, +5)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16446 fixed a compile alarm

Dara Navaei — Sat, 30 Sep 2023 13:08:44 -0700

Dara Navaei committed c5e8894 on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2 and 112 more in hdfirmware

DEN-16446 fixed a compile alarm

· /firmware/App/Modes/ModePostTreat.c

(-3, +3)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Sat, 30 Sep 2023 12:50:52 -0700

Dara Navaei committed 3fa496b on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2 and 116 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DialInFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DialOutFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/PresOccl.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/SyringePump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/SyringePump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/SafetyShutdown.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/BloodPrime.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreTreat.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreTreat.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeTreatment.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/Prime.c

(-2, +2)

| History

| Source

| Diff

… 10 more files in changeset.

hdfirmware (DEN-16693-institutional-settings-implementation-2): Merged staging to DEN-15792.

Sean Nash — Sat, 30 Sep 2023 11:33:41 -0700

Sean Nash committed e2cf7fe on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 117 more in hdfirmware

Merged staging to DEN-15792.

· /firmware/App/Controllers/DialInFlow.c	(-8, +8)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-22, +23)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-17, +35)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-2, +32)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-5, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-19, +9)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-3, +7)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-27, +62)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +26)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +5)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 20 Sep 2023 13:54:54 -0700

Dara Navaei committed 94c4f85 on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 119 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DGInterface.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16442 addressed the code review comments

Dara Navaei — Wed, 20 Sep 2023 13:20:05 -0700

Dara Navaei committed 0ba5dc1 on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 120 more in hdfirmware

DEN-16442 addressed the code review comments

· /firmware/App/Modes/ModePostTreat.c

(-40, +10)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16442 added code to add the concentrates to the treatment log based on the selected acid type by the user

Dara Navaei — Wed, 20 Sep 2023 12:48:51 -0700

Dara Navaei committed 6b100c2 on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 120 more in hdfirmware

DEN-16442 added code to add the concentrates to the treatment log based on the selected acid type by the user

· /firmware/App/Modes/ModePostTreat.c

(-0, +48)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 19 Sep 2023 16:42:41 -0700

Dara Navaei committed 882f43c on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 120 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeTreatment.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16397 Force pressure stabilize on treatment duration change.

Tue, 19 Sep 2023 15:07:59 -0700

Darren Cox committed 814c46b on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 121 more in hdfirmware

DEN-16397 Force pressure stabilize on treatment duration change.

· /firmware/App/Modes/ModeTreatment.c

(-0, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 14 Sep 2023 09:49:10 -0700

Dara Navaei committed 79cd16f on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 121 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/Dialysis.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16394-treatment log UF pause event changes

Vinayakam Mani — Wed, 13 Sep 2023 11:02:20 -0700

Vinayakam Mani committed 8ac6a5d on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 122 more in hdfirmware

DEN-16394-treatment log UF pause event changes

· /firmware/App/Modes/Dialysis.c

(-2, +0)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 11 Sep 2023 11:34:17 -0700

Dara Navaei committed 1d7b668 on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 124 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeTreatment.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 11 Sep 2023 11:06:02 -0700

Dara Navaei committed 4d78643 on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 125 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/Prime.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15792: More doxygen comment fixes.

Sean Nash — Fri, 08 Sep 2023 12:55:44 -0700

Sean Nash committed b687ab5 on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 117 more in hdfirmware

DEN-15792: More doxygen comment fixes.

· /firmware/App/Modes/ModePreTreat.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-3, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-3, +4)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15792: more doxygen comment fixes.

Sean Nash — Thu, 07 Sep 2023 08:37:24 -0700

Sean Nash committed 175b20f on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 117 more in hdfirmware

DEN-15792: more doxygen comment fixes.

· /firmware/App/Controllers/SyringePump.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/SafetyShutdown.c	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/BloodPrime.c	(-0, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16362-udapted per code review

Vinayakam Mani — Wed, 06 Sep 2023 14:38:28 -0700

Vinayakam Mani committed 66f8be8 on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 125 more in hdfirmware

DEN-16362-udapted per code review

· /firmware/App/Modes/ModeTreatment.c

(-4, +5)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16362 UF volume change handling

Vinayakam Mani — Wed, 06 Sep 2023 14:12:26 -0700

Vinayakam Mani committed 52feec1 on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 125 more in hdfirmware

DEN-16362 UF volume change handling

· /firmware/App/Modes/ModeTreatment.c

(-4, +5)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-15792: Misc doxygen comment fixes and removal of dead code.

Sean Nash — Fri, 01 Sep 2023 14:17:38 -0700

Sean Nash committed c505a42 on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 117 more in hdfirmware

DEN-15792: Misc doxygen comment fixes and removal of dead code.

· /firmware/App/Modes/ModePreTreat.h	(-6, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Prime.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.h	(-1, +0)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 30 Aug 2023 15:38:57 -0700

Dara Navaei committed 3f41052 on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 136 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DGInterface.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-16090-changed BP rate to avoid saline bubbles

Vinayakam Mani — Tue, 29 Aug 2023 13:39:09 -0700

Vinayakam Mani committed 4ff5a01 on branch DEN-15792-hd-software-design-description, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped and 127 more in hdfirmware

DEN-16090-changed BP rate to avoid saline bubbles

· /firmware/App/Modes/Prime.c

(-17, +7)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 28 Aug 2023 12:43:11 -0700

Dara Navaei committed 1cefdd8 on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 137 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/PresOccl.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 25 Aug 2023 09:39:26 -0700

Dara Navaei committed 408247f on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 139 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirTrap.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentStop.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 24 Aug 2023 15:49:27 -0700

Dara Navaei committed dd8d00b on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 140 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodLeak.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Temperatures.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/HDCommon.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DENBUG-59: Fixed merge conflict.

Sean Nash — Thu, 24 Aug 2023 10:53:53 -0700

Sean Nash committed 4d0c621 on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 140 more in hdfirmware

DENBUG-59: Fixed merge conflict.

· /firmware/App/Controllers/BloodFlow.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodLeak.c	(-10, +9)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.c	(-6, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-3, +18)	\| History	\| Source	\| Diff
· /firmware/App/HDCommon.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-1, +27)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-5, +12)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-4, +120)	\| History	\| Source	\| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DIAL-276: fixed op status event duplicating on op mode change only.

Michael Garthwaite — Thu, 24 Aug 2023 09:48:26 -0700

Michael Garthwaite committed 647eb56 on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 138 more in hdfirmware

DIAL-276: fixed op status event duplicating on op mode change only.

· /firmware/App/Modes/OperationModes.c

(-3, +1)

| History

| Source

| Diff

hdfirmware (DEN-16693-institutional-settings-implementation-2): DENBUG-59: Fixed rinseback resume after HD fluid leak alarm issue.

Sean Nash — Wed, 23 Aug 2023 14:38:09 -0700

Sean Nash committed aa89a11 on branch DEN-14706-can-messge-not-acked-fix, DEN-15792-hd-software-design-description and 140 more in hdfirmware

DENBUG-59: Fixed rinseback resume after HD fluid leak alarm issue.

· /firmware/App/Modes/Rinseback.c

(-9, +2)

| History

| Source

| Diff