Fisheye on hdfirmware/firmware/include/i2c.h https://devapps.diality.us/changelog/~br%3DDEN-16446-dg-dev-test-clean-up/hdfirmware/firmware/include/i2c.h Recent activity in "hdfirmware" under directory /firmware/include/i2c.h HD-UCOMMITS-20: closed by Sean Nash Thu, 03 Aug 2023 09:52:03 -0700 Sean Nash https://devapps.diality.us/cru/HD-UCOMMITS-20 https://devapps.diality.us/cru/HD-UCOMMITS-20 Sean Nash Closed HD-UCOMMITS-20 ]]> HD-UCOMMITS-20: reviewers finished Thu, 03 Aug 2023 09:29:51 -0700 https://devapps.diality.us/cru/HD-UCOMMITS-20 https://devapps.diality.us/cru/HD-UCOMMITS-20 Dara Navaei finished reviewing HD-UCOMMITS-20 HD Staging Unreviewed Commits ]]> HD-UCOMMITS-19: closed by Sean Nash Thu, 03 Aug 2023 08:57:40 -0700 Sean Nash https://devapps.diality.us/cru/HD-UCOMMITS-19 https://devapps.diality.us/cru/HD-UCOMMITS-19 Sean Nash Closed HD-UCOMMITS-19 ]]> HD-UCOMMITS-19: reviewers finished Wed, 02 Aug 2023 21:26:40 -0700 https://devapps.diality.us/cru/HD-UCOMMITS-19 https://devapps.diality.us/cru/HD-UCOMMITS-19 Dara Navaei and Sean Nash finished reviewing HD-UCOMMITS-19 HD Staging Unreviewed Commits ]]> HD-UCOMMITS-20: reviewers finished Wed, 02 Aug 2023 12:17:59 -0700 https://devapps.diality.us/cru/HD-UCOMMITS-20 https://devapps.diality.us/cru/HD-UCOMMITS-20 Sean Nash finished reviewing HD-UCOMMITS-20 HD Staging Unreviewed Commits ]]> HD-UCOMMITS-20: started by Dara Navaei Mon, 08 May 2023 09:26:10 -0700 Dara Navaei https://devapps.diality.us/cru/HD-UCOMMITS-20 https://devapps.diality.us/cru/HD-UCOMMITS-20 Dara Navaei started review HD-UCOMMITS-20 ]]> HD-UCOMMITS-19: started by Dara Navaei Mon, 08 May 2023 09:22:08 -0700 Dara Navaei https://devapps.diality.us/cru/HD-UCOMMITS-19 https://devapps.diality.us/cru/HD-UCOMMITS-19 Dara Navaei started review HD-UCOMMITS-19 ]]> HD-DEN-8103-1: closed by qnguyen Fri, 25 Jun 2021 10:42:21 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-8103-1 https://devapps.diality.us/cru/HD-DEN-8103-1 qnguyen  (deleted user) Closed HD-DEN-8103-1 ]]> HD-DEN-8103-1: reviewers finished Fri, 25 Jun 2021 10:42:10 -0700 https://devapps.diality.us/cru/HD-DEN-8103-1 https://devapps.diality.us/cru/HD-DEN-8103-1 Dara Navaei , Sean Nash and pmontazemi  (deleted user) finished reviewing HD-DEN-8103-1 HD-DEN-8103_DG HD Dev Alarm Design ]]> HD-DEN-8103-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 25 Jun 2021 10:35:16 -0700 pmontazemi https://devapps.diality.us/cru/HD-DEN-8103-1/#c10330 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10330 pmontazemi  (deleted user) replied to qnguyen  (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 25 Jun 2021 10:34:27 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-8103-1/#c10329 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10329 Sean Nash replied to qnguyen  (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-8103-1: comment by qnguyen "Duplicate declaration from line 330." Wed, 23 Jun 2021 10:07:06 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-8103-1/#c10312 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10312 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-8103-1

Duplicate declaration from line 330.

]]> HD-DEN-8103-1: comment by qnguyen "Done." Wed, 23 Jun 2021 10:08:02 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-8103-1/#c10313 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10313 qnguyen  (deleted user) replied to pmontazemi  (deleted user) in HD-DEN-8103-1

Done.

]]> HD-DEN-8103-1: comment by Sean Nash "Why removed?" Wed, 23 Jun 2021 09:28:27 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-8103-1/#c10311 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10311 Sean Nash commented on HD-DEN-8103-1

Why removed?

]]> HD-DEN-8103-1: comment by pmontazemi "Add empty line before return." Mon, 21 Jun 2021 13:58:17 -0700 pmontazemi https://devapps.diality.us/cru/HD-DEN-8103-1/#c10301 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10301 pmontazemi  (deleted user) commented on HD-DEN-8103-1

Add empty line before return.

]]> HD-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 07 Jun 2021 10:35:59 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-8103-1/#c10227 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10227 Sean Nash replied to qnguyen  (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 07 Jun 2021 10:34:57 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-8103-1/#c10226 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10226 Sean Nash replied to qnguyen  (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-8103-1: comment by qnguyen "Per [~dnavaei], we will need to implement this ..." Mon, 07 Jun 2021 10:34:44 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-8103-1/#c10225 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10225 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-8103-1

Per Dara Navaei, we will need to implement this functions.

]]> HD-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 07 Jun 2021 10:34:33 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-8103-1/#c10224 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10224 Sean Nash replied to qnguyen  (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 07 Jun 2021 10:34:18 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-8103-1/#c10223 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10223 Sean Nash replied to qnguyen  (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-8103-1: comment by qnguyen "The flag is latched by using OR with the local ..." Fri, 04 Jun 2021 10:18:13 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-8103-1/#c10205 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10205 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-8103-1

The flag is latched by using OR with the local updated noNewTreatment status.

]]> HD-DEN-8103-1: comment by Sean Nash "But now in order to use the status flag, I thin..." Fri, 04 Jun 2021 10:15:04 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-8103-1/#c10204 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10204 Sean Nash replied to qnguyen  (deleted user) in HD-DEN-8103-1

But now in order to use the status flag, I think we can't allow that flag to go from TRUE to FALSE - need to latch it.

]]> HD-DEN-8103-1: comment by qnguyen "Removed this extra flag and used alarm status n..." Thu, 03 Jun 2021 10:55:16 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-8103-1/#c10203 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10203 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-8103-1

Removed this extra flag and used alarm status noNewTreatment flag.

]]> HD-DEN-8103-1: comment by qnguyen "Removed this extra flag." Thu, 03 Jun 2021 10:54:55 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-8103-1/#c10202 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10202 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-8103-1

Removed this extra flag.

]]> HD-DEN-8103-1: comment by qnguyen "Done." Thu, 03 Jun 2021 10:51:54 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-8103-1/#c10201 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10201 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-8103-1

Done.

]]> HD-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 03 Jun 2021 10:33:42 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-8103-1/#c10195 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10195 Sean Nash replied to qnguyen  (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 03 Jun 2021 10:32:45 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-8103-1/#c10194 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10194 Sean Nash replied to qnguyen  (deleted user) in HD-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-8103-1: comment by qnguyen "Yes, and we checked for DG restarted (after it ..." Thu, 03 Jun 2021 10:23:39 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-8103-1/#c10193 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10193 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-8103-1

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface.
Sample water sub-mode has to check before DG started.

]]> HD-DEN-8103-1: comment by Sean Nash "Looks like you are latching the noEndTreatment ..." Thu, 03 Jun 2021 09:06:42 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-8103-1/#c10188 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10188 Sean Nash commented on HD-DEN-8103-1

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

]]> HD-DEN-8103-1: comment by Sean Nash "Is this different than alarmStatus.noNewTreatme..." Thu, 03 Jun 2021 09:03:05 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-8103-1/#c10187 https://devapps.diality.us/cru/HD-DEN-8103-1/#c10187 Sean Nash commented on HD-DEN-8103-1

Is this different than alarmStatus.noNewTreatment?

]]>