Fisheye on dgfirmware/firmware/App/Controllers

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16475: code review comments

Michael Garthwaite — Mon, 09 Oct 2023 08:57:32 -0700

Michael Garthwaite committed 630cc5c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 55 more in dgfirmware

DEN-16475: code review comments

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16475: added temperature event for drift during chem disinfect

Michael Garthwaite — Mon, 09 Oct 2023 07:59:14 -0700

Michael Garthwaite committed 3f44ec8 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 55 more in dgfirmware

DEN-16475: added temperature event for drift during chem disinfect

· /firmware/App/Controllers/TemperatureSensors.c

(-0, +15)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 04 Oct 2023 08:35:15 -0700

Dara Navaei committed 6edc3ea on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/TemperatureSensors.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16395-code review changes

Vinayakam Mani — Tue, 03 Oct 2023 11:38:32 -0700

Vinayakam Mani committed 9ad5a99 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 57 more in dgfirmware

DEN-16395-code review changes

· /firmware/App/Controllers/TemperatureSensors.c

(-7, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16395 Dialysate temp out of range alarm changes

Vinayakam Mani — Mon, 02 Oct 2023 13:15:50 -0700

Vinayakam Mani committed 4775393 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 57 more in dgfirmware

DEN-16395 Dialysate temp out of range alarm changes

· /firmware/App/Controllers/TemperatureSensors.c

(-7, +27)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Sat, 30 Sep 2023 13:02:28 -0700

Dara Navaei committed 164e1a3 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 57 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FluidLeak.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged staging to DEN-15791.

Sean Nash — Sat, 30 Sep 2023 11:41:29 -0700

Sean Nash committed d371983 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware

Merged staging to DEN-15791.

· /firmware/App/Controllers/ROPump.c	(-3, +15)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-6, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-67, +84)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-10, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +16)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +118)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +14)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15791: Doxygen comment fixes.

Sean Nash — Fri, 22 Sep 2023 15:32:16 -0700

Sean Nash committed d2ec7bf on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware

DEN-15791: Doxygen comment fixes.

· /firmware/App/Controllers/ConductivitySensors.h	(-3, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FluidLeak.c	(-3, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-8, +9)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-4, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 15 Sep 2023 15:32:40 -0700

Dara Navaei committed becd984 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 addressed the code review comments

Dara Navaei — Thu, 14 Sep 2023 09:48:13 -0700

Dara Navaei committed 5379702 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-15973 addressed the code review comments

· /firmware/App/Controllers/Pressures.c	(-12, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 updated the code

Dara Navaei — Thu, 14 Sep 2023 09:27:33 -0700

Dara Navaei committed 8f3e72f on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-15973 updated the code

· /firmware/App/Controllers/Pressures.c

(-1, +0)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 changed the minimum inlet pressure to be a variable based on the maximum inlet water pressure set

Dara Navaei — Thu, 14 Sep 2023 08:31:22 -0700

Dara Navaei committed 8e4c986 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-15973 changed the minimum inlet pressure to be a variable based on the maximum inlet water pressure set

· /firmware/App/Controllers/Pressures.c

(-2, +6)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 fixed the inlet water pressure alarm. DEN-16418 added chemical flush done after chemical disinfect prior to st...

Dara Navaei — Wed, 13 Sep 2023 16:47:43 -0700

Dara Navaei committed f5fae90 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-15973 fixed the inlet water pressure alarm. DEN-16418 added chemical flush done after chemical disinfect prior to starting RO permeate sample mode

· /firmware/App/Controllers/Pressures.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-0, +11)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 added the inlet water pressure limit in flush drain in the cleaning modes

Dara Navaei — Wed, 13 Sep 2023 11:04:59 -0700

Dara Navaei committed 93a5ad8 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-15973 added the inlet water pressure limit in flush drain in the cleaning modes

· /firmware/App/Controllers/Pressures.c	(-2, +24)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-0, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 13 Sep 2023 09:33:58 -0700

Dara Navaei committed c7d750b on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged DEN-15973

Dara Navaei — Wed, 13 Sep 2023 09:17:53 -0700

Dara Navaei committed 5f344d7 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

Merged DEN-15973

· /firmware/App/Controllers/Pressures.c

(-8, +18)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Code review changes

Fri, 08 Sep 2023 13:29:52 -0700

Bill Bracken committed 48731d3 on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Code review changes

· /firmware/App/Controllers/Pressures.c

(-3, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Code review changes

Fri, 08 Sep 2023 13:27:09 -0700

Bill Bracken committed 1c2d10b on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Code review changes

· /firmware/App/Controllers/Pressures.c

(-5, +8)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Remove unnecessary code per recent change.

Fri, 08 Sep 2023 11:50:44 -0700

Bill Bracken committed 2123291 on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Remove unnecessary code per recent change.

· /firmware/App/Controllers/Pressures.c

(-4, +0)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Change alarm 152 limits

Fri, 08 Sep 2023 11:45:56 -0700

Bill Bracken committed 15615b5 on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Change alarm 152 limits

· /firmware/App/Controllers/Pressures.c

(-5, +13)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Surender changes.

Fri, 08 Sep 2023 11:33:27 -0700

Bill Bracken committed 1561d34 on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Surender changes.

· /firmware/App/Controllers/Pressures.c

(-2, +7)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Update per code review comments

Fri, 01 Sep 2023 13:35:08 -0700

Bill Bracken committed 2fcf9be on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Update per code review comments

· /firmware/App/Controllers/ROPump.c

(-1, +0)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Requirements changes

Thu, 31 Aug 2023 23:23:43 -0700

Bill Bracken committed 758a99a on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Requirements changes

· /firmware/App/Controllers/ROPump.c

(-2, +3)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Change to alarm limits and persistence values

Thu, 31 Aug 2023 14:38:15 -0700

Bill Bracken committed 5a76689 on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Change to alarm limits and persistence values

· /firmware/App/Controllers/Pressures.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 31 Aug 2023 12:03:32 -0700

Dara Navaei committed 51d6753 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 68 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFault.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 30 Aug 2023 15:48:53 -0700

Dara Navaei committed 16c0f81 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Move max pwm check to execROPumpMonitor

Wed, 30 Aug 2023 10:08:05 -0700

Bill Bracken committed b37ec50 on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Move max pwm check to execROPumpMonitor

· /firmware/App/Controllers/ROPump.c

(-6, +5)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16309 added a new heat disinfect state

Dara Navaei — Mon, 28 Aug 2023 08:43:53 -0700

Dara Navaei committed 12ccb89 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

DEN-16309 added a new heat disinfect state

· /firmware/App/Controllers/Heaters.c	(-7, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-10, +62)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16309 removed the clearance period some of the persistence alarms

Dara Navaei — Sun, 27 Aug 2023 15:51:30 -0700

Dara Navaei committed 4fbaa82 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

DEN-16309 removed the clearance period some of the persistence alarms

· /firmware/App/Controllers/ConductivitySensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-4, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'staging' into DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment

Fri, 25 Aug 2023 17:23:56 -0700

Bill Bracken committed 4a57af4 on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

Merge branch 'staging' into DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment

· /firmware/App/Controllers/ROPump.c

(-1, +3)

| History

| Source

| Diff