Fisheye on hdfirmware/firmware/App/Controllers/DialOutFlow.c

HD-DENBUG-104-1: closed by Sean Nash

Sean Nash — Mon, 26 Feb 2024 15:44:42 -0800

Sean Nash Closed HD-DENBUG-104-1

HD-DENBUG-104-2: closed by Sean Nash

Sean Nash — Mon, 26 Feb 2024 15:44:32 -0800

Sean Nash Closed HD-DENBUG-104-2

hdfirmware (DEN-16819-In-Treatment-Parameter-mode-no-rejection-seen-when-hep_rate-or-hep_bol-value-is-set-to-less-than-0-p1-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 26 Feb 2024 15:31:58 -0800

Dara Navaei committed 704b4a9 on branch DEN-16672-2-air-trap-level-control-changes, DEN-16691-2-limit-pressure-compensation-fo and 21 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DialInFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-2, +2)	\| History	\| Source	\| Diff

HD-DENBUG-104-2: reviewers finished

Mon, 26 Feb 2024 15:13:16 -0800

Michael Garthwaite and Vinayakam Mani finished reviewing HD-DENBUG-104-2

HD-DENBUG-104_Alarm 38 HD Fault Dpi Rotor T

HD-DENBUG-104-1: reviewers finished

Mon, 26 Feb 2024 15:12:51 -0800

Michael Garthwaite and Vinayakam Mani finished reviewing HD-DENBUG-104-1

HD-DENBUG-104_Alarm 38 HD Fault Dpi Rotor T

hdfirmware (DEN-16819-In-Treatment-Parameter-mode-no-rejection-seen-when-hep_rate-or-hep_bol-value-is-set-to-less-than-0-p1-staging): DENBUG-104: Fixed errors in bug fix.

Sean Nash — Mon, 26 Feb 2024 13:04:59 -0800

Sean Nash committed d166758 on branch DEN-16672-2-air-trap-level-control-changes, DEN-16691-2-limit-pressure-compensation-fo and 22 more in hdfirmware

DENBUG-104: Fixed errors in bug fix.

· /firmware/App/Controllers/DialInFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-16819-In-Treatment-Parameter-mode-no-rejection-seen-when-hep_rate-or-hep_bol-value-is-set-to-less-than-0-p1-staging): DENBUG-104: restored max dialysate pump speed to 4000 RPM. Apply reduced lower rotor speed tolerance only to commanded ...

Sean Nash — Mon, 26 Feb 2024 10:40:01 -0800

Sean Nash committed d2a3a96 on branch DEN-16672-2-air-trap-level-control-changes, DEN-16691-2-limit-pressure-compensation-fo and 22 more in hdfirmware

DENBUG-104: restored max dialysate pump speed to 4000 RPM. Apply reduced lower rotor speed tolerance only to commanded speeds > 3200 RPM.

· /firmware/App/Controllers/DialInFlow.c	(-5, +6)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-5, +6)	\| History	\| Source	\| Diff

hdfirmware (DEN-16819-In-Treatment-Parameter-mode-no-rejection-seen-when-hep_rate-or-hep_bol-value-is-set-to-less-than-0-p1-staging): DENBUG-104: Increased max dialysate pump speed from 3400 to 3600 RPM. Reduced lower rotor speed tolerance from -5 RPM o...

Sean Nash — Mon, 26 Feb 2024 10:09:04 -0800

Sean Nash committed 1b6b84d on branch DEN-16672-2-air-trap-level-control-changes, DEN-16691-2-limit-pressure-compensation-fo and 22 more in hdfirmware

DENBUG-104: Increased max dialysate pump speed from 3400 to 3600 RPM. Reduced lower rotor speed tolerance from -5 RPM or -15% (whichever is bigger) to -60%.

· /firmware/App/Controllers/DialInFlow.c	(-4, +6)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-4, +6)	\| History	\| Source	\| Diff

hdfirmware (DEN-16819-In-Treatment-Parameter-mode-no-rejection-seen-when-hep_rate-or-hep_bol-value-is-set-to-less-than-0-p1-staging): DENBUG-104: Allow for dialin pwm set cmd to go to full speed.

Sean Nash — Fri, 23 Feb 2024 14:57:45 -0800

Sean Nash committed 0902a15 on branch DEN-16672-2-air-trap-level-control-changes, DEN-16691-2-limit-pressure-compensation-fo and 22 more in hdfirmware

DENBUG-104: Allow for dialin pwm set cmd to go to full speed.

· /firmware/App/Controllers/DialInFlow.c	(-3, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-3, +4)	\| History	\| Source	\| Diff

HD-DENBUG-104-2: started by Dara Navaei

Dara Navaei — Fri, 23 Feb 2024 14:50:28 -0800

Dara Navaei started review HD-DENBUG-104-2

HD-DENBUG-104-1: started by Dara Navaei

Dara Navaei — Fri, 23 Feb 2024 14:50:19 -0800

Dara Navaei started review HD-DENBUG-104-1

hdfirmware (DEN-16819-In-Treatment-Parameter-mode-no-rejection-seen-when-hep_rate-or-hep_bol-value-is-set-to-less-than-0-p1-staging): DENBUG-104: Cap dialysate pump speed to 3,400 RPM to prevent rotor speed errors.

Sean Nash — Fri, 23 Feb 2024 14:39:56 -0800

Sean Nash committed 706f67e on branch DEN-16672-2-air-trap-level-control-changes, DEN-16691-2-limit-pressure-compensation-fo and 22 more in hdfirmware

DENBUG-104: Cap dialysate pump speed to 3,400 RPM to prevent rotor speed errors.

· /firmware/App/Controllers/DialInFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff

HD-DEN-16518-2: closed by Vinayakam Mani

Vinayakam Mani — Tue, 16 Jan 2024 16:29:34 -0800

Vinayakam Mani Closed HD-DEN-16518-2

hdfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 15 Jan 2024 17:10:42 -0800

Dara Navaei committed bb2663e on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-16499-fw-message-list-testing-issues-2 and 32 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DialOutFlow.c

(-1, +1)

| History

| Source

| Diff

HD-DEN-16518-2: reviewers finished

Mon, 15 Jan 2024 16:16:01 -0800

Sean Nash and Michael Garthwaite finished reviewing HD-DEN-16518-2

HD-DEN-16518_Alarm 41 Triggered ON Dvt 014 AT The Beginning OF Treatment

HD-DEN-16518-1: closed by Vinayakam Mani

Vinayakam Mani — Mon, 15 Jan 2024 12:05:25 -0800

Vinayakam Mani Closed HD-DEN-16518-1

HD-DEN-16518-2: started by Dara Navaei

Dara Navaei — Mon, 15 Jan 2024 12:00:36 -0800

Dara Navaei started review HD-DEN-16518-2

hdfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16518-2 code changes

Vinayakam Mani — Mon, 15 Jan 2024 11:48:06 -0800

Vinayakam Mani committed 5ab87b5 on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-16499-fw-message-list-testing-issues-2 and 33 more in hdfirmware

DEN-16518-2 code changes

· /firmware/App/Controllers/DialOutFlow.c

(-1, +2)

| History

| Source

| Diff

HD-DEN-16518-1: reviewers finished

Mon, 15 Jan 2024 11:10:23 -0800

Michael Garthwaite and Sean Nash finished reviewing HD-DEN-16518-1

HD-DEN-16518_Alarm 41 Triggered ON Dvt 014 AT The Beginning OF Treatment

HD-DEN-16518-1: comment by Michael Garthwaite "RESOLVED IN CODE WALKTHROUGH."

Michael Garthwaite — Mon, 15 Jan 2024 11:10:04 -0800

Michael Garthwaite replied to Vinayakam Mani in HD-DEN-16518-1

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-16518-1: comment by Vinayakam Mani "Updated code changes. Open loop still maintains..."

Vinayakam Mani — Mon, 15 Jan 2024 11:04:07 -0800

Vinayakam Mani replied to Vinayakam Mani in HD-DEN-16518-1

Updated code changes. Open loop still maintains the minimum PWM duty cycle as 10%.

HD-DEN-16518-1: comment by Vinayakam Mani "Updated code changes. Open loop still maintains..."

Vinayakam Mani — Mon, 15 Jan 2024 11:01:44 -0800

Vinayakam Mani replied to Michael Garthwaite in HD-DEN-16518-1

Updated code changes. Open loop still maintains the minimum PWM duty cycle as 10%.

HD-DEN-16518-1: comment by Sean Nash "Do we want to have the 11% minimum here? I tho..."

Sean Nash — Mon, 15 Jan 2024 10:42:25 -0800

Sean Nash replied to Michael Garthwaite in HD-DEN-16518-1

Do we want to have the 11% minimum here? I thought it was just for closed loop control.

HD-DEN-16518-1: comment by Michael Garthwaite "This will cause open loop control mode to have ..."

Michael Garthwaite — Mon, 15 Jan 2024 10:25:37 -0800

Michael Garthwaite commented on HD-DEN-16518-1

This will cause open loop control mode to have a minimum of 11% instead of 10%. For open loop, pwmDC is assigned a value at line 295. Do we still need the #define for the 10% pwm lower limit?

hdfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 04 Jan 2024 10:28:05 -0800

Dara Navaei committed db291cc on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-16499-fw-message-list-testing-issues-2 and 34 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-3, +3)

| History

| Source

| Diff

… 102 more files in changeset.

HD-DEN-16518-1: started by Dara Navaei

Dara Navaei — Wed, 03 Jan 2024 12:00:58 -0800

Dara Navaei started review HD-DEN-16518-1

HD-DEN-16512-2: closed by Vinayakam Mani

Vinayakam Mani — Mon, 18 Dec 2023 10:24:33 -0800

Vinayakam Mani Closed HD-DEN-16512-2

hdfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 18 Dec 2023 10:20:00 -0800

Dara Navaei committed 9bde8b5 on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-16391-3-fw-dialysate-temperature-alarm-not-sensitive-enough-use-tdi-moving-avg and 35 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DialOutFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-1, +1)	\| History	\| Source	\| Diff

HD-DEN-16512-2: reviewers finished

Mon, 18 Dec 2023 09:51:51 -0800

Sean Nash and Dara Navaei finished reviewing HD-DEN-16512-2

HD-DEN-16512_Dpo Stops During Treatment After Reconfirming Dialysate Flow Rate

HD-DEN-16512-1: closed by Dara Navaei

Dara Navaei — Sun, 17 Dec 2023 15:54:13 -0800

Dara Navaei Closed HD-DEN-16512-1