Fisheye on hdfirmware/firmware/App/Controllers/AirPump.c

HD-DEN-16773-2: closed by Dara Navaei

Dara Navaei — Tue, 19 Mar 2024 19:07:45 -0700

Dara Navaei Closed HD-DEN-16773-2

HD-DEN-16773-2: reviewers finished

Tue, 19 Mar 2024 18:13:56 -0700

Sean Nash and Vinayakam Mani finished reviewing HD-DEN-16773-2

HD-DEN-16773_Add Chemical Disinfect Enable Institutional Record 2

HD-DEN-16773-2: reviewers added to HD-DEN-16773_Add Chemical Disinfect Enable Institu...

Tue, 19 Mar 2024 17:26:54 -0700

Dara Navaei added pvedantam (deleted user) to HD-DEN-16773-2

HD-DEN-16773_Add Chemical Disinfect Enable Institutional Record 2

HD-DEN-16773-1: closed by Dara Navaei

Dara Navaei — Tue, 19 Mar 2024 16:26:22 -0700

Dara Navaei Closed HD-DEN-16773-1

HD-DEN-16773-1: reviewers finished

Tue, 19 Mar 2024 16:23:26 -0700

pvedantam (deleted user) , Sean Nash and Vinayakam Mani finished reviewing HD-DEN-16773-1

HD-DEN-16773_Add Chemical Disinfect Enable TO The Institutional Record

HD-DEN-16773-2: started by Dara Navaei

Dara Navaei — Tue, 19 Mar 2024 16:11:23 -0700

Dara Navaei started review HD-DEN-16773-2

HD-DEN-16773-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 19 Mar 2024 10:03:56 -0700

Sean Nash replied to Dara Navaei in HD-DEN-16773-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16773-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 19 Mar 2024 10:03:34 -0700

Sean Nash replied to Dara Navaei in HD-DEN-16773-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16773-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 19 Mar 2024 09:29:59 -0700

Dara Navaei replied to Sean Nash in HD-DEN-16773-1

Done

HD-DEN-16773-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 19 Mar 2024 09:29:52 -0700

Dara Navaei replied to Sean Nash in HD-DEN-16773-1

Done

HD-DEN-16773-1: comment by Sean Nash "It's 1 line of code either way. Just on top or..."

Sean Nash — Tue, 19 Mar 2024 08:55:11 -0700

Sean Nash replied to Dara Navaei in HD-DEN-16773-1

It's 1 line of code either way. Just on top or below in an else. Vectorcast will see as a branch you need to test either way.
If you put it in an else, the processor does less work and I think it's a lot easier to read.

HD-DEN-16773-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 19 Mar 2024 08:54:00 -0700

Sean Nash replied to Dara Navaei in HD-DEN-16773-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16773-1: comment by Dara Navaei "I thought about having an else below but this w..."

Dara Navaei — Tue, 19 Mar 2024 08:28:07 -0700

Dara Navaei replied to Sean Nash in HD-DEN-16773-1

I thought about having an else below but this way we write less code. I have done similar in the past.

HD-DEN-16773-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 19 Mar 2024 08:23:02 -0700

Dara Navaei replied to Sean Nash in HD-DEN-16773-1

Done

HD-DEN-16773-1: comment by Sean Nash "Put this in an else below."

Sean Nash — Mon, 18 Mar 2024 21:39:09 -0700

Sean Nash commented on HD-DEN-16773-1

Put this in an else below.

HD-DEN-16773-1: comment by Sean Nash "This should probably be in an else below."

Sean Nash — Mon, 18 Mar 2024 21:38:00 -0700

Sean Nash commented on HD-DEN-16773-1

This should probably be in an else below.

HD-DEN-16773-1: comment by Sean Nash "disinfect is misspelled."

Sean Nash — Mon, 18 Mar 2024 21:35:10 -0700

Sean Nash commented on HD-DEN-16773-1

disinfect is misspelled.

HD-DEN-16773-1: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH"

Vinayakam Mani — Mon, 18 Mar 2024 15:40:18 -0700

Vinayakam Mani replied to Dara Navaei in HD-DEN-16773-1

RESOLVED IN CODE WALKTHROUGH

HD-DEN-16773-1: comment by Dara Navaei "Done"

Dara Navaei — Mon, 18 Mar 2024 15:26:43 -0700

Dara Navaei replied to Vinayakam Mani in HD-DEN-16773-1

Done

HD-DEN-16773-1: comment by Vinayakam Mani "Can we remove the AIR_PUMP_OPERATION_TIMEOUT Ma..."

Vinayakam Mani — Mon, 18 Mar 2024 15:12:20 -0700

Vinayakam Mani commented on HD-DEN-16773-1

Can we remove the AIR_PUMP_OPERATION_TIMEOUT Macro?

HD-DEN-16773-1: reviewers added to HD-DEN-16773_Add Chemical Disinfect Enable TO The ...

Mon, 18 Mar 2024 14:40:22 -0700

Dara Navaei added pvedantam (deleted user) to HD-DEN-16773-1

HD-DEN-16773_Add Chemical Disinfect Enable TO The Institutional Record

HD-DEN-16773-1: started by Dara Navaei

Dara Navaei — Mon, 18 Mar 2024 14:22:23 -0700

Dara Navaei started review HD-DEN-16773-1

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 02 Jan 2024 10:53:49 -0800

Dara Navaei committed 736cc5b on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 56 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-3, +3)

| History

| Source

| Diff

… 102 more files in changeset.

HD-DEN-14344-3: closed by Dara Navaei

Dara Navaei — Wed, 18 Oct 2023 20:49:50 -0700

Dara Navaei Closed HD-DEN-14344-3

HD-DEN-14344-3: comment by Dara Navaei "RESOLVED IN CODE WALKTHROUGH"

Dara Navaei — Wed, 18 Oct 2023 20:49:40 -0700

Dara Navaei replied to Michael Garthwaite in HD-DEN-14344-3

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14344-3: reviewers resumed

Wed, 18 Oct 2023 20:48:20 -0700

Dara Navaei resumed reviewing HD-DEN-14344-3

HD-DEN-14344_SW S85 MG Air Pump

HD-DEN-14344-3: started by Dara Navaei

Dara Navaei — Wed, 18 Oct 2023 20:47:55 -0700

Dara Navaei started review HD-DEN-14344-3

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 02 Aug 2023 12:11:49 -0700

Dara Navaei committed 4d509fa on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 162 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/AirTrap.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentRecirc.c	(-1, +1)	\| History	\| Source	\| Diff

HD-DEN-15886-1: closed by Sean Nash

Sean Nash — Wed, 02 Aug 2023 11:44:22 -0700

Sean Nash Closed HD-DEN-15886-1

HD-DEN-15886-1: reviewers finished

Wed, 02 Aug 2023 11:34:17 -0700

wbracken (deleted user) and Dara Navaei finished reviewing HD-DEN-15886-1

HD-DEN-15886_Air Pump Pushes Air Into The Heparin Syringe During Dry Self Tests