RESOLVED in CODE WALKTHROUGH.

Since the utility is finding the difference of two numbers, I see the logic is common. for instance, On a positive case, u32DiffWithWrap(9000, 26000) where 9000 is the adjustment number and 26000 is the current timer value, the result is 26000-9000 = 17000. on a negative case, u32DiffWithWrap(9000,4000) where current timer value is 4000, the result would be 0xFFFF FFFF - 9000 + 4000 + 1. i.e: FFFF FFFF - 5000 + 1. Do you still see any concern?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This looks backwards and nonsensical to me. Does this work?

RESOLVED in CODE WALKTHROUGH.

· /firmware/App/Controllers/AirTrap.c	(-18, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.h	(-1, +0)	| History	| Source	| Diff
· /firmware/App/Controllers/PresOccl.c	(-2, +0)	| History	| Source	| Diff

]]> Mon, 26 Feb 2024 10:08:15 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16672-1/#c19510 https://devapps.diality.us/cru/HD-DEN-16672-1/#c19510 Vinayakam Mani replied to Sean Nash in HD-DEN-16672-1

Done.

Why is air pump on state checked here? Seems redundant as it is checked again below.

The lower level sensor doesn't need to be raw here.

· /firmware/App/Controllers/AirTrap.c	(-15, +145)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.h	(-1, +6)	| History	| Source	| Diff
· /firmware/App/Controllers/PresOccl.c	(-1, +2)	| History	| Source	| Diff

]]> Wed, 21 Feb 2024 16:02:27 -0800 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=7092920786ccf9d52c00b84c6f47ccebc4d28118 https://devapps.diality.us/changelog/hdfirmware?cs=7092920786ccf9d52c00b84c6f47ccebc4d28118 Dara Navaei committed 7092920 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16672-air-trap-level-control-changes and 46 more in hdfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirTrap.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/PresOccl.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	| History	| Source	| Diff

]]> Wed, 21 Feb 2024 15:29:38 -0800 Vinayakam Mani https://devapps.diality.us/cru/HD-DENBUG-163-1 https://devapps.diality.us/cru/HD-DENBUG-163-1 Vinayakam Mani Closed HD-DENBUG-163-1 ]]> Wed, 21 Feb 2024 14:47:35 -0800 https://devapps.diality.us/cru/HD-DENBUG-163-1 https://devapps.diality.us/cru/HD-DENBUG-163-1 Dara Navaei and Sean Nash finished reviewing HD-DENBUG-163-1 HD-DENBUG-163_High Venous Pressure Alarm 130 Triggers During Normal Treatment Operation ]]> Wed, 21 Feb 2024 14:33:48 -0800 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19500 https://devapps.diality.us/cru/HD-DENBUG-163-1/#c19500 Sean Nash replied to Vinayakam Mani in HD-DENBUG-163-1

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Done.

Capitalize first letter of comment.

use new get function for raw levels in this assignment so that raw override is considered.

use new get function for raw levels in this condition so that raw override is considered.

· /firmware/App/Controllers/AirTrap.c	(-16, +101)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.h	(-1, +6)	| History	| Source	| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +32)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	| History	| Source	| Diff

]]>