Fisheye on hdfirmware/firmware/App/Modes/BloodPrime.h

HD-DEN-16499-2: closed by Dara Navaei

Dara Navaei — Tue, 06 Feb 2024 13:21:41 -0800

Dara Navaei Closed HD-DEN-16499-2

HD-DEN-16499-2: reviewers finished

Tue, 06 Feb 2024 13:05:34 -0800

Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16499-2

HD-DEN-16499_FW Message List Testing Issues 2

HD-DEN-16499-2: started by Dara Navaei

Dara Navaei — Tue, 06 Feb 2024 10:16:23 -0800

Dara Navaei started review HD-DEN-16499-2

HD-DEN-16499-1: closed by Dara Navaei

Dara Navaei — Fri, 02 Feb 2024 14:07:43 -0800

Dara Navaei Closed HD-DEN-16499-1

HD-DEN-16499-1: reviewers finished

Fri, 02 Feb 2024 14:07:13 -0800

Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16499-1

HD-DEN-16499_FW Message List Testing Issues

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 02 Feb 2024 13:59:48 -0800

Dara Navaei committed 20d0c02 on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16563-venous-pressure-readings-were-below-20mmhg-for-1.5-minutes-before-low-venous and 52 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodLeak.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/HDCommon.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/BloodPrime.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

HD-DEN-16499-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 02 Feb 2024 09:31:10 -0800

Sean Nash replied to Dara Navaei in HD-DEN-16499-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16499-1: comment by Dara Navaei "Fixed the code."

Dara Navaei — Fri, 02 Feb 2024 08:45:21 -0800

Dara Navaei replied to Sean Nash in HD-DEN-16499-1

Fixed the code.

HD-DEN-16499-1: comment by Sean Nash "This looks wrong."

Sean Nash — Thu, 25 Jan 2024 08:56:55 -0800

Sean Nash commented on HD-DEN-16499-1

This looks wrong.

HD-DEN-16499-1: started by Dara Navaei

Dara Navaei — Tue, 23 Jan 2024 15:13:40 -0800

Dara Navaei started review HD-DEN-16499-1

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16499 added doxygen comments for the structures

Dara Navaei — Tue, 23 Jan 2024 12:50:12 -0800

Dara Navaei committed 43b7870 on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 53 more in hdfirmware

DEN-16499 added doxygen comments for the structures

· /firmware/App/Controllers/BloodFlow.h	(-10, +10)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.h	(-10, +10)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.h	(-14, +14)	\| History	\| Source	\| Diff
· /firmware/App/HDCommon.h	(-33, +33)	\| History	\| Source	\| Diff
· /firmware/App/Modes/BloodPrime.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.h	(-28, +28)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.h	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 02 Jan 2024 10:53:49 -0800

Dara Navaei committed 736cc5b on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 56 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-3, +3)

| History

| Source

| Diff

… 102 more files in changeset.

HD-DEN-9906-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:03:24 -0700

Dara Navaei Closed HD-DEN-9906-1

HD-DEN-9906-1: reviewers finished

Thu, 19 Oct 2023 08:02:54 -0700

Dara Navaei finished reviewing HD-DEN-9906-1

HD-DEN-9906_HD Dev Flow Measurement Changes

HD-DEN-9906-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:02:45 -0700

Dara Navaei replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH

HD-DEN-9906-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:02:38 -0700

Dara Navaei replied to Sean Nash in HD-DEN-9906-1

RESOLVED in CODE WALKTHROUGH

HD-DEN-9906-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:01:36 -0700

Dara Navaei started review HD-DEN-9906-1

HD-DEN-15105-1: closed by Sean Nash

Sean Nash — Mon, 17 Apr 2023 10:26:54 -0700

Sean Nash Closed HD-DEN-15105-1

HD-DEN-15105-1: reviewers finished

Mon, 17 Apr 2023 10:25:59 -0700

jtaylor (deleted user) and wbracken (deleted user) finished reviewing HD-DEN-15105-1

HD-DEN-15105_Dialyzer Flip

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 17 Apr 2023 10:25:59 -0700

Dara Navaei committed c1b9ac0 on branch DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device and 241 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DialInFlow.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Voltages.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/BloodPrime.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/BloodPrime.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/Dialysis.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeInitPOST.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeInitPOST.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModePostTreat.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreTreat.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeTreatment.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeTreatmentParams.c

(-1, +1)

| History

| Source

| Diff

… 7 more files in changeset.

HD-DEN-15105-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Fri, 14 Apr 2023 09:23:23 -0700

wbracken (deleted user) replied to Sean Nash in HD-DEN-15105-1

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15105-1: comment by Sean Nash "For init functions, I typically do not itemize ..."

Sean Nash — Fri, 14 Apr 2023 09:21:05 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15105-1

For init functions, I typically do not itemize variables (list too long) and just say initialize module.

HD-DEN-15105-1: comment by wbracken "Variables in lines 153 to 165 should be in head..."

wbracken — Fri, 14 Apr 2023 09:07:16 -0700

wbracken (deleted user) replied to Sean Nash in HD-DEN-15105-1

Variables in lines 153 to 165 should be in header... unless pre-treatment mode module initialized covers them.

HD-DEN-15105-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Fri, 14 Apr 2023 09:13:06 -0700

wbracken (deleted user) replied to Sean Nash in HD-DEN-15105-1

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15105-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Fri, 14 Apr 2023 09:12:27 -0700

wbracken (deleted user) replied to Sean Nash in HD-DEN-15105-1

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15105-1: comment by Sean Nash "What update is required?"

Sean Nash — Fri, 14 Apr 2023 08:29:27 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15105-1

What update is required?

HD-DEN-15105-1: comment by Sean Nash "Fixed."

Sean Nash — Fri, 14 Apr 2023 08:28:37 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15105-1

Fixed.

HD-DEN-15105-1: comment by Sean Nash "Fixed."

Sean Nash — Fri, 14 Apr 2023 08:27:22 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-15105-1

Fixed.

HD-DEN-15105-1: comment by wbracken "Update header, setUFVolStatus"

wbracken — Thu, 13 Apr 2023 14:05:24 -0700

wbracken (deleted user) commented on HD-DEN-15105-1

Update header, setUFVolStatus

HD-DEN-15105-1: comment by wbracken "Update header"

wbracken — Thu, 13 Apr 2023 14:04:04 -0700

wbracken (deleted user) commented on HD-DEN-15105-1

Update header