Fisheye on hdfirmware/firmware/App/Services/WatchdogMgmt.c

HD-DEN-16693-1: closed by Dara Navaei

Dara Navaei — Fri, 08 Mar 2024 15:42:16 -0800

Dara Navaei Closed HD-DEN-16693-1

HD-DEN-16693-1: reviewers finished

Fri, 08 Mar 2024 15:42:00 -0800

Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16693-1

HD-DEN-16693_Institutional Settings Implementation

HD-DEN-16693-1: comment by pvedantam "RESOLVED IN CODE WALKTHGROUGH"

pvedantam — Fri, 08 Mar 2024 15:33:10 -0800

pvedantam (deleted user) replied to pvedantam (deleted user) in HD-DEN-16693-1

RESOLVED IN CODE WALKTHGROUGH

HD-DEN-16693-1: comment by pvedantam "We did not check for the upper limit in the pas..."

pvedantam — Fri, 08 Mar 2024 15:16:10 -0800

pvedantam (deleted user) commented on HD-DEN-16693-1

We did not check for the upper limit in the past, does this add new rejection scenarios

HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 07 Mar 2024 15:13:57 -0800

Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-1: comment by Dara Navaei "Done"

Dara Navaei — Thu, 07 Mar 2024 15:02:02 -0800

Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 07 Mar 2024 14:59:10 -0800

Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-1: comment by Sean Nash "Add minimum check here too."

Sean Nash — Thu, 07 Mar 2024 14:58:16 -0800

Sean Nash commented on HD-DEN-16693-1

Add minimum check here too.

HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 07 Mar 2024 14:56:47 -0800

Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-1: comment by Dara Navaei "Done"

Dara Navaei — Thu, 07 Mar 2024 14:46:22 -0800

Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 07 Mar 2024 14:41:12 -0800

Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-1: comment by Dara Navaei "Done"

Dara Navaei — Thu, 07 Mar 2024 14:38:48 -0800

Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

HD-DEN-16693-1: comment by Sean Nash "Do we need to add check for minimum treatment d..."

Sean Nash — Thu, 07 Mar 2024 14:35:48 -0800

Sean Nash commented on HD-DEN-16693-1

Do we need to add check for minimum treatment duration?

HD-DEN-16693-1: comment by Sean Nash "Cast constant as (F32) as before."

Sean Nash — Thu, 07 Mar 2024 14:32:54 -0800

Sean Nash commented on HD-DEN-16693-1

Cast constant as (F32) as before.

HD-DEN-16693-1: comment by Dara Navaei "Done"

Dara Navaei — Thu, 07 Mar 2024 14:14:14 -0800

Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

HD-DEN-16693-1: comment by Sean Nash "dialVolume is a volume (not a flow). Use const..."

Sean Nash — Thu, 07 Mar 2024 14:10:47 -0800

Sean Nash commented on HD-DEN-16693-1

dialVolume is a volume (not a flow). Use constant (as before) for dialVolume check.

HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 05 Mar 2024 10:14:39 -0800

Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-1: comment by Dara Navaei "Done"

Dara Navaei — Mon, 04 Mar 2024 12:55:19 -0800

Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16693 enabled the watchdog alarm

Dara Navaei — Mon, 04 Mar 2024 09:03:36 -0800

Dara Navaei committed cbea66b on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 41 more in hdfirmware

DEN-16693 enabled the watchdog alarm

· /firmware/App/Services/WatchdogMgmt.c

(-1, +1)

| History

| Source

| Diff

HD-DEN-16693-1: comment by Sean Nash "This alarm should be restored."

Sean Nash — Fri, 01 Mar 2024 10:18:22 -0800

Sean Nash commented on HD-DEN-16693-1

This alarm should be restored.

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16693 added a command to receive the respond to UI for the institutional record. DEN-16696 added code to transition ...

Dara Navaei — Thu, 29 Feb 2024 15:53:21 -0800

Dara Navaei committed 0b80b72 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 41 more in hdfirmware

DEN-16693 added a command to receive the respond to UI for the institutional record. DEN-16696 added code to transition to disinfect in HD if the HD proxy commands were used

· /firmware/App/Modes/ModeStandby.c	(-0, +19)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +34)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/WatchdogMgmt.c	(-1, +1)	\| History	\| Source	\| Diff

HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 29 Feb 2024 10:24:27 -0800

Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 29 Feb 2024 10:23:45 -0800

Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-1: comment by Dara Navaei "I check these against result since it is result..."

Dara Navaei — Thu, 29 Feb 2024 09:26:07 -0800

Dara Navaei replied to Sean Nash in HD-DEN-16693-1

I check these against result since it is result &= ().

HD-DEN-16693-1: comment by Dara Navaei "Done"

Dara Navaei — Thu, 29 Feb 2024 09:25:09 -0800

Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

HD-DEN-16693-1: reviewers added to HD-DEN-16693_Institutional Settings Implementation

Thu, 29 Feb 2024 09:23:19 -0800

Dara Navaei added pvedantam (deleted user) to HD-DEN-16693-1

HD-DEN-16693_Institutional Settings Implementation

HD-DEN-16693-1: comment by Sean Nash "Remove blank line."

Sean Nash — Tue, 27 Feb 2024 16:08:25 -0800

Sean Nash commented on HD-DEN-16693-1

Remove blank line.

HD-DEN-16693-1: comment by Sean Nash "All of these ternaries should say ... ? result ..."

Sean Nash — Tue, 27 Feb 2024 16:06:47 -0800

Sean Nash commented on HD-DEN-16693-1

All of these ternaries should say ... ? result : FALSE );

HD-DEN-16693-1: started by Dara Navaei

Dara Navaei — Sun, 25 Feb 2024 13:20:43 -0800

Dara Navaei started review HD-DEN-16693-1

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 02 Jan 2024 10:53:49 -0800

Dara Navaei committed 736cc5b on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 56 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-3, +3)

| History

| Source

| Diff

… 102 more files in changeset.