Fisheye on dgfirmware/firmware/App/Modes/ModeDrain.h https://devapps.diality.us/changelog/~br%3DDEN-17047-remove-uv-reactors-from-code-bases/dgfirmware/firmware/App/Modes/ModeDrain.h Recent activity in "dgfirmware" under directory /firmware/App/Modes/ModeDrain.h DG-DEN-14902-1: closed by Dara Navaei Fri, 15 Nov 2024 12:53:35 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14902-1 https://devapps.diality.us/cru/DG-DEN-14902-1 Dara Navaei Closed DG-DEN-14902-1 ]]> DG-DEN-2650-1: closed by Dara Navaei Thu, 19 Oct 2023 08:42:37 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei Closed DG-DEN-2650-1 ]]> DG-DEN-2650-1: reviewers finished Thu, 19 Oct 2023 08:42:03 -0700 https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei finished reviewing DG-DEN-2650-1 DG-DEN-2650_DG Firmware Infrastructure ]]> DG-DEN-2650-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:41:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 Dara Navaei replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2650-1: started by Dara Navaei Thu, 19 Oct 2023 08:41:19 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei started review DG-DEN-2650-1 ]]> DG-DEN-9480-1: closed by Dara Navaei Thu, 19 Oct 2023 08:05:20 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1 https://devapps.diality.us/cru/DG-DEN-9480-1 Dara Navaei Closed DG-DEN-9480-1 ]]> DG-DEN-9480-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:05:10 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1/#c19092 https://devapps.diality.us/cru/DG-DEN-9480-1/#c19092 Dara Navaei replied to Sean Nash in DG-DEN-9480-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-9480-1: started by Dara Navaei Thu, 19 Oct 2023 08:03:54 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1 https://devapps.diality.us/cru/DG-DEN-9480-1 Dara Navaei started review DG-DEN-9480-1 ]]> DG-DEN-15634-1: closed by Michael Garthwaite Thu, 10 Aug 2023 08:13:37 -0700 Michael Garthwaite https://devapps.diality.us/cru/DG-DEN-15634-1 https://devapps.diality.us/cru/DG-DEN-15634-1 Michael Garthwaite Closed DG-DEN-15634-1 ]]> DG-DEN-15634-1: reviewers finished Wed, 09 Aug 2023 17:50:22 -0700 https://devapps.diality.us/cru/DG-DEN-15634-1 https://devapps.diality.us/cru/DG-DEN-15634-1 wbracken  (deleted user) and Sean Nash finished reviewing DG-DEN-15634-1 DG-DEN-15634_Bad Fill States And Signal Updating Inconsistently ]]> DG-DEN-15634-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 09 Aug 2023 17:25:25 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15634-1/#c18524 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18524 Sean Nash replied to Michael Garthwaite in DG-DEN-15634-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15634-1: comment by Michael Garthwaite "Fixed!" Wed, 09 Aug 2023 16:22:47 -0700 Michael Garthwaite https://devapps.diality.us/cru/DG-DEN-15634-1/#c18522 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18522 Michael Garthwaite replied to Sean Nash in DG-DEN-15634-1

Fixed!

]]> DG-DEN-15634-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 09 Aug 2023 15:07:31 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15634-1/#c18518 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18518 Sean Nash replied to Sean Nash in DG-DEN-15634-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15634-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 09 Aug 2023 15:05:37 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15634-1/#c18517 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18517 Sean Nash replied to Michael Garthwaite in DG-DEN-15634-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15634-1: comment by Sean Nash "Move blank line up one." Wed, 09 Aug 2023 15:05:20 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15634-1/#c18516 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18516 Sean Nash replied to Michael Garthwaite in DG-DEN-15634-1

Move blank line up one.

]]> DG-DEN-15634-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 09 Aug 2023 15:04:27 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15634-1/#c18515 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18515 Sean Nash replied to Michael Garthwaite in DG-DEN-15634-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15634-1: comment by Sean Nash "Move blank line down one." Wed, 09 Aug 2023 15:03:56 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15634-1/#c18514 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18514 Sean Nash replied to Michael Garthwaite in DG-DEN-15634-1

Move blank line down one.

]]> DG-DEN-15634-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Wed, 09 Aug 2023 13:43:38 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-15634-1/#c18510 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18510 wbracken  (deleted user) replied to Michael Garthwaite in DG-DEN-15634-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-15634-1: comment by Michael Garthwaite "Fixed. Thanks!" Tue, 08 Aug 2023 13:35:15 -0700 Michael Garthwaite https://devapps.diality.us/cru/DG-DEN-15634-1/#c18501 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18501 Michael Garthwaite replied to wbracken  (deleted user) in DG-DEN-15634-1

Fixed. Thanks!

]]> DG-DEN-15634-1: comment by wbracken "Add dataPublishCounter" Mon, 07 Aug 2023 18:07:26 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-15634-1/#c18467 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18467 wbracken  (deleted user) commented on DG-DEN-15634-1

Add dataPublishCounter

]]> DG-DEN-15634-1: comment by Michael Garthwaite "Missed calling it in the exec function. Good ca..." Tue, 08 Aug 2023 13:15:25 -0700 Michael Garthwaite https://devapps.diality.us/cru/DG-DEN-15634-1/#c18498 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18498 Michael Garthwaite replied to Sean Nash in DG-DEN-15634-1

Missed calling it in the exec function. Good catch. fixed.

]]> DG-DEN-15634-1: comment by Michael Garthwaite "Fixed. Thanks!" Tue, 08 Aug 2023 13:14:50 -0700 Michael Garthwaite https://devapps.diality.us/cru/DG-DEN-15634-1/#c18497 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18497 Michael Garthwaite replied to Sean Nash in DG-DEN-15634-1

Fixed. Thanks!

]]> DG-DEN-15634-1: comment by Michael Garthwaite "Fixed. Thanks!" Tue, 08 Aug 2023 13:14:47 -0700 Michael Garthwaite https://devapps.diality.us/cru/DG-DEN-15634-1/#c18496 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18496 Michael Garthwaite replied to Sean Nash in DG-DEN-15634-1

Fixed. Thanks!

]]> DG-DEN-15634-1: comment by Michael Garthwaite "Fixed. Thanks!" Tue, 08 Aug 2023 13:14:37 -0700 Michael Garthwaite https://devapps.diality.us/cru/DG-DEN-15634-1/#c18495 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18495 Michael Garthwaite replied to Sean Nash in DG-DEN-15634-1

Fixed. Thanks!

]]> DG-DEN-15634-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Tue, 08 Aug 2023 10:37:39 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-15634-1/#c18480 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18480 wbracken  (deleted user) replied to Michael Garthwaite in DG-DEN-15634-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-15634-1: comment by Sean Nash "Restore blank line below separator comment." Tue, 08 Aug 2023 10:45:30 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15634-1/#c18485 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18485 Sean Nash commented on DG-DEN-15634-1

Restore blank line below separator comment.

]]> DG-DEN-15634-1: comment by Sean Nash "Add blank line before separator comment." Tue, 08 Aug 2023 10:45:10 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15634-1/#c18484 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18484 Sean Nash commented on DG-DEN-15634-1

Add blank line before separator comment.

]]> DG-DEN-15634-1: comment by Sean Nash "Where is this function being called?" Tue, 08 Aug 2023 10:42:32 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15634-1/#c18483 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18483 Sean Nash commented on DG-DEN-15634-1

Where is this function being called?

]]> DG-DEN-15634-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Tue, 08 Aug 2023 10:38:34 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-15634-1/#c18482 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18482 wbracken  (deleted user) replied to Michael Garthwaite in DG-DEN-15634-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-15634-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Tue, 08 Aug 2023 10:38:00 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-15634-1/#c18481 https://devapps.diality.us/cru/DG-DEN-15634-1/#c18481 wbracken  (deleted user) replied to Michael Garthwaite in DG-DEN-15634-1

RESOLVED IN CODE WALKTHROUGH

]]>