DG-DEN-14902_Bootloader For DG

Activity

DG-DEN-14902-1 2

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator      
    Reviewer - 100% reviewed 4m    
    Reviewer - 0% reviewed      
    wbracken  (deleted user)
    Reviewer - 100% reviewed 29m 1 Includes should be in alphabetical order.
    jtaylor  (deleted user)
    Reviewer - 100% reviewed 1h 3m 1 Introducing build flags seems like a bad idea. Are these ...
    Reviewer - 11% reviewed 9m    
    Reviewer - 85% reviewed 34m    
    Reviewer - 0% reviewed      
    Total   2h 22m 2  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /firmware/.launches/DG.launch Changed
    Open in IDE #permalink
    /firmware/.../Controllers/ConcentratePumps.c Changed
    /firmware/.../Controllers/ConcentratePumps.h Changed
    Open in IDE #permalink
    /firmware/.../Controllers/ConductivitySensors.c Changed
    /firmware/.../Controllers/ConductivitySensors.h Changed
    Open in IDE #permalink
    /firmware/App/Controllers/DialysateFlow.c Changed
    Open in IDE #permalink
    /firmware/App/Controllers/DrainPump.c Changed
    /firmware/App/Controllers/DrainPump.h Changed
    Open in IDE #permalink
    /firmware/App/Controllers/Fans.c Changed
    Open in IDE #permalink
    /firmware/App/Controllers/Fans.h Changed
    Open in IDE #permalink
    /firmware/App/Controllers/Heaters.c Changed 1
    /firmware/App/Controllers/Heaters.h Changed
    Open in IDE #permalink
    /firmware/App/Controllers/LoadCell.c Changed
    /firmware/App/Controllers/LoadCell.h Changed
    Open in IDE #permalink
    /firmware/App/Controllers/Pressures.c Changed
    /firmware/App/Controllers/ROPump.c Changed
    /firmware/App/Controllers/ROPump.h Changed
    /firmware/App/Controllers/Switches.c Changed
    /firmware/.../Controllers/TemperatureSensors.c Changed
    /firmware/.../Controllers/TemperatureSensors.h Changed
    Open in IDE #permalink
    /firmware/App/Controllers/Thermistors.c Changed
    Open in IDE #permalink
    /firmware/App/Controllers/UVReactors.c Changed
    Open in IDE #permalink
    /firmware/App/Controllers/Voltages.c Changed
    Open in IDE #permalink
    /firmware/App/Drivers/CPLD.c Changed
    Open in IDE #permalink
    /firmware/App/Drivers/CPLD.h Changed
    Open in IDE #permalink
    /firmware/.../Modes/ModeChemicalDisinfect.c Changed
    Open in IDE #permalink
    /firmware/.../Modes/ModeChemicalDisinfectFlush.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeDrain.c Changed
    /firmware/App/Modes/ModeDrain.h Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeFault.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeFill.c Changed
    /firmware/App/Modes/ModeFill.h Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeFlush.c Changed
    /firmware/App/Modes/ModeGenIdle.c Changed
    /firmware/App/Modes/ModeGenIdle.h Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeHeatDisinfect.c Changed
    /firmware/App/Modes/ModeInitPOST.c Changed
    /firmware/App/Modes/ModeRecirculate.c Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeService.c Changed 1
    Open in IDE #permalink
    /firmware/App/Modes/ModeStandby.c Changed
    /firmware/App/Modes/OperationModes.c Changed
    /firmware/App/Services/AlarmMgmt.c Changed
    /firmware/App/Services/AlarmMgmt.h Changed
    Open in IDE #permalink
    /firmware/App/Services/AlarmMgmtSWFaults.h Changed
    /firmware/App/Services/CommBuffers.c Changed
    Open in IDE #permalink
    /firmware/App/Services/FPGA.c Changed
    Open in IDE #permalink
    /firmware/App/Services/FPGA.h Changed
    Open in IDE #permalink
    /firmware/App/Services/Interrupts.c Changed
    Open in IDE #permalink
    /firmware/App/Services/PIControllers.c Changed
    Open in IDE #permalink
    /firmware/App/Services/Reservoirs.c Changed
    /firmware/App/Services/Reservoirs.h Changed
    /firmware/App/Services/SystemComm.c Changed
    Open in IDE #permalink
    /firmware/App/Services/SystemComm.h Changed
    Open in IDE #permalink
    /firmware/.../Services/SystemCommMessages.c Changed
    Open in IDE #permalink
    /firmware/.../Services/SystemCommMessages.h Changed
    Open in IDE #permalink
    /firmware/App/Services/WatchdogMgmt.c Changed
    Open in IDE #permalink
    /firmware/App/Tasks/TaskGeneral.c Changed
    Open in IDE #permalink
    /firmware/App/Tasks/TaskPriority.c Changed
    Open in IDE #permalink
    /firmware/App/DGCommon.h Changed
    /firmware/source/sys_link.cmd Changed
    Open in IDE #permalink
    /firmware/source/sys_main.c Changed
    Open in IDE #permalink
    /firmware/source/sys_mpu.asm Changed
    Open in IDE #permalink
    /firmware/source/sys_startup.c Changed
    Open in IDE #permalink
    /firmware/.cproject Changed
    Open in IDE #permalink
    /firmware/DG.dil Changed
    Open in IDE #permalink
    /firmware/dg_build_history.log Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time