Fisheye on dgfirmware/firmware/App/Modes/ModeHeatDisinfect.c https://devapps.diality.us/changelog/~br%3DDEN-17047-remove-uv-reactors-from-code-bases/dgfirmware/firmware/App/Modes/ModeHeatDisinfect.c Recent activity in "dgfirmware" under directory /firmware/App/Modes/ModeHeatDisinfect.c DG-DEN-17047-1: closed by Dara Navaei Sat, 08 Nov 2025 14:06:26 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17047-1 https://devapps.diality.us/cru/DG-DEN-17047-1 Dara Navaei Closed DG-DEN-17047-1 ]]> DG-DENBUG-298-1: closed by Dara Navaei Thu, 10 Apr 2025 15:09:27 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-298-1 https://devapps.diality.us/cru/DG-DENBUG-298-1 Dara Navaei Closed DG-DENBUG-298-1 ]]> DG-DENBUG-298-1: reviewers finished Wed, 09 Apr 2025 16:43:33 -0700 https://devapps.diality.us/cru/DG-DENBUG-298-1 https://devapps.diality.us/cru/DG-DENBUG-298-1 Michael Garthwaite and Sean Nash finished reviewing DG-DENBUG-298-1 DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging ]]> DG-DENBUG-298-1: started by Dara Navaei Tue, 08 Apr 2025 14:25:08 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-298-1 https://devapps.diality.us/cru/DG-DENBUG-298-1 Dara Navaei started review DG-DENBUG-298-1 ]]> DG-DENBUG-307-1: closed by Dara Navaei Fri, 04 Apr 2025 15:04:50 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-307-1 https://devapps.diality.us/cru/DG-DENBUG-307-1 Dara Navaei Closed DG-DENBUG-307-1 ]]> DG-DENBUG-307-1: reviewers finished Fri, 04 Apr 2025 11:00:43 -0700 https://devapps.diality.us/cru/DG-DENBUG-307-1 https://devapps.diality.us/cru/DG-DENBUG-307-1 Michael Garthwaite finished reviewing DG-DENBUG-307-1 DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging ]]> DG-DENBUG-307-1: reviewers finished Wed, 02 Apr 2025 11:14:02 -0700 https://devapps.diality.us/cru/DG-DENBUG-307-1 https://devapps.diality.us/cru/DG-DENBUG-307-1 Sean Nash finished reviewing DG-DENBUG-307-1 DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging ]]> DG-DENBUG-307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 02 Apr 2025 11:13:55 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21867 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21867 Sean Nash replied to Dara Navaei in DG-DENBUG-307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DENBUG-307-1: comment by Sean Nash "Not needed, but benign. RESOLVED in CODE WALKT..." Wed, 02 Apr 2025 11:13:43 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21866 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21866 Sean Nash replied to Dara Navaei in DG-DENBUG-307-1

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

]]> DG-DENBUG-307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 02 Apr 2025 11:13:11 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21865 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21865 Sean Nash replied to Dara Navaei in DG-DENBUG-307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DENBUG-307-1: comment by Dara Navaei "Done" Wed, 02 Apr 2025 10:28:52 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21864 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21864 Dara Navaei replied to Sean Nash in DG-DENBUG-307-1

Done

]]> DG-DENBUG-307-1: comment by Dara Navaei "Done" Wed, 02 Apr 2025 10:27:50 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21863 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21863 Dara Navaei replied to Sean Nash in DG-DENBUG-307-1

Done

]]> DG-DENBUG-307-1: comment by Dara Navaei "I used fabs so all are positive when monitoring..." Wed, 02 Apr 2025 10:26:21 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21862 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21862 Dara Navaei replied to Sean Nash in DG-DENBUG-307-1

I used fabs so all are positive when monitoring is started.

]]> DG-DENBUG-307-1: comment by Sean Nash "This check doesn't make sense to me. Measured ..." Tue, 01 Apr 2025 09:03:02 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21861 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21861 Sean Nash commented on DG-DENBUG-307-1

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

]]> DG-DENBUG-307-1: comment by Sean Nash "Aren't speeds (commanded and measured) always p..." Tue, 01 Apr 2025 09:01:22 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21860 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21860 Sean Nash commented on DG-DENBUG-307-1

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

]]> DG-DENBUG-307-1: comment by Sean Nash "Measured speed (whether real or override) shoul..." Tue, 01 Apr 2025 08:59:42 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21859 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21859 Sean Nash commented on DG-DENBUG-307-1

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

]]> DG-DENBUG-307-1: started by Dara Navaei Fri, 07 Mar 2025 11:32:56 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-307-1 https://devapps.diality.us/cru/DG-DENBUG-307-1 Dara Navaei started review DG-DENBUG-307-1 ]]> DG-DEN-17234-1: closed by Dara Navaei Thu, 27 Feb 2025 16:26:34 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17234-1 https://devapps.diality.us/cru/DG-DEN-17234-1 Dara Navaei Closed DG-DEN-17234-1 ]]> DG-DEN-17234-1: reviewers finished Thu, 27 Feb 2025 13:33:48 -0800 https://devapps.diality.us/cru/DG-DEN-17234-1 https://devapps.diality.us/cru/DG-DEN-17234-1 jpaguio  (deleted user) and Sean Nash finished reviewing DG-DEN-17234-1 DG-DEN-17234_Alarm 68 Fix IN Expedite Pretreatment ]]> DG-DEN-17234-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 27 Feb 2025 13:22:54 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-17234-1/#c21612 https://devapps.diality.us/cru/DG-DEN-17234-1/#c21612 Sean Nash replied to Dara Navaei in DG-DEN-17234-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-17234-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 27 Feb 2025 13:22:23 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-17234-1/#c21611 https://devapps.diality.us/cru/DG-DEN-17234-1/#c21611 Sean Nash replied to Dara Navaei in DG-DEN-17234-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-17234-1: comment by Dara Navaei "Done" Thu, 27 Feb 2025 13:09:26 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17234-1/#c21610 https://devapps.diality.us/cru/DG-DEN-17234-1/#c21610 Dara Navaei replied to Sean Nash in DG-DEN-17234-1

Done

]]> DG-DEN-17234-1: comment by Dara Navaei "No" Thu, 27 Feb 2025 13:09:18 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17234-1/#c21609 https://devapps.diality.us/cru/DG-DEN-17234-1/#c21609 Dara Navaei replied to Sean Nash in DG-DEN-17234-1

No

]]> DG-DEN-17234-1: comment by Sean Nash "Are these permanent changes?" Thu, 27 Feb 2025 12:19:08 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-17234-1/#c21608 https://devapps.diality.us/cru/DG-DEN-17234-1/#c21608 Sean Nash commented on DG-DEN-17234-1

Are these permanent changes?

]]> DG-DEN-17234-1: comment by Sean Nash "Comment doesn't match test flag." Thu, 27 Feb 2025 11:17:19 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-17234-1/#c21607 https://devapps.diality.us/cru/DG-DEN-17234-1/#c21607 Sean Nash commented on DG-DEN-17234-1

Comment doesn't match test flag.

]]> DG-DEN-17234-1: started by Dara Navaei Wed, 26 Feb 2025 13:10:14 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17234-1 https://devapps.diality.us/cru/DG-DEN-17234-1 Dara Navaei started review DG-DEN-17234-1 ]]> DG-DEN-14902-1: closed by Dara Navaei Fri, 15 Nov 2024 12:53:35 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14902-1 https://devapps.diality.us/cru/DG-DEN-14902-1 Dara Navaei Closed DG-DEN-14902-1 ]]> DG-DEN-17053-6: closed by Dara Navaei Fri, 20 Sep 2024 16:39:59 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17053-6 https://devapps.diality.us/cru/DG-DEN-17053-6 Dara Navaei Closed DG-DEN-17053-6 ]]> DG-DEN-17053-6: reviewers finished Tue, 17 Sep 2024 10:27:48 -0700 https://devapps.diality.us/cru/DG-DEN-17053-6 https://devapps.diality.us/cru/DG-DEN-17053-6 Michael Garthwaite finished reviewing DG-DEN-17053-6 DG-DEN-17053_Release 17 Firmware Update ]]> DG-DEN-17053-6: reviewers finished Mon, 16 Sep 2024 11:10:23 -0700 https://devapps.diality.us/cru/DG-DEN-17053-6 https://devapps.diality.us/cru/DG-DEN-17053-6 Sean Nash finished reviewing DG-DEN-17053-6 DG-DEN-17053_Release 17 Firmware Update ]]>