Fisheye on dgfirmware/firmware/App/Modes/OperationModes.h

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 08 Jan 2024 14:00:04 -0800

Dara Navaei committed 7d4711e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

DG-COMMON-FIX-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:43:59 -0700

Dara Navaei Closed DG-COMMON-FIX-1

DG-COMMON-FIX-1: reviewers finished

Thu, 19 Oct 2023 08:43:51 -0700

Dara Navaei finished reviewing DG-COMMON-FIX-1

DG-COMMON-FIX_Review

DG-COMMON-FIX-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:43:46 -0700

Dara Navaei replied to pmontazemi (deleted user) in DG-COMMON-FIX-1

RESOLVED in CODE WALKTHROUGH

DG-COMMON-FIX-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:43:32 -0700

Dara Navaei replied to pmontazemi (deleted user) in DG-COMMON-FIX-1

RESOLVED in CODE WALKTHROUGH

DG-COMMON-FIX-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:43:00 -0700

Dara Navaei started review DG-COMMON-FIX-1

DG-DEN-2650-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:42:37 -0700

Dara Navaei Closed DG-DEN-2650-1

DG-DEN-2650-1: reviewers finished

Thu, 19 Oct 2023 08:42:03 -0700

Dara Navaei finished reviewing DG-DEN-2650-1

DG-DEN-2650_DG Firmware Infrastructure

DG-DEN-2650-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:41:49 -0700

Dara Navaei replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-2650-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:41:19 -0700

Dara Navaei started review DG-DEN-2650-1

DG-DEN-9480-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:05:20 -0700

Dara Navaei Closed DG-DEN-9480-1

DG-DEN-9480-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:05:10 -0700

Dara Navaei replied to Sean Nash in DG-DEN-9480-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-9480-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:03:54 -0700

Dara Navaei started review DG-DEN-9480-1

DG-DEN-13460-2: closed by Dara Navaei

Dara Navaei — Wed, 18 Oct 2023 21:20:43 -0700

Dara Navaei Closed DG-DEN-13460-2

DG-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Wed, 18 Oct 2023 21:20:31 -0700

Dara Navaei replied to Sean Nash in DG-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

DG-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Wed, 18 Oct 2023 21:19:58 -0700

Dara Navaei replied to wbracken (deleted user) in DG-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

DG-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Wed, 18 Oct 2023 21:19:26 -0700

Dara Navaei replied to wbracken (deleted user) in DG-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

DG-DEN-13460-2: started by Dara Navaei

Dara Navaei — Wed, 18 Oct 2023 21:18:57 -0700

Dara Navaei started review DG-DEN-13460-2

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 15 Sep 2023 15:32:40 -0700

Dara Navaei committed becd984 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-2, +2)	\| History	\| Source	\| Diff

DG-DEN-15973-2: closed by Dara Navaei

Dara Navaei — Fri, 15 Sep 2023 15:31:36 -0700

Dara Navaei Closed DG-DEN-15973-2

DG-DEN-15973-2: reviewers finished

Fri, 15 Sep 2023 14:43:27 -0700

jtaylor (deleted user) , wbracken (deleted user) and Sean Nash finished reviewing DG-DEN-15973-2

DG-DEN-15973_Alarm 48 UF Rate Tare Error Triggered During Treatment

DG-DEN-15973-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 14 Sep 2023 10:58:42 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15973-2

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15973-2: comment by Dara Navaei "Done"

Dara Navaei — Thu, 14 Sep 2023 10:28:15 -0700

Dara Navaei replied to Sean Nash in DG-DEN-15973-2

Done

DG-DEN-15973-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 14 Sep 2023 09:53:07 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15973-2

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15973-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 14 Sep 2023 09:52:58 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15973-2

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15973-2: comment by Sean Nash "Dara, I mean inline comments for the magic numb..."

Sean Nash — Thu, 14 Sep 2023 09:51:45 -0700

Sean Nash replied to Sean Nash in DG-DEN-15973-2

Dara, I mean inline comments for the magic numbers. Explain what 40 and 32 mean and why you're using those values.

DG-DEN-15973-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 14 Sep 2023 09:50:41 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15973-2

RESOLVED in CODE WALKTHROUGH.

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15973 addressed the code review comments

Dara Navaei — Thu, 14 Sep 2023 09:48:13 -0700

Dara Navaei committed 5379702 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

DEN-15973 addressed the code review comments

· /firmware/App/Controllers/Pressures.c	(-12, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-1, +1)	\| History	\| Source	\| Diff

DG-DEN-15973-2: comment by Dara Navaei "Done"

Dara Navaei — Thu, 14 Sep 2023 09:44:33 -0700

Dara Navaei replied to Sean Nash in DG-DEN-15973-2

Done

DG-DEN-15973-2: comment by Dara Navaei "Done"

Dara Navaei — Thu, 14 Sep 2023 09:42:59 -0700

Dara Navaei replied to Sean Nash in DG-DEN-15973-2

Done