DG-COMMON-FIX-1 DG-COMMON-FIX_Review

closed on 19 Oct 23

Author

Moderator

Reviewers

DG-COMMON-FIX_Review

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 63

common 0
- File AlarmDefs.h 3 Remove
- File MsgDefs.h 0 Remove
dgfirmware 0
- Folder firmware 0
  - Folder .settings 0
    - File org.eclipse.core.resources.prefs 0 Remove
  - Folder App 0
    - Folder Controllers 0
      - File LoadCell.c 0 Remove
      - File LoadCell.h 0 Remove
      - File SensorProcess.c 0 Remove
      - File SensorProcess.h 0 Remove
    - Folder Drivers 0
      - File InternalADC.c 3 Remove
      - File InternalADC.h 0 Remove
    - Folder Modes 0
      - File ModeFill.c 3 Remove
      - File ModeFill.h 0 Remove
      - File ModeSolo.c 3 Remove
      - File ModeSolo.h 2 Remove
      - File ModeStandby.c 10 Remove
      - File ModeStandby.h 0 Remove
      - File OperationModes.c 0 Remove
      - File OperationModes.h 0 Remove
    - Folder Services 0
      - File FPGA.c 0 Remove
      - File FPGA.h 0 Remove
      - File Reservoirs.c 0 Remove
      - File Reservoirs.h 0 Remove
      - File SystemComm.c 0 Remove
      - File SystemCommMessages.c 0 Remove
      - File SystemCommMessages.h 0 Remove
      - File WatchdogMgmt.c 0 Remove
    - Folder Tasks 0
      - File TaskGeneral.c 0 Remove
      - File TaskPriority.c 0 Remove
    - File DGCommon.h 0 Remove
  - Folder include 0
    - File adc.h 0 Remove
    - File gio.h 0 Remove
  - Folder source 0
    - File adc.c 0 Remove
    - File gio.c 0 Remove
    - File sys_main.c 3 Remove
  - File .cproject 0 Remove
  - File DG.dil 0 Remove
fwcommon 0
- Folder FlashDriver 0
  - File CGT.CCS.h 0 Remove
  - File CGT.gcc.h 0 Remove
  - File Compatibility.h 0 Remove
  - File Constants.h 0 Remove
  - File F021.h 0 Remove
  - File F021_API_CortexR4_LE_L2FMC_V3D16_NDS.lib 0 Remove
  - File FapiFunctions.h 0 Remove
  - File Fapi_UserDefinedFunctions.c 0 Remove
  - File Helpers.h 0 Remove
  - File Registers.h 0 Remove
  - File Registers_FMC_LE.h 0 Remove
  - File Types.h 0 Remove
- Folder FlashDrvr 0
  - File CGT.CCS.h 0 Remove
  - File CGT.gcc.h 0 Remove
  - File Compatibility.h 0 Remove
  - File Constants.h 0 Remove
  - File F021.h 0 Remove
  - File F021_API_CortexR4_LE_L2FMC_V3D16_NDS.lib 0 Remove
  - File FapiFunctions.h 0 Remove
  - File Fapi_UserDefinedFunctions.c 0 Remove
  - File Helpers.h 0 Remove
  - File Registers.h 0 Remove
  - File Registers_FMC_LE.h 0 Remove
  - File Types.h 0 Remove
- File NVDataMgmt.c 0 Remove
- File NVDataMgmt.h 0 Remove
- File RTC.c 3 Remove
- File RTC.h 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Sean Nash	Author & Moderator	22m	9	Dara, I thought we got rid of this? Maybe you did in your...
Dara Navaei	Reviewer - Complete	37m	2	RESOLVED in CODE WALKTHROUGH
pmontazemi (deleted user)	Reviewer - Complete	1h 14m	19	RESOLVED in CODE WALKTHROUGH.
Total		2h 14m	30

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/firmware/App/Controllers/SensorProcess.c Deleted

Click to load diff

/firmware/App/Controllers/SensorProcess.h Deleted

Click to load diff

/FlashDriver/F021_API_CortexR4_LE_L2FMC_V3D16_NDS.lib Deleted

Click to load diff

/FlashDriver/Fapi_UserDefinedFunctions.c Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DG-COMMON-FIX-1

DG-COMMON-FIX_Review

DG-COMMON-FIX-1 30

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

DG-COMMON-FIX_Review

DG-COMMON-FIX-1 30

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time