Fisheye on hdfirmware/firmware/App/Controllers/DGInterface.c https://devapps.diality.us/changelog/~br%3DDEN-17053-release-17-firmware-update-usage-update/hdfirmware/firmware/App/Controllers/DGInterface.c Recent activity in "hdfirmware" under directory /firmware/App/Controllers/DGInterface.c HD-DEN-17299-1: closed by Dara Navaei Mon, 16 Jun 2025 16:26:27 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-17299-1 https://devapps.diality.us/cru/HD-DEN-17299-1 Dara Navaei Closed HD-DEN-17299-1 ]]> HD-DEN-17299-1: reviewers finished Mon, 16 Jun 2025 15:24:34 -0700 https://devapps.diality.us/cru/HD-DEN-17299-1 https://devapps.diality.us/cru/HD-DEN-17299-1 Michael Garthwaite finished reviewing HD-DEN-17299-1 HD-DEN-17299_Release 22 P1B Staging ]]> HD-DEN-17299-1: reviewers finished Fri, 13 Jun 2025 14:34:14 -0700 https://devapps.diality.us/cru/HD-DEN-17299-1 https://devapps.diality.us/cru/HD-DEN-17299-1 Sean Nash finished reviewing HD-DEN-17299-1 HD-DEN-17299_Release 22 P1B Staging ]]> HD-DEN-17299-1: started by Dara Navaei Fri, 13 Jun 2025 09:12:21 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-17299-1 https://devapps.diality.us/cru/HD-DEN-17299-1 Dara Navaei started review HD-DEN-17299-1 ]]> HD-DENBUG-318-1: closed by Dara Navaei Thu, 12 Jun 2025 15:01:25 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-318-1 https://devapps.diality.us/cru/HD-DENBUG-318-1 Dara Navaei Closed HD-DENBUG-318-1 ]]> HD-DENBUG-318-1: reviewers finished Mon, 09 Jun 2025 09:34:07 -0700 https://devapps.diality.us/cru/HD-DENBUG-318-1 https://devapps.diality.us/cru/HD-DENBUG-318-1 Michael Garthwaite finished reviewing HD-DENBUG-318-1 HD-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging ]]> HD-DENBUG-318-1: reviewers finished Thu, 29 May 2025 16:12:33 -0700 https://devapps.diality.us/cru/HD-DENBUG-318-1 https://devapps.diality.us/cru/HD-DENBUG-318-1 Sean Nash finished reviewing HD-DENBUG-318-1 HD-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging ]]> HD-DENBUG-318-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH" Wed, 21 May 2025 09:04:44 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-318-1/#c22050 https://devapps.diality.us/cru/HD-DENBUG-318-1/#c22050 Sean Nash replied to Dara Navaei in HD-DENBUG-318-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DENBUG-318-1: comment by Dara Navaei "Done" Tue, 20 May 2025 16:04:40 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-318-1/#c22045 https://devapps.diality.us/cru/HD-DENBUG-318-1/#c22045 Dara Navaei replied to Sean Nash in HD-DENBUG-318-1

Done

]]> HD-DENBUG-318-1: comment by Sean Nash "This is not really a rej ratio - it's a maximum..." Tue, 20 May 2025 10:45:59 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-318-1/#c22040 https://devapps.diality.us/cru/HD-DENBUG-318-1/#c22040 Sean Nash commented on HD-DENBUG-318-1

This is not really a rej ratio - it's a maximum reg ratio. We should make that clear in naming #defines, field names, etc...

]]> HD-DENBUG-318-1: started by Dara Navaei Fri, 16 May 2025 14:41:40 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-318-1 https://devapps.diality.us/cru/HD-DENBUG-318-1 Dara Navaei started review HD-DENBUG-318-1 ]]> HD-DEN-16680-2: closed by Dara Navaei Wed, 09 Oct 2024 11:12:20 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16680-2 https://devapps.diality.us/cru/HD-DEN-16680-2 Dara Navaei Closed HD-DEN-16680-2 ]]> HD-DEN-16680-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH on behalf of [~sna..." Wed, 09 Oct 2024 11:12:10 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16680-2/#c20443 https://devapps.diality.us/cru/HD-DEN-16680-2/#c20443 Dara Navaei replied to Dara Navaei in HD-DEN-16680-2

RESOLVED in CODE WALKTHROUGH on behalf of Sean Nash

]]> HD-DEN-16680-2: started by Dara Navaei Wed, 09 Oct 2024 11:11:31 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16680-2 https://devapps.diality.us/cru/HD-DEN-16680-2 Dara Navaei started review HD-DEN-16680-2 ]]> HD-DEN-17053-1: closed by Dara Navaei Fri, 20 Sep 2024 16:40:04 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-17053-1 https://devapps.diality.us/cru/HD-DEN-17053-1 Dara Navaei Closed HD-DEN-17053-1 ]]> HD-DEN-17053-1: reviewers finished Fri, 20 Sep 2024 14:35:58 -0700 https://devapps.diality.us/cru/HD-DEN-17053-1 https://devapps.diality.us/cru/HD-DEN-17053-1 Sean Nash , Vinayakam Mani and Michael Garthwaite finished reviewing HD-DEN-17053-1 HD-DEN-17053_Release 17 Firmware Update ]]> HD-DEN-17053-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 16 Sep 2024 11:11:03 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-17053-1/#c20215 https://devapps.diality.us/cru/HD-DEN-17053-1/#c20215 Sean Nash replied to Dara Navaei in HD-DEN-17053-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-17053-1: comment by Dara Navaei "Done" Fri, 13 Sep 2024 12:15:14 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-17053-1/#c20207 https://devapps.diality.us/cru/HD-DEN-17053-1/#c20207 Dara Navaei replied to Sean Nash in HD-DEN-17053-1

Done

]]> HD-DEN-17053-1: comment by Sean Nash "Remove extra blank line." Fri, 13 Sep 2024 11:46:11 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-17053-1/#c20203 https://devapps.diality.us/cru/HD-DEN-17053-1/#c20203 Sean Nash commented on HD-DEN-17053-1

Remove extra blank line.

]]> HD-DEN-17053-1: started by Dara Navaei Fri, 13 Sep 2024 10:22:22 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-17053-1 https://devapps.diality.us/cru/HD-DEN-17053-1 Dara Navaei started review HD-DEN-17053-1 ]]> hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 28 Aug 2024 09:26:15 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=a1a0187daedaf2c12e6f9eccfbf9e423d952e029 https://devapps.diality.us/changelog/hdfirmware?cs=a1a0187daedaf2c12e6f9eccfbf9e423d952e029 Dara Navaei committed a1a0187 on branch DEN-17053-release-17-firmware-update-usage-update, DEN-17063-cartridge-testing-special-s-w- and 28 more in hdfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DGInterface.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/DGInterface.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +1) | History | Source | Diff
]]> HD-DEN-16680-2: reviewers finished Wed, 28 Aug 2024 08:33:16 -0700 https://devapps.diality.us/cru/HD-DEN-16680-2 https://devapps.diality.us/cru/HD-DEN-16680-2 Sean Nash finished reviewing HD-DEN-16680-2 HD-DEN-16680_P1B Inlet Water Shutdown During Heat Disinfect Staging ]]> HD-DEN-16680-2: reviewers finished Tue, 27 Aug 2024 16:23:58 -0700 https://devapps.diality.us/cru/HD-DEN-16680-2 https://devapps.diality.us/cru/HD-DEN-16680-2 Vinayakam Mani finished reviewing HD-DEN-16680-2 HD-DEN-16680_P1B Inlet Water Shutdown During Heat Disinfect Staging ]]> HD-DEN-16680-2: comment by Dara Navaei "Done" Tue, 27 Aug 2024 10:05:54 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16680-2/#c19854 https://devapps.diality.us/cru/HD-DEN-16680-2/#c19854 Dara Navaei replied to Sean Nash in HD-DEN-16680-2

Done

]]> HD-DEN-16680-2: comment by Sean Nash "Param is wrong." Tue, 27 Aug 2024 09:56:19 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16680-2/#c19849 https://devapps.diality.us/cru/HD-DEN-16680-2/#c19849 Sean Nash commented on HD-DEN-16680-2

Param is wrong.

]]> HD-DEN-16680-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 27 Aug 2024 09:53:09 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16680-2/#c19848 https://devapps.diality.us/cru/HD-DEN-16680-2/#c19848 Sean Nash replied to Dara Navaei in HD-DEN-16680-2

RESOLVED in CODE WALKTHROUGH.

]]> hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16680 updated the code Mon, 15 Jul 2024 11:00:54 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=4f8f1ab7fb6ebd3ca87663784cbccdf685ff77f1 https://devapps.diality.us/changelog/hdfirmware?cs=4f8f1ab7fb6ebd3ca87663784cbccdf685ff77f1 Dara Navaei committed 4f8f1ab on branch DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging, DEN-17053-release-17-firmware-update-usage-update and 30 more in hdfirmware DEN-16680 updated the code

· /firmware/App/Controllers/DGInterface.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-7, +7) | History | Source | Diff
]]> HD-DEN-16680-2: comment by Dara Navaei "This is just the active cool mode by itself." Mon, 15 Jul 2024 10:46:58 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16680-2/#c19812 https://devapps.diality.us/cru/HD-DEN-16680-2/#c19812 Dara Navaei replied to Sean Nash in HD-DEN-16680-2

This is just the active cool mode by itself.

]]> hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16680 updated the code to support heat disinfect active and passive cool Mon, 15 Jul 2024 10:44:49 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=70654c8e042da0dd7ee7dc37c21bd8f4d54544e7 https://devapps.diality.us/changelog/hdfirmware?cs=70654c8e042da0dd7ee7dc37c21bd8f4d54544e7 Dara Navaei committed 70654c8 on branch DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging, DEN-17053-release-17-firmware-update-usage-update and 30 more in hdfirmware DEN-16680 updated the code to support heat disinfect active and passive cool

· /firmware/App/Controllers/DGInterface.c (-14, +12) | History | Source | Diff
· /firmware/App/Controllers/DGInterface.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-17, +19) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-3, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-12, +12) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-3, +3) | History | Source | Diff
]]> HD-DEN-16680-2: comment by Sean Nash "We didn't have this before?" Mon, 01 Jul 2024 16:45:39 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16680-2/#c19799 https://devapps.diality.us/cru/HD-DEN-16680-2/#c19799 Sean Nash commented on HD-DEN-16680-2

We didn't have this before?

]]>