RESOLVED in CODE WALKTHROUGH on behalf of Sean Nash

RESOLVED in CODE WALKTHROUGH.

Done

Remove extra blank line.

· /firmware/App/Controllers/DGInterface.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DGInterface.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	| History	| Source	| Diff

]]> Wed, 28 Aug 2024 08:33:16 -0700 https://devapps.diality.us/cru/HD-DEN-16680-2 https://devapps.diality.us/cru/HD-DEN-16680-2 Sean Nash finished reviewing HD-DEN-16680-2 HD-DEN-16680_P1B Inlet Water Shutdown During Heat Disinfect Staging ]]> Tue, 27 Aug 2024 16:23:58 -0700 https://devapps.diality.us/cru/HD-DEN-16680-2 https://devapps.diality.us/cru/HD-DEN-16680-2 Vinayakam Mani finished reviewing HD-DEN-16680-2 HD-DEN-16680_P1B Inlet Water Shutdown During Heat Disinfect Staging ]]> Tue, 27 Aug 2024 10:05:54 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16680-2/#c19854 https://devapps.diality.us/cru/HD-DEN-16680-2/#c19854 Dara Navaei replied to Sean Nash in HD-DEN-16680-2

Done

Param is wrong.

RESOLVED in CODE WALKTHROUGH.

This is just the active cool mode by itself.

· /firmware/App/Controllers/DGInterface.c	(-14, +12)	| History	| Source	| Diff
· /firmware/App/Controllers/DGInterface.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-17, +19)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.c	(-12, +12)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.h	(-3, +3)	| History	| Source	| Diff

]]> Mon, 01 Jul 2024 16:45:39 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16680-2/#c19799 https://devapps.diality.us/cru/HD-DEN-16680-2/#c19799 Sean Nash commented on HD-DEN-16680-2

We didn't have this before?

· /firmware/App/Controllers/DGInterface.c	(-1, +37)	| History	| Source	| Diff
· /firmware/App/Controllers/DGInterface.h	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-18, +103)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.h	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +41)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +4)	| History	| Source	| Diff

]]> Fri, 05 Apr 2024 09:29:02 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=e8edb83fcba5c355198efc30944d51c54814bdbe https://devapps.diality.us/changelog/hdfirmware?cs=e8edb83fcba5c355198efc30944d51c54814bdbe Dara Navaei committed e8edb83 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 39 more in hdfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DGInterface.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/Rinseback.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmt.c	(-2, +2)	| History	| Source	| Diff

]]> Fri, 05 Apr 2024 09:27:34 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16782-1 https://devapps.diality.us/cru/HD-DEN-16782-1 Vinayakam Mani Closed HD-DEN-16782-1 ]]> Fri, 05 Apr 2024 09:24:16 -0700 https://devapps.diality.us/cru/HD-DEN-16782-1 https://devapps.diality.us/cru/HD-DEN-16782-1 Dara Navaei finished reviewing HD-DEN-16782-1 HD-DEN-16782_Unable TO Clear Communication Error Alarm 65 During Power Loss ]]> Thu, 04 Apr 2024 17:33:23 -0700 https://devapps.diality.us/cru/HD-DEN-16782-1 https://devapps.diality.us/cru/HD-DEN-16782-1 Sean Nash finished reviewing HD-DEN-16782-1 HD-DEN-16782_Unable TO Clear Communication Error Alarm 65 During Power Loss ]]> Thu, 04 Apr 2024 17:31:03 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16782-1/#c19660 https://devapps.diality.us/cru/HD-DEN-16782-1/#c19660 Sean Nash replied to Vinayakam Mani in HD-DEN-16782-1

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

· /firmware/App/Controllers/DGInterface.h

(-1, +2)

| History

| Source

| Diff

]]> Tue, 02 Apr 2024 11:21:36 -0700 Vinayakam Mani https://devapps.diality.us/changelog/hdfirmware?cs=f373b6c38077c7e6071939e702fab65db58c1146 https://devapps.diality.us/changelog/hdfirmware?cs=f373b6c38077c7e6071939e702fab65db58c1146 Vinayakam Mani committed f373b6c on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 39 more in hdfirmware DEN-16782 addressing code review comments

· /firmware/App/Controllers/DGInterface.c	(-25, +0)	| History	| Source	| Diff
· /firmware/App/Controllers/DGInterface.h	(-2, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.c	(-27, +26)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.h	(-0, +3)	| History	| Source	| Diff
· /firmware/App/Modes/Rinseback.c	(-4, +8)	| History	| Source	| Diff

]]> Tue, 02 Apr 2024 09:12:32 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16782-1/#c19654 https://devapps.diality.us/cru/HD-DEN-16782-1/#c19654 Sean Nash commented on HD-DEN-16782-1

Does this need to be public?