Fisheye on hdfirmware/firmware/App/Controllers/PresOccl.h https://devapps.diality.us/changelog/~br%3DDEN-17053-release-17-firmware-update-usage-update/hdfirmware/firmware/App/Controllers/PresOccl.h Recent activity in "hdfirmware" under directory /firmware/App/Controllers/PresOccl.h HD-DENBUG-249-1: closed by Dara Navaei Mon, 13 May 2024 13:23:09 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-249-1 https://devapps.diality.us/cru/HD-DENBUG-249-1 Dara Navaei Closed HD-DENBUG-249-1 ]]> HD-DENBUG-249-1: reviewers finished Mon, 13 May 2024 10:13:27 -0700 https://devapps.diality.us/cru/HD-DENBUG-249-1 https://devapps.diality.us/cru/HD-DENBUG-249-1 Vinayakam Mani and Sean Nash finished reviewing HD-DENBUG-249-1 HD-DENBUG-249_Pressure Window Starting Values P1 Staging ]]> HD-DENBUG-249-1: started by Dara Navaei Sun, 12 May 2024 14:38:57 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-249-1 https://devapps.diality.us/cru/HD-DENBUG-249-1 Dara Navaei started review HD-DENBUG-249-1 ]]> hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 10 May 2024 13:06:54 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=8121bf62592934e01f365a973ac813c3d4748cda https://devapps.diality.us/changelog/hdfirmware?cs=8121bf62592934e01f365a973ac813c3d4748cda Dara Navaei committed 8121bf6 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 33 more in hdfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/PresOccl.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/PresOccl.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeTreatment.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +2) | History | Source | Diff
]]> HD-DEN-16851-1: closed by Vinayakam Mani Fri, 10 May 2024 11:59:08 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16851-1 https://devapps.diality.us/cru/HD-DEN-16851-1 Vinayakam Mani Closed HD-DEN-16851-1 ]]> HD-DEN-16851-1: reviewers finished Fri, 10 May 2024 11:35:14 -0700 https://devapps.diality.us/cru/HD-DEN-16851-1 https://devapps.diality.us/cru/HD-DEN-16851-1 Dara Navaei finished reviewing HD-DEN-16851-1 HD-DEN-16851_New Alarm For Increased Occlus ]]> HD-DEN-16851-1: reviewers finished Thu, 09 May 2024 12:43:35 -0700 https://devapps.diality.us/cru/HD-DEN-16851-1 https://devapps.diality.us/cru/HD-DEN-16851-1 Sean Nash finished reviewing HD-DEN-16851-1 HD-DEN-16851_New Alarm For Increased Occlus ]]> HD-DEN-16851-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 02 May 2024 12:54:21 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19752 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19752 Sean Nash replied to Vinayakam Mani in HD-DEN-16851-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16851-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 02 May 2024 12:53:54 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19751 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19751 Sean Nash replied to Vinayakam Mani in HD-DEN-16851-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16851-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 02 May 2024 12:53:41 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19750 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19750 Sean Nash replied to Vinayakam Mani in HD-DEN-16851-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16851-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 02 May 2024 12:53:17 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19749 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19749 Sean Nash replied to Vinayakam Mani in HD-DEN-16851-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16851-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 02 May 2024 12:52:57 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19748 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19748 Sean Nash replied to Vinayakam Mani in HD-DEN-16851-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16851-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 02 May 2024 12:52:27 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19747 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19747 Sean Nash replied to Vinayakam Mani in HD-DEN-16851-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16851-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 02 May 2024 12:52:11 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19746 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19746 Sean Nash replied to Vinayakam Mani in HD-DEN-16851-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16851-1: comment by Vinayakam Mani "Done." Thu, 02 May 2024 12:31:30 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16851-1/#c19745 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19745 Vinayakam Mani replied to Sean Nash in HD-DEN-16851-1

Done.

]]> HD-DEN-16851-1: comment by Vinayakam Mani "Done" Thu, 02 May 2024 12:31:19 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16851-1/#c19744 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19744 Vinayakam Mani replied to Sean Nash in HD-DEN-16851-1

Done

]]> HD-DEN-16851-1: comment by Vinayakam Mani "Done" Thu, 02 May 2024 12:31:09 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16851-1/#c19743 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19743 Vinayakam Mani replied to Sean Nash in HD-DEN-16851-1

Done

]]> HD-DEN-16851-1: comment by Vinayakam Mani "Done" Thu, 02 May 2024 12:30:46 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16851-1/#c19742 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19742 Vinayakam Mani replied to Sean Nash in HD-DEN-16851-1

Done

]]> HD-DEN-16851-1: comment by Vinayakam Mani "Yes, when we are not in treatment mode, the sta..." Thu, 02 May 2024 12:28:13 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16851-1/#c19741 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19741 Vinayakam Mani replied to Sean Nash in HD-DEN-16851-1

Yes, when we are not in treatment mode, the state machine sets the state to "pressure_limits_state_off" at start of this function ( line : 673). hence mode check is not necessary.

]]> HD-DEN-16851-1: comment by Vinayakam Mani "Done." Thu, 02 May 2024 12:27:17 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16851-1/#c19740 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19740 Vinayakam Mani replied to Sean Nash in HD-DEN-16851-1

Done.

]]> HD-DEN-16851-1: comment by Vinayakam Mani "Done." Thu, 02 May 2024 12:27:03 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16851-1/#c19739 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19739 Vinayakam Mani replied to Sean Nash in HD-DEN-16851-1

Done.

]]> HD-DEN-16851-1: comment by Sean Nash "I think we just want to publish the baseline he..." Thu, 02 May 2024 11:43:00 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19738 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19738 Sean Nash commented on HD-DEN-16851-1

I think we just want to publish the baseline here (not +1000).

]]> HD-DEN-16851-1: comment by Sean Nash "Yes, if you cast either value in division as a ..." Thu, 02 May 2024 11:40:30 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19737 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19737 Sean Nash commented on HD-DEN-16851-1

Yes, if you cast either value in division as a F32, the result will be F32. This is all we need as F32 (the .data). The samples and total can stay U32.
You might want to cast the total as F32 as well for consistency.

]]> HD-DEN-16851-1: comment by Sean Nash "F32 not needed here." Thu, 02 May 2024 11:39:50 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19736 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19736 Sean Nash commented on HD-DEN-16851-1

F32 not needed here.

]]> HD-DEN-16851-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 02 May 2024 11:39:02 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19735 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19735 Sean Nash replied to Vinayakam Mani in HD-DEN-16851-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16851-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 02 May 2024 11:38:49 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19734 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19734 Sean Nash replied to Vinayakam Mani in HD-DEN-16851-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16851-1: comment by Sean Nash "Casting not necessary." Thu, 02 May 2024 11:38:00 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19733 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19733 Sean Nash commented on HD-DEN-16851-1

Casting not necessary.

]]> HD-DEN-16851-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 02 May 2024 11:35:56 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19732 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19732 Sean Nash replied to Vinayakam Mani in HD-DEN-16851-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16851-1: comment by Sean Nash "Are we guaranteed to be in Treatment mode here?..." Thu, 02 May 2024 11:35:37 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19731 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19731 Sean Nash commented on HD-DEN-16851-1

Are we guaranteed to be in Treatment mode here? If not, check mode too.

]]> HD-DEN-16851-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 02 May 2024 11:32:04 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16851-1/#c19730 https://devapps.diality.us/cru/HD-DEN-16851-1/#c19730 Sean Nash replied to Vinayakam Mani in HD-DEN-16851-1

RESOLVED in CODE WALKTHROUGH.

]]>