RESOLVED in CODE WALKTHROUGH on behalf of Sean Nash

RESOLVED in CODE WALKTHROUGH.

Done

Remove extra blank line.

· /firmware/App/Controllers/DGInterface.c	(-18, +51)	| History	| Source	| Diff
· /firmware/App/Controllers/DGInterface.h	(-40, +42)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-21, +108)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.h	(-1, +3)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.c	(-16, +59)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +5)	| History	| Source	| Diff

]]> Fri, 13 Sep 2024 10:22:22 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-17053-1 https://devapps.diality.us/cru/HD-DEN-17053-1 Dara Navaei started review HD-DEN-17053-1 ]]> Wed, 28 Aug 2024 08:33:16 -0700 https://devapps.diality.us/cru/HD-DEN-16680-2 https://devapps.diality.us/cru/HD-DEN-16680-2 Sean Nash finished reviewing HD-DEN-16680-2 HD-DEN-16680_P1B Inlet Water Shutdown During Heat Disinfect Staging ]]> Tue, 27 Aug 2024 16:23:58 -0700 https://devapps.diality.us/cru/HD-DEN-16680-2 https://devapps.diality.us/cru/HD-DEN-16680-2 Vinayakam Mani finished reviewing HD-DEN-16680-2 HD-DEN-16680_P1B Inlet Water Shutdown During Heat Disinfect Staging ]]> Tue, 27 Aug 2024 10:05:54 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16680-2/#c19854 https://devapps.diality.us/cru/HD-DEN-16680-2/#c19854 Dara Navaei replied to Sean Nash in HD-DEN-16680-2

Done

Param is wrong.

RESOLVED in CODE WALKTHROUGH.

This is just the active cool mode by itself.

We didn't have this before?

· /firmware/App/Controllers/AirPump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	| History	| Source	| Diff

]]> Tue, 19 Mar 2024 18:13:56 -0700 https://devapps.diality.us/cru/HD-DEN-16773-2 https://devapps.diality.us/cru/HD-DEN-16773-2 Sean Nash and Vinayakam Mani finished reviewing HD-DEN-16773-2 HD-DEN-16773_Add Chemical Disinfect Enable Institutional Record 2 ]]> Tue, 19 Mar 2024 17:26:54 -0700 https://devapps.diality.us/cru/HD-DEN-16773-2 https://devapps.diality.us/cru/HD-DEN-16773-2 Dara Navaei added pvedantam  (deleted user) to HD-DEN-16773-2 HD-DEN-16773_Add Chemical Disinfect Enable Institutional Record 2 ]]> Tue, 19 Mar 2024 17:25:52 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=da8c4c5b6bb51f929119d5efac9739e036339bd6 https://devapps.diality.us/changelog/hdfirmware?cs=da8c4c5b6bb51f929119d5efac9739e036339bd6 Dara Navaei committed da8c4c5 on branch DEN-16773-add-chemical-disinfect-enable-institutional-record-2, DEN-16779-address-cpp-check-warning and 15 more in hdfirmware DEN-16773 added the changes from staging

· /firmware/App/Controllers/AirPump.c	(-44, +6)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-10, +25)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-0, +14)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	| History	| Source	| Diff

]]> Tue, 19 Mar 2024 16:26:22 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-1 https://devapps.diality.us/cru/HD-DEN-16773-1 Dara Navaei Closed HD-DEN-16773-1 ]]> Tue, 19 Mar 2024 16:23:26 -0700 https://devapps.diality.us/cru/HD-DEN-16773-1 https://devapps.diality.us/cru/HD-DEN-16773-1 pvedantam  (deleted user) , Sean Nash and Vinayakam Mani finished reviewing HD-DEN-16773-1 HD-DEN-16773_Add Chemical Disinfect Enable TO The Institutional Record ]]> Tue, 19 Mar 2024 16:11:23 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-2 https://devapps.diality.us/cru/HD-DEN-16773-2 Dara Navaei started review HD-DEN-16773-2 ]]> Tue, 19 Mar 2024 10:03:56 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16773-1/#c19645 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19645 Sean Nash replied to Dara Navaei in HD-DEN-16773-1

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

It's 1 line of code either way. Just on top or below in an else. Vectorcast will see as a branch you need to test either way.
If you put it in an else, the processor does less work and I think it's a lot easier to read.