Fisheye on hdfirmware/firmware/App/Modes/SelfTests.c

hdfirmware (release/p1): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 13 May 2024 13:25:16 -0700

Dara Navaei committed 6081643 on branch DEN-16857-update-alarm-text-reject-reason-for-2-hour-flush-requirement-p1-staging, DEN-17053-release-17-firmware-update and 3 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

HD-DENBUG-249-1: closed by Dara Navaei

Dara Navaei — Mon, 13 May 2024 13:23:09 -0700

Dara Navaei Closed HD-DENBUG-249-1

HD-DENBUG-249-1: reviewers finished

Mon, 13 May 2024 10:13:27 -0700

Vinayakam Mani and Sean Nash finished reviewing HD-DENBUG-249-1

HD-DENBUG-249_Pressure Window Starting Values P1 Staging

hdfirmware (DENBUG-249-pressure-window-starting-values-p1-staging): DENBUG-249, DEN-16857, DEN-16862, DEN-16851 updated the changes from staging

Dara Navaei — Sun, 12 May 2024 15:03:49 -0700

Dara Navaei committed 37dac72 on branch DEN-16857-update-alarm-text-reject-reason-for-2-hour-flush-requirement-p1-staging, DEN-17053-release-17-firmware-update and 4 more in hdfirmware

DENBUG-249, DEN-16857, DEN-16862, DEN-16851 updated the changes from staging

· /firmware/App/Controllers/BloodFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.c	(-11, +244)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PresOccl.h	(-1, +9)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-19, +21)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-0, +16)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +12)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-6, +106)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +10)	\| History	\| Source	\| Diff
· /firmware/HD.dil	(-11, +11)	\| History	\| Source	\| Diff
· /firmware/include/sys_core.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/source/sys_core.asm	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/source/sys_link.cmd	(-4, +4)	\| History	\| Source	\| Diff

HD-DENBUG-249-1: started by Dara Navaei

Dara Navaei — Sun, 12 May 2024 14:38:57 -0700

Dara Navaei started review HD-DENBUG-249-1

HD-DEN-16862-1: closed by Dara Navaei

Dara Navaei — Fri, 10 May 2024 16:32:24 -0700

Dara Navaei Closed HD-DEN-16862-1

HD-DEN-16862-1: reviewers finished

Fri, 10 May 2024 14:51:29 -0700

Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16862-1

HD-DEN-16862_Add A Command TO Reset HD During UI Software Install

HD-DEN-16862-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 08 May 2024 09:58:55 -0700

Sean Nash replied to Dara Navaei in HD-DEN-16862-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16862-1: comment by Dara Navaei "Done"

Dara Navaei — Wed, 08 May 2024 09:02:39 -0700

Dara Navaei replied to Sean Nash in HD-DEN-16862-1

Done

HD-DEN-16862-1: comment by Sean Nash "Disinfect should be higher priority than flush."

Sean Nash — Wed, 08 May 2024 08:44:20 -0700

Sean Nash commented on HD-DEN-16862-1

Disinfect should be higher priority than flush.

HD-DEN-16862-1: started by Dara Navaei

Dara Navaei — Mon, 06 May 2024 09:16:52 -0700

Dara Navaei started review HD-DEN-16862-1

HD-DEN-16779-2: closed by Dara Navaei

Dara Navaei — Wed, 20 Mar 2024 16:55:54 -0700

Dara Navaei Closed HD-DEN-16779-2

HD-DEN-16779-2: reviewers finished

Wed, 20 Mar 2024 16:53:23 -0700

Sean Nash and Vinayakam Mani finished reviewing HD-DEN-16779-2

HD-DEN-16779_Address Cpp Check Warning 2

HD-DEN-16779-2: started by Dara Navaei

Dara Navaei — Wed, 20 Mar 2024 16:45:09 -0700

Dara Navaei started review HD-DEN-16779-2

HD-DEN-16779-1: closed by Dara Navaei

Dara Navaei — Wed, 20 Mar 2024 16:41:09 -0700

Dara Navaei Closed HD-DEN-16779-1

HD-DEN-16779-1: reviewers finished

Wed, 20 Mar 2024 16:40:44 -0700

Sean Nash and Vinayakam Mani finished reviewing HD-DEN-16779-1

HD-DEN-16779_Address Cpp Check Warning

hdfirmware (DEN-16819-In-Treatment-Parameter-mode-no-rejection-seen-when-hep_rate-or-hep_bol-value-is-set-to-less-than-0-p1-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 20 Mar 2024 16:32:50 -0700

Dara Navaei committed 58a0582 on branch DEN-16782-unable-to-clear-communication-error-alarm-65-during-power-loss-2, DEN-16819-In-Treatment-Parameter-mode-no-rejection-seen-when-hep_rate-or-hep_bol-value-is-set-to-less-than-0-p1-staging and 13 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/SelfTests.c

(-1, +1)

| History

| Source

| Diff

HD-DEN-16779-1: reviewers added to HD-DEN-16779_Address Cpp Check Warning

Wed, 20 Mar 2024 15:19:27 -0700

Dara Navaei added pvedantam (deleted user) to HD-DEN-16779-1

HD-DEN-16779_Address Cpp Check Warning

hdfirmware (DEN-16819-In-Treatment-Parameter-mode-no-rejection-seen-when-hep_rate-or-hep_bol-value-is-set-to-less-than-0-p1-staging): DEN-16779 added break at the end of two cases in a switch case in selftests.c

Dara Navaei — Wed, 20 Mar 2024 15:19:04 -0700

Dara Navaei committed 440e805 on branch DEN-16779-address-cpp-check-warning, DEN-16782-unable-to-clear-communication-error-alarm-65-during-power-loss-2 and 14 more in hdfirmware

DEN-16779 added break at the end of two cases in a switch case in selftests.c

· /firmware/App/Modes/SelfTests.c

(-0, +2)

| History

| Source

| Diff

HD-DEN-16779-1: started by Dara Navaei

Dara Navaei — Wed, 20 Mar 2024 15:10:45 -0700

Dara Navaei started review HD-DEN-16779-1

hdfirmware (DEN-16819-In-Treatment-Parameter-mode-no-rejection-seen-when-hep_rate-or-hep_bol-value-is-set-to-less-than-0-p1-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 21 Feb 2024 10:43:59 -0800

Dara Navaei committed de996d8 on branch DEN-16563_2-venous-pressure-readings-were-below-20mmhg-for-1.5-minutes-before-low-venous, DEN-16672-2-air-trap-level-control-changes and 23 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/SelfTests.c

(-2, +2)

| History

| Source

| Diff

HD-DEN-16666-4: closed by Dara Navaei

Dara Navaei — Wed, 21 Feb 2024 10:35:49 -0800

Dara Navaei Closed HD-DEN-16666-4

HD-DEN-16666-4: reviewers finished

Wed, 21 Feb 2024 10:23:05 -0800

Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16666-4

HD-DEN-16666_Log Passing Results OF Self Test 2

hdfirmware (DEN-16819-In-Treatment-Parameter-mode-no-rejection-seen-when-hep_rate-or-hep_bol-value-is-set-to-less-than-0-p1-staging): DEN-16666 added events in the self test

Dara Navaei — Wed, 21 Feb 2024 09:48:57 -0800

Dara Navaei committed dce3d94 on branch DEN-16563_2-venous-pressure-readings-were-below-20mmhg-for-1.5-minutes-before-low-venous, DEN-16666-log-passing-results-of-self-test-2 and 24 more in hdfirmware

DEN-16666 added events in the self test

· /firmware/App/Modes/SelfTests.c

(-0, +4)

| History

| Source

| Diff

HD-DEN-16666-4: started by Dara Navaei

Dara Navaei — Wed, 21 Feb 2024 09:33:12 -0800

Dara Navaei started review HD-DEN-16666-4

HD-DEN-16666-1: closed by Dara Navaei

Dara Navaei — Fri, 09 Feb 2024 13:36:17 -0800

Dara Navaei Closed HD-DEN-16666-1

HD-DEN-16666-1: reviewers finished

Fri, 09 Feb 2024 09:35:17 -0800

Vinayakam Mani finished reviewing HD-DEN-16666-1

HD-DEN-16666_Log Passing Results OF Self Test TO UI Log

HD-DEN-16666-1: reviewers finished

Thu, 08 Feb 2024 13:44:34 -0800

Sean Nash finished reviewing HD-DEN-16666-1

HD-DEN-16666_Log Passing Results OF Self Test TO UI Log

HD-DEN-16666-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 08 Feb 2024 13:44:18 -0800

Sean Nash replied to Dara Navaei in HD-DEN-16666-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16666-1: comment by Sean Nash "Should this be moved down inside if. Also, ala..."

Sean Nash — Thu, 08 Feb 2024 13:34:45 -0800

Sean Nash commented on HD-DEN-16666-1

Should this be moved down inside if. Also, alarm below logs diffs. Why are we logging pressures?