Fisheye on application/sources/view/dg/data/VDGTemperaturesData.cpp

UI-DEN-SUNRISE-1: closed by Dara Navaei

Dara Navaei — Fri, 15 Nov 2024 12:54:28 -0800

Dara Navaei Closed UI-DEN-SUNRISE-1

UI-DEN-SUNRISE-1: reviewers removed from UI-DEN-SUNRISE

Fri, 07 Jun 2024 09:05:01 -0700

Dara Navaei removed Sean Nash and vduong (deleted user) from UI-DEN-SUNRISE-1

UI-DEN-SUNRISE

UI-DEN-SUNRISE-1: started by Dara Navaei

Dara Navaei — Fri, 07 Jun 2024 09:04:34 -0700

Dara Navaei started review UI-DEN-SUNRISE-1

UI-DEN-16647-5: closed by Behrouz NematiPour

Behrouz NematiPour — Fri, 09 Feb 2024 15:54:41 -0800

Behrouz NematiPour Closed UI-DEN-16647-5

UI-DEN-16647-5: reviewers finished

Fri, 09 Feb 2024 15:53:43 -0800

Tiffany Mejia and Dara Navaei finished reviewing UI-DEN-16647-5

UI-DEN-16647-release/stagingmerge-DEN-16647-UI-BN-S115-R11 - application

UI-DEN-16647-5: reviewers added to UI-DEN-16647-release/stagingmerge-DEN-16647-UI-BN-...

Fri, 09 Feb 2024 15:43:38 -0800

Behrouz NematiPour added msuleiman (deleted user) to UI-DEN-16647-5

UI-DEN-16647-release/stagingmerge-DEN-16647-UI-BN-S115-R11 - application

UI-DEN-16647-5: started by Dara Navaei

Dara Navaei — Fri, 09 Feb 2024 15:34:27 -0800

Dara Navaei started review UI-DEN-16647-5

UI-DEN-16658-9: closed by Dara Navaei

Dara Navaei — Fri, 09 Feb 2024 13:16:12 -0800

Dara Navaei Closed UI-DEN-16658-9

application (DEN-16553-UI-BN-WPA3-Support): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 09 Feb 2024 11:00:51 -0800

Dara Navaei committed f724589 on branch master, @Environement_Swith and 59 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /main.cpp	(-2, +2)	\| History	\| Source	\| Diff
· /sources/canbus/MessageGlobals.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/device/DeviceController.cpp	(-2, +2)	\| History	\| Source	\| Diff
· /sources/gui/qml/dialogs/DiagnosticsDialog.qml	(-2, +2)	\| History	\| Source	\| Diff
· /sources/main.h	(-2, +2)	\| History	\| Source	\| Diff
· /sources/model/dg/data/MDGTemperaturesData.cpp	(-2, +2)	\| History	\| Source	\| Diff
· /sources/model/dg/data/MDGTemperaturesData.h	(-2, +2)	\| History	\| Source	\| Diff
· /sources/model/hd/alarm/MAlarmMapping.cpp	(-20, +14)	\| History	\| Source	\| Diff
· /sources/storage/FileHandler.cpp	(-2, +2)	\| History	\| Source	\| Diff
· /sources/storage/Logger.cpp	(-2, +2)	\| History	\| Source	\| Diff
· /sources/storage/StorageGlobals.cpp	(-2, +2)	\| History	\| Source	\| Diff
· /sources/storage/StorageGlobals.h	(-2, +2)	\| History	\| Source	\| Diff
· /sources/utility/types.h	(-2, +2)	\| History	\| Source	\| Diff
· /sources/view/dg/data/VDGTemperaturesData.cpp	(-2, +2)	\| History	\| Source	\| Diff
· /sources/view/dg/data/VDGTemperaturesData.h	(-2, +2)	\| History	\| Source	\| Diff
· /unittests/tst_utilities.cpp	(-2, +2)	\| History	\| Source	\| Diff
· /unittests/tst_utilities.h	(-2, +2)	\| History	\| Source	\| Diff

UI-DEN-16658-9: reviewers finished

Thu, 08 Feb 2024 13:30:03 -0800

Sean Nash , msuleiman (deleted user) and Behrouz NematiPour finished reviewing UI-DEN-16658-9

UI-DEN-16658_UI DN S116 Sonar Fix Msg Update

UI-DEN-16658-9: reviewers added to UI-DEN-16658_UI DN S116 Sonar Fix Msg Update

Thu, 08 Feb 2024 13:00:41 -0800

Dara Navaei added msuleiman (deleted user) to UI-DEN-16658-9

UI-DEN-16658_UI DN S116 Sonar Fix Msg Update

UI-DEN-16658-9: reviewers removed from UI-DEN-16658_UI DN S116 Sonar Fix Msg Update

Thu, 08 Feb 2024 13:00:19 -0800

Dara Navaei removed msuleiman (deleted user) from UI-DEN-16658-9

UI-DEN-16658_UI DN S116 Sonar Fix Msg Update

UI-DEN-16658-9: reviewers added to UI-DEN-16658_UI DN S116 Sonar Fix Msg Update

Thu, 08 Feb 2024 13:00:15 -0800

Behrouz NematiPour added msuleiman (deleted user) to UI-DEN-16658-9

UI-DEN-16658_UI DN S116 Sonar Fix Msg Update

UI-DEN-16658-9: started by Dara Navaei

Dara Navaei — Thu, 08 Feb 2024 12:56:37 -0800

Dara Navaei started review UI-DEN-16658-9

application (DEN-16553-UI-BN-WPA3-Support): DEN-16444: UI: UI Logs do not Capture TDi and TRo Moving Average Values...

Dara Navaei — Mon, 05 Feb 2024 09:55:37 -0800

Dara Navaei committed a4a9cb3 on branch master, @Environement_Swith and 60 more in application

DEN-16444: UI: UI Logs do not Capture TDi and TRo Moving Average Values

Updated the application to incorporate the two new float values in the DG temperature sensors payload.

· /sources/canbus/MessageGlobals.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/dialogs/DiagnosticsDialog.qml	(-0, +6)	\| History	\| Source	\| Diff
· /sources/model/dg/data/MDGTemperaturesData.cpp	(-0, +8)	\| History	\| Source	\| Diff
· /sources/model/dg/data/MDGTemperaturesData.h	(-0, +6)	\| History	\| Source	\| Diff
· /sources/model/hd/alarm/MAlarmMapping.cpp	(-1, +1)	\| History	\| Source	\| Diff
· /sources/view/dg/data/VDGTemperaturesData.cpp	(-0, +2)	\| History	\| Source	\| Diff
· /sources/view/dg/data/VDGTemperaturesData.h	(-0, +2)	\| History	\| Source	\| Diff

application (DEN-16553-UI-BN-WPA3-Support): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 24 Jan 2024 14:28:27 -0800

Dara Navaei committed 2ef03b2 on branch master, @Environement_Swith and 61 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /alarmMapping.sh

(-1, +1)

| History

| Source

| Diff

· /cho.sh

(-1, +1)

| History

| Source

| Diff

· /cppcheck.sh

(-1, +1)

| History

| Source

| Diff

· /cr_objectives.sh

(-1, +1)

| History

| Source

| Diff

· /imake.sh

(-1, +1)

| History

| Source

| Diff

· /main.cpp

(-2, +2)

| History

| Source

| Diff

· /remove-exra-emptylines.sh

(-1, +1)

| History

| Source

| Diff

· /sources/AlarmGenerator.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/AlarmGenerator.h

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationController.cpp

(-2, +2)

| History

| Source

| Diff

· /sources/ApplicationController.h

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationPost.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationPost.h

(-1, +1)

| History

| Source

| Diff

· /sources/MainTimer.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/MainTimer.h

(-1, +1)

| History

| Source

| Diff

… 598 more files in changeset.

UI-UCOMMITS-3: closed by Sean Nash

Sean Nash — Thu, 03 Aug 2023 14:23:52 -0700

Sean Nash Closed UI-UCOMMITS-3

UI-UCOMMITS-3: reviewers finished

Thu, 03 Aug 2023 14:05:13 -0700

Dara Navaei finished reviewing UI-UCOMMITS-3

UI Staging Unreviewed Commits

UI-UCOMMITS-3: reviewers finished

Wed, 02 Aug 2023 09:33:38 -0700

Sean Nash finished reviewing UI-UCOMMITS-3

UI Staging Unreviewed Commits

UI-UCOMMITS-3: started by Dara Navaei

Dara Navaei — Mon, 08 May 2023 08:49:03 -0700

Dara Navaei started review UI-UCOMMITS-3

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 10 Feb 2023 10:12:20 -0800

Dara Navaei committed af8d98b on branch master, @Environement_Swith and 176 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /cppcheck.sh

(-1, +1)

| History

| Source

| Diff

· /imake.sh

(-1, +1)

| History

| Source

| Diff

· /main.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/CanInterface.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/FrameInterface.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageAcknowModel.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageGlobals.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageInterpreter.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/cloudsync/CloudSyncController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/cloudsync/CloudSyncController.h

(-1, +1)

| History

| Source

| Diff

· /sources/device/DeviceController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/gui/GuiController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/gui/GuiView.h

(-1, +1)

| History

| Source

| Diff

· /sources/gui/qml/PowerItem.qml

(-1, +1)

| History

| Source

| Diff

· /sources/gui/qml/components/DebugDataColumn.qml

(-1, +1)

| History

| Source

| Diff

… 36 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): Merge branch 'DEN-14733-UI-BN-S90-2' into staging

Behrouz NematiPour — Fri, 10 Feb 2023 09:51:39 -0800

Behrouz NematiPour committed 1f2e7db on branch master, @Environement_Swith and 176 more in application

Merge branch 'DEN-14733-UI-BN-S90-2' into staging

· /AlarmMapping.csv

(-2, +3)

| History

| Source

| Diff

· /cppcheck.err

(-39, +1221)

| History

| Source

| Diff

· /cppcheck.log

(-69, +271)

| History

| Source

| Diff

· /denali.pro.user

(-118, +66)

| History

| Source

| Diff

· /en_US.udic

(-0, +1)

| History

| Source

| Diff

· /imake.sh

(-6, +0)

| History

| Source

| Diff

· /main.cpp

(-0, +31)

| History

| Source

| Diff

· /sources/canbus/CanInterface.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageGlobals.h

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/MessageInterpreter.cpp

(-5, +5)

| History

| Source

| Diff

· /sources/device/DeviceController.cpp

(-1, +6)

| History

| Source

| Diff

· /sources/gui/GuiController.cpp

(-11, +2)

| History

| Source

| Diff

· /sources/gui/GuiView.h

(-0, +3)

| History

| Source

| Diff

· /sources/gui/qml/PowerItem.qml

(-4, +1)

| History

| Source

| Diff

· /sources/gui/qml/components/DebugDataColumn.qml

(-3, +3)

| History

| Source

| Diff

… 29 more files in changeset.

UI-DEN-14733-2: closed by Behrouz NematiPour

Behrouz NematiPour — Fri, 10 Feb 2023 09:23:58 -0800

Behrouz NematiPour Closed UI-DEN-14733-2

UI-DEN-14733-2: reviewers finished

Fri, 10 Feb 2023 09:20:34 -0800

Sean Nash and vduong (deleted user) finished reviewing UI-DEN-14733-2

UI-DEN-14733_UI BN S90

UI-DEN-14733-2: comment by vduong "Yes, assignments break bindings. RESOLVED"

vduong — Fri, 10 Feb 2023 09:18:39 -0800

vduong (deleted user) replied to Behrouz NematiPour in UI-DEN-14733-2

Yes, assignments break bindings.

RESOLVED

UI-DEN-14733-2: comment by Behrouz NematiPour "Good point, But you can't. The readonly prope..."

Behrouz NematiPour — Fri, 10 Feb 2023 08:19:32 -0800

Behrouz NematiPour replied to vduong (deleted user) in UI-DEN-14733-2

Good point,
But you can't.
The readonly properties are only working with bindings, not assignments.
I am using that as a public variable.

UI-DEN-14733-2: comment by vduong "If _root.isOpen is not modified outside of this..."

vduong — Fri, 10 Feb 2023 08:04:45 -0800

vduong (deleted user) commented on UI-DEN-14733-2

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

UI-DEN-14733-2: reviewers resumed

Thu, 09 Feb 2023 16:39:31 -0800

jishii (deleted user) resumed reviewing UI-DEN-14733-2

UI-DEN-14733_UI BN S90

UI-DEN-14733-2: comment by Sean Nash "So we will likely remove this TODO and comment ..."

Sean Nash — Thu, 09 Feb 2023 11:08:38 -0800

Sean Nash replied to Behrouz NematiPour in UI-DEN-14733-2

So we will likely remove this TODO and comment later?
RESOLVED.

UI-DEN-14733-2: comment by Sean Nash "RESOLVED."

Sean Nash — Thu, 09 Feb 2023 11:06:37 -0800

Sean Nash replied to Behrouz NematiPour in UI-DEN-14733-2

RESOLVED.