UI-DEN-14733-2 UI-DEN-14733_UI BN S90

closed on 10 Feb 23

Author

Moderator

Reviewers

Sean Nash
Dara Navaei
vduong (deleted user)
jreaume (deleted user)

UI-DEN-14733_UI BN S90

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 43

application 0
- Folder sources 0
  - Folder canbus 0
    - File CanInterface.h 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 0 Remove
  - Folder device 0
    - File DeviceController.cpp 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File DebugDataColumn.qml 0 Remove
        
        File Slider.qml 0 Remove
      - Folder dialogs 0
        
        File DiagnosticsDialog.qml 0 Remove
      - Folder pages 0
        
        Folder treatment 0
        
        File TreatmentStack.qml 2 Remove
        
        File MainStack.qml 0 Remove
      - File PowerItem.qml 3 Remove
      - File main.qml 0 Remove
    - File GuiController.cpp 3 Remove
    - File GuiView.h 0 Remove
  - Folder model 0
    - Folder dg/data 0
      - File MDGHeatersData.cpp 0 Remove
      - File MDGHeatersData.h 0 Remove
      - File MDGPressuresData.cpp 0 Remove
      - File MDGPressuresData.h 0 Remove
      - File MDGTemperaturesData.cpp 0 Remove
      - File MDGTemperaturesData.h 0 Remove
    - Folder hd 0
      - Folder alarm 0
        
        File MAlarmMapping.cpp 0 Remove
      - Folder data/pretreatment 0
        
        File MPreTreatmentStatesData.cpp 0 Remove
        
        File MPreTreatmentStatesData.h 0 Remove
  - Folder storage 0
    - File Logger.h 0 Remove
  - Folder view 0
    - Folder dg/data 0
      - File VDGHeatersData.cpp 0 Remove
      - File VDGHeatersData.h 0 Remove
      - File VDGPressuresData.cpp 0 Remove
      - File VDGPressuresData.h 0 Remove
      - File VDGTemperaturesData.cpp 0 Remove
      - File VDGTemperaturesData.h 0 Remove
    - Folder hd 0
      - Folder alarm 0
        
        File VAlarmActiveList.cpp 0 Remove
        
        File VAlarmActiveList.h 0 Remove
        
        File VAlarmStatus.cpp 0 Remove
        
        File VAlarmStatus.h 0 Remove
      - Folder data/pretreatment 0
        
        File VPreTreatmentStatesData.cpp 0 Remove
        
        File VPreTreatmentStatesData.h 0 Remove
  - File main.h 0 Remove
- Folder unittests 0
  - File tst_models.cpp 0 Remove
- File AlarmMapping.csv 0 Remove
- File cppcheck.err 0 Remove
- File cppcheck.log 0 Remove
- File denali.pro.user 0 Remove
- File en_US.udic 3 Remove
- File main.cpp 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author & Moderator	32m	3	Good point, But you can't. The readonly properties are on...
Michael Garthwaite	Reviewer - 21% reviewed	10m	2	RESOLVED.
Tiffany Mejia	Reviewer - 0% reviewed
jishii (deleted user)	Reviewer - 47% reviewed	9m
Sean Nash	Reviewer - Complete	30m	4	So we will likely remove this TODO and comment later? RES...
Dara Navaei	Reviewer - 0% reviewed	1m
vduong (deleted user)	Reviewer - Complete	17m	2	Yes, assignments break bindings. RESOLVED
jreaume (deleted user)	Reviewer - 0% reviewed
Total		1h 41m	11

#permalink

Objectives

commit : e5bfc98f - DEN-14736 : IMP: Dry-Demo Support

added the CLI switch -D : --enable-dry-demo
added the CLI switch -A : --active-can-bus <CANBus>
added the CLI switch -F : --disable-fault-screen
will send confirmation response with ConfirmationID of 99 and as accepted(1):
e.g. 03:32:29.560,bb00,UI,Confirm,99,1

-------------------------------------------------------------------------------------------------
commit : bae9ba50 - DEN-14736 : IMP: DEN-14779: In-Tx Qb, Qd, PBo, PBA Adj

-------------------------------------------------------------------------------------------------
commit : 74e27f26 - DEN-14736 : IMP: Secured the SD-Card mount

added security recommended USB mount flags
MS_SYNCHRONOUS
MS_NOEXEC
MS_NODEV
MS_NOSUID

-------------------------------------------------------------------------------------------------
commit : f4b8d033 - DEN-14736 : IMP: Removed the SD-Card alarm dialog

it is not clear what needs to be done when SD-Card fails after a successful POST.
May need to send an alarmTrigger to HD and stop logging.
Removed for now.

-------------------------------------------------------------------------------------------------
commit : 86947a85 - DEN-14736 : IMP: Shutdown dialog / Alarm Dialog

The shutdown dialog closure was not maximizing the minimized alarm dialog

-------------------------------------------------------------------------------------------------
commit : 27745bad - DEN-14736 : IMP: DEN-14779: In-Tx Qb, Qd, PBo, PBA Adj

-------------------------------------------------------------------------------------------------
commit : 52b9edb8 - DEN-14736 : IMP: Unhandled Msg ID log

Added the messaged Id to the Unhandled messages log

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-14733-2

UI-DEN-14733_UI BN S90

UI-DEN-14733-2 11

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-14733_UI BN S90

UI-DEN-14733-2 11

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time