Fisheye on application/resources/images/Logo Diality.png https://devapps.diality.us/changelog/~br%3DDEN-2554_CodeStructureReview/application/resources/images/Logo%20Diality.png Recent activity in "application" under directory /resources/images/Logo Diality.png UI-DEN-14294-1: closed by Behrouz NematiPour Tue, 31 Jan 2023 23:54:33 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-14294-1 https://devapps.diality.us/cru/UI-DEN-14294-1 Behrouz NematiPour Closed UI-DEN-14294-1 ]]> UI-DEN-14294-1: reviewers finished Wed, 11 Jan 2023 08:28:01 -0800 https://devapps.diality.us/cru/UI-DEN-14294-1 https://devapps.diality.us/cru/UI-DEN-14294-1 Tiffany Mejia and jishii  (deleted user) finished reviewing UI-DEN-14294-1 UI-DEN-14294_UI BN S84 ]]> UI-DEN-14294-1: reviewers resumed Tue, 10 Jan 2023 21:25:41 -0800 https://devapps.diality.us/cru/UI-DEN-14294-1 https://devapps.diality.us/cru/UI-DEN-14294-1 Michael Garthwaite and Sean Nash resumed reviewing UI-DEN-14294-1 UI-DEN-14294_UI BN S84 ]]> UI-DEN-14294-1: comment by Michael Garthwaite "RESOLVED" Wed, 21 Dec 2022 15:03:47 -0800 Michael Garthwaite https://devapps.diality.us/cru/UI-DEN-14294-1/#c15712 https://devapps.diality.us/cru/UI-DEN-14294-1/#c15712 Michael Garthwaite replied to Behrouz NematiPour in UI-DEN-14294-1

RESOLVED

]]> UI-DEN-14294-1: comment by Sean Nash "RESOLVED." Tue, 20 Dec 2022 14:05:45 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-14294-1/#c15497 https://devapps.diality.us/cru/UI-DEN-14294-1/#c15497 Sean Nash replied to Behrouz NematiPour in UI-DEN-14294-1

RESOLVED.

]]> UI-DEN-14294-1: comment by Behrouz NematiPour "Fixed the indentation" Tue, 20 Dec 2022 13:47:30 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-14294-1/#c15481 https://devapps.diality.us/cru/UI-DEN-14294-1/#c15481 Behrouz NematiPour replied to Sean Nash in UI-DEN-14294-1

Fixed the indentation

]]> UI-DEN-14294-1: comment by Sean Nash "I don't see ending bracket for this if. Does t..." Tue, 20 Dec 2022 08:33:58 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-14294-1/#c15404 https://devapps.diality.us/cru/UI-DEN-14294-1/#c15404 Sean Nash commented on UI-DEN-14294-1

I don't see ending bracket for this if. Does this even build?

]]> UI-DEN-14294-1: comment by Sean Nash "RESOLVED." Tue, 20 Dec 2022 08:30:13 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-14294-1/#c15403 https://devapps.diality.us/cru/UI-DEN-14294-1/#c15403 Sean Nash replied to Sean Nash in UI-DEN-14294-1

RESOLVED.

]]> UI-DEN-14294-1: comment by Sean Nash "RESOLVED." Tue, 20 Dec 2022 08:29:42 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-14294-1/#c15402 https://devapps.diality.us/cru/UI-DEN-14294-1/#c15402 Sean Nash replied to Sean Nash in UI-DEN-14294-1

RESOLVED.

]]> UI-DEN-14294-1: comment by Sean Nash "RESOLVED." Mon, 19 Dec 2022 17:02:27 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-14294-1/#c15356 https://devapps.diality.us/cru/UI-DEN-14294-1/#c15356 Sean Nash replied to Behrouz NematiPour in UI-DEN-14294-1

RESOLVED.

]]> UI-DEN-14294-1: comment by Behrouz NematiPour "Seems like as part of modern C++ the equal oper..." Mon, 19 Dec 2022 16:18:12 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-14294-1/#c15320 https://devapps.diality.us/cru/UI-DEN-14294-1/#c15320 Behrouz NematiPour replied to Sean Nash in UI-DEN-14294-1

Seems like as part of modern C++ the equal operator is no longer needed.
I need to investigate more to completely remove it.

]]> UI-DEN-14294-1: comment by Behrouz NematiPour "This function is a slot to debug the behavior o..." Mon, 19 Dec 2022 16:13:51 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-14294-1/#c15314 https://devapps.diality.us/cru/UI-DEN-14294-1/#c15314 Behrouz NematiPour replied to Michael Garthwaite in UI-DEN-14294-1

This function is a slot to debug the behavior of the power dialog for now
The entire qml file may later be removed.
We had some conversations to combine the power message into confirmation and remove the power qml, models, and so on.

]]> UI-DEN-14294-1: comment by Michael Garthwaite "The body of this function looks all commented o..." Mon, 19 Dec 2022 15:23:13 -0800 Michael Garthwaite https://devapps.diality.us/cru/UI-DEN-14294-1/#c15283 https://devapps.diality.us/cru/UI-DEN-14294-1/#c15283 Michael Garthwaite commented on UI-DEN-14294-1

The body of this function looks all commented out. Is this function necessary?

]]> UI-DEN-14294-1: comment by Sean Nash "Why commented out?" Mon, 19 Dec 2022 13:54:24 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-14294-1/#c15263 https://devapps.diality.us/cru/UI-DEN-14294-1/#c15263 Sean Nash commented on UI-DEN-14294-1

Why commented out?

]]> UI-DEN-14294-1: comment by Sean Nash "Align function bodies." Mon, 19 Dec 2022 13:47:09 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-14294-1/#c15256 https://devapps.diality.us/cru/UI-DEN-14294-1/#c15256 Sean Nash commented on UI-DEN-14294-1

Align function bodies.

]]> UI-DEN-14294-1: comment by Sean Nash "Align "="." Mon, 19 Dec 2022 13:34:55 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-14294-1/#c15252 https://devapps.diality.us/cru/UI-DEN-14294-1/#c15252 Sean Nash commented on UI-DEN-14294-1

Align "=".

]]> UI-DEN-14294-1: started by Dara Navaei Fri, 16 Dec 2022 18:18:44 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-14294-1 https://devapps.diality.us/cru/UI-DEN-14294-1 Dara Navaei started review UI-DEN-14294-1 ]]> UI-DEN-626-1: closed by Dara Navaei Sat, 07 Dec 2019 11:49:30 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 Dara Navaei Closed UI-DEN-626-1 ]]> UI-DEN-626-1: reviewers finished Sat, 07 Dec 2019 11:37:35 -0800 https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 Dara Navaei finished reviewing UI-DEN-626-1 UI-DEN-626_UI Power Off Screen ]]> UI-DEN-626-1: reviewers finished Thu, 05 Dec 2019 10:02:56 -0800 https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 pmontazemi  (deleted user) finished reviewing UI-DEN-626-1 UI-DEN-626_UI Power Off Screen ]]> UI-DEN-626-1: reviewers finished Wed, 04 Dec 2019 08:52:51 -0800 https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 lbaloa  (deleted user) finished reviewing UI-DEN-626-1 UI-DEN-626_UI Power Off Screen ]]> UI-DEN-626-1: comment by lbaloa "RESOLVED" Wed, 04 Dec 2019 08:51:51 -0800 lbaloa https://devapps.diality.us/cru/UI-DEN-626-1/#c450 https://devapps.diality.us/cru/UI-DEN-626-1/#c450 lbaloa  (deleted user) replied to lbaloa  (deleted user) in UI-DEN-626-1

RESOLVED

]]> UI-DEN-626-1: comment by pmontazemi "Leo, Resolving the case in not enough, you a..." Fri, 01 Nov 2019 15:34:17 -0700 pmontazemi https://devapps.diality.us/cru/UI-DEN-626-1/#c187 https://devapps.diality.us/cru/UI-DEN-626-1/#c187 pmontazemi  (deleted user) replied to lbaloa  (deleted user) in UI-DEN-626-1

Leo,

Resolving the case in not enough, you also need to reply to Behrouz's last comment and mention the word "RESOLVED", otherwise, Dara's Crucible script won't pick this code review up. We will review this next week during the training.

]]> UI-DEN-626-1: comment by Behrouz NematiPour "seems like when I replied the emails were not w..." Mon, 28 Oct 2019 17:47:58 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-626-1/#c169 https://devapps.diality.us/cru/UI-DEN-626-1/#c169 Behrouz NematiPour replied to lbaloa  (deleted user) in UI-DEN-626-1

seems like when I replied the emails were not working
Just as a reminder.

]]> UI-DEN-626-1: reviewers joined UI-DEN-626_UI Power Off Screen Mon, 28 Oct 2019 16:30:23 -0700 https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 Dara Navaei joined UI-DEN-626-1 UI-DEN-626_UI Power Off Screen ]]> UI-DEN-626-1: comment by Behrouz NematiPour "Thanks for the comment. static class member ..." Thu, 24 Oct 2019 10:46:41 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-626-1/#c124 https://devapps.diality.us/cru/UI-DEN-626-1/#c124 Behrouz NematiPour replied to lbaloa  (deleted user) in UI-DEN-626-1

Thanks for the comment.

static class member variable can not be initialized in header.
Please take a look at the applicationcontroller.cpp@21.
It has been initialized with nullptr.

Note : To see the whole file content on the top right click on the "View" menu and select "Full Context"

]]> UI-DEN-626-1: comment by lbaloa "initialize with nullptr for consistency" Thu, 24 Oct 2019 09:14:52 -0700 lbaloa https://devapps.diality.us/cru/UI-DEN-626-1/#c123 https://devapps.diality.us/cru/UI-DEN-626-1/#c123 lbaloa  (deleted user) commented on UI-DEN-626-1

initialize with nullptr for consistency

]]> UI-DEN-626-1: started by Behrouz NematiPour Tue, 22 Oct 2019 18:21:54 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 Behrouz NematiPour started review UI-DEN-626-1 ]]>