UI-DEN-14294-1 UI-DEN-14294_UI BN S84

closed on 31 Jan 23

Author

Moderator

Reviewers

UI-DEN-14294_UI BN S84

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 81

application 0
- Folder resources/images 0
  - File AlarmBell.png 0 Remove
  - File AlarmBellSilent.png 0 Remove
  - File Busy2.png 0 Remove
  - File Done.png 0 Remove
  - File Logo Diality.png 0 Remove
  - File Logo DialityT.png 0 Remove
  - File Logo Qt 1024px_old.png 0 Remove
  - File Logo d-blue.png 0 Remove
  - File OffGray.png 0 Remove
  - File Power_symbol-128.png 0 Remove
  - File Settings_gear_setting_tools-128.png 0 Remove
  - File alarm.png 0 Remove
  - File audio.png 0 Remove
  - File bell-off.png 0 Remove
  - File bell-on.png 0 Remove
  - File bell.png 0 Remove
  - File checkCircle.png 0 Remove
  - File doted-list.png 0 Remove
  - File mute.png 0 Remove
- Folder scripts 0
  - File autostart 0 Remove
  - File globals.sh 0 Remove
  - File run.sh 0 Remove
  - File setup.sh 0 Remove
  - File start.sh 0 Remove
- Folder sources 0
  - Folder bluetooth 0
    - File BluetoothInterface.cpp 0 Remove
  - Folder canbus 0
    - File MessageInterpreter.cpp 0 Remove
  - Folder cloudsync 0
    - File CloudSyncController.cpp 3 Remove
    - File CloudSyncController.h 0 Remove
  - Folder device 0
    - File DeviceController.cpp 0 Remove
    - File DeviceController.h 2 Remove
  - Folder gui/qml 0
    - Folder components 0
      - File RangeSlider.qml 0 Remove
    - Folder dialogs 0
      - File DiagnosticsDialog.qml 0 Remove
    - Folder pages 0
      - Folder disinfect 0
        
        File DisinfectStack.qml 0 Remove
      - Folder endtreatment 0
        
        File EndTreatmentEndStack.qml 0 Remove
        
        File EndTreatmentRecirculateStack.qml 0 Remove
        
        File EndTreatmentRinsebackStack.qml 0 Remove
      - Folder posttreatment 0
        
        File PostTreatmentStack.qml 0 Remove
      - Folder pretreatment 0
        
        Folder connection 0
        
        File PreTreatmentConnectionStack.qml 0 Remove
        
        Folder create 0
        
        File PreTreatmentCreateStack.qml 0 Remove
        
        File PreTreatmentConsumablesStack.qml 0 Remove
        
        File PreTreatmentDisposablesStack.qml 0 Remove
        
        File PreTreatmentPrimeStack.qml 0 Remove
        
        File PreTreatmentStack.qml 0 Remove
        
        File PreTreatmentWaterSampleStack.qml 0 Remove
      - Folder settings 0
        
        File SettingsBluetoothCuff.qml 0 Remove
        
        File SettingsDG.qml 0 Remove
        
        File SettingsExportLogs.qml 2 Remove
        
        File SettingsStack.qml 0 Remove
        
        File SettingsVolumeBrightness.qml 0 Remove
      - Folder treatment 0
        
        Folder adjustments 0
        
        File TreatmentAdjustmentFlow.qml 0 Remove
        
        Folder sections 0
        
        File TreatmentHeparin.qml 0 Remove
        
        File TreatmentStack.qml 0 Remove
        
        File TreatmentUltrafiltrationItem.qml 0 Remove
      - File MainStack.qml 0 Remove
      - File TreatmentFlowBase.qml 0 Remove
    - File AlarmItem.qml 0 Remove
    - File Comments.qml.notes 0 Remove
    - File PowerItem.qml 3 Remove
    - File main.qml 0 Remove
  - Folder model 0
    - Folder dg/adjustment/settings 0
      - File MAdjustDGSerialNumberResponse.cpp 0 Remove
      - File MAdjustDGSerialNumberResponse.h 0 Remove
    - Folder hd 0
      - Folder adjustment/settings 0
        
        File MAdjustHDSerialNumberResponse.cpp 0 Remove
        
        File MAdjustHDSerialNumberResponse.h 0 Remove
      - Folder alarm 0
        
        File MAlarmMapping.cpp 0 Remove
    - Folder settings 0
      - File MSettings.h 3 Remove
  - Folder storage 0
    - File FileHandler.cpp 0 Remove
  - Folder utility 0
    - File format.cpp 0 Remove
    - File types.h 0 Remove
  - Folder view/settings 0
    - File VNetworkModel.cpp 0 Remove
    - File VSettings.cpp 0 Remove
  - Folder wifi 0
    - File WifiInterface.cpp 0 Remove
  - File ApplicationController.cpp 0 Remove
  - File ApplicationController.h 0 Remove
  - File main.h 0 Remove
- File .gitignore 0 Remove
- File AlarmMapping.csv 0 Remove
- File cppcheck.log 0 Remove
- File cppcheck.sh 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author & Moderator	50m	3	Fixed the indentation
Sean Nash	Reviewer - 97% reviewed	36m	8	RESOLVED.
Dara Navaei	Reviewer - 0% reviewed	0m
Michael Garthwaite	Reviewer - 97% reviewed	29m	2	RESOLVED
jishii (deleted user)	Reviewer - Complete	31m
Tiffany Mejia	Reviewer - Complete	14m
Total		2h 43m	13

#permalink

Objectives

These Code review comments have been addressed and the branch has been already merged into develop and staging.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/resources/images/Logo Qt 1024px_old.png Deleted

Click to load diff

/resources/images/Settings_gear_setting_tools-128.png Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-14294-1

UI-DEN-14294_UI BN S84

UI-DEN-14294-1 13

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-14294_UI BN S84

UI-DEN-14294-1 13

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time