Fisheye on application/unittests/tst_canbus.h https://devapps.diality.us/changelog/~br%3DDEN-2554_CodeStructureReview/application/unittests/tst_canbus.h Recent activity in "application" under directory /unittests/tst_canbus.h UI-LEAH-1864-2: closed by Behrouz NematiPour Tue, 19 Nov 2024 15:15:32 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-LEAH-1864-2 https://devapps.diality.us/cru/UI-LEAH-1864-2 Behrouz NematiPour Closed UI-LEAH-1864-2 ]]> UI-LEAH-1864-2: reviewers finished Tue, 19 Nov 2024 14:11:56 -0800 https://devapps.diality.us/cru/UI-LEAH-1864-2 https://devapps.diality.us/cru/UI-LEAH-1864-2 Dara Navaei and amanesh  (deleted user) finished reviewing UI-LEAH-1864-2 UI-LEAH-1864_Leahi/Features/Leah 1864 Boardbringup ]]> UI-LEAH-1864-2: reviewers added to UI-LEAH-1864_Leahi/Features/Leah 1864 Boardbringup Tue, 19 Nov 2024 13:56:01 -0800 https://devapps.diality.us/cru/UI-LEAH-1864-2 https://devapps.diality.us/cru/UI-LEAH-1864-2 Behrouz NematiPour added amanesh  (deleted user) to UI-LEAH-1864-2 UI-LEAH-1864_Leahi/Features/Leah 1864 Boardbringup ]]> UI-LEAH-1864-2: started by Dara Navaei Mon, 18 Nov 2024 11:38:41 -0800 Dara Navaei https://devapps.diality.us/cru/UI-LEAH-1864-2 https://devapps.diality.us/cru/UI-LEAH-1864-2 Dara Navaei started review UI-LEAH-1864-2 ]]> UI-DEN-3149-1: closed by Dara Navaei Thu, 19 Oct 2023 10:54:15 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-3149-1 https://devapps.diality.us/cru/UI-DEN-3149-1 Dara Navaei Closed UI-DEN-3149-1 ]]> UI-DEN-3149-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:53:53 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-3149-1/#c19164 https://devapps.diality.us/cru/UI-DEN-3149-1/#c19164 Dara Navaei replied to Behrouz NematiPour in UI-DEN-3149-1

RESOLVED

]]> UI-DEN-3149-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:52:35 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-3149-1/#c19163 https://devapps.diality.us/cru/UI-DEN-3149-1/#c19163 Dara Navaei replied to plucia  (deleted user) in UI-DEN-3149-1

RESOLVED

]]> UI-DEN-3149-1: started by Dara Navaei Thu, 19 Oct 2023 10:51:58 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-3149-1 https://devapps.diality.us/cru/UI-DEN-3149-1 Dara Navaei started review UI-DEN-3149-1 ]]> UI-UCOMMITS-3: closed by Sean Nash Thu, 03 Aug 2023 14:23:52 -0700 Sean Nash https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Sean Nash Closed UI-UCOMMITS-3 ]]> UI-UCOMMITS-3: reviewers finished Thu, 03 Aug 2023 14:05:13 -0700 https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Dara Navaei finished reviewing UI-UCOMMITS-3 UI Staging Unreviewed Commits ]]> UI-UCOMMITS-3: reviewers finished Wed, 02 Aug 2023 09:33:38 -0700 https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Sean Nash finished reviewing UI-UCOMMITS-3 UI Staging Unreviewed Commits ]]> UI-UCOMMITS-3: started by Dara Navaei Mon, 08 May 2023 08:49:03 -0700 Dara Navaei https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Dara Navaei started review UI-UCOMMITS-3 ]]> UI-DEN-5830-2: closed by Behrouz NematiPour Tue, 19 Jan 2021 20:55:38 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-5830-2 https://devapps.diality.us/cru/UI-DEN-5830-2 Behrouz NematiPour Closed UI-DEN-5830-2 ]]> UI-DEN-5830-2: reviewers finished Tue, 19 Jan 2021 14:40:06 -0800 https://devapps.diality.us/cru/UI-DEN-5830-2 https://devapps.diality.us/cru/UI-DEN-5830-2 plucia  (deleted user) finished reviewing UI-DEN-5830-2 UI-DEN-5830_Alarm Design ]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Tue, 19 Jan 2021 14:39:44 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7525 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7525 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: comment by Behrouz NematiPour "I will work on that later in prTx-UF story and ..." Tue, 19 Jan 2021 11:33:13 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-5830-2/#c7521 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7521 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-5830-2

I will work on that later in prTx-UF story and it has only been fixed here since it wasn't passing the test sometimes while testing the Alarm design.

]]> UI-DEN-5830-2: comment by plucia "Yes I know. I accidently clicked it and there's..." Tue, 19 Jan 2021 08:42:18 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7519 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7519 plucia  (deleted user) replied to pmontazemi  (deleted user) in UI-DEN-5830-2

Yes I know. I accidently clicked it and there's no way to unclick

]]> UI-DEN-5830-2: comment by pmontazemi "Our process calls for only 1 UNRESOLVED and 1 R..." Tue, 19 Jan 2021 08:35:58 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-5830-2/#c7516 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7516 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

Our process calls for only 1 UNRESOLVED and 1 RESOLVED response (comment) per thread please.

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Mon, 18 Jan 2021 11:22:20 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7478 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7478 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: reviewers finished Fri, 15 Jan 2021 14:37:13 -0800 https://devapps.diality.us/cru/UI-DEN-5830-2 https://devapps.diality.us/cru/UI-DEN-5830-2 pmontazemi  (deleted user) finished reviewing UI-DEN-5830-2 UI-DEN-5830_Alarm Design ]]> UI-DEN-5830-2: comment by pmontazemi "RESOLVED." Fri, 15 Jan 2021 14:36:18 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-5830-2/#c7439 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7439 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED.

]]> UI-DEN-5830-2: comment by pmontazemi "RESOLVED." Fri, 15 Jan 2021 14:36:00 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-5830-2/#c7438 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7438 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED.

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Fri, 15 Jan 2021 11:37:58 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7428 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7428 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Fri, 15 Jan 2021 11:37:50 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7427 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7427 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: comment by Behrouz NematiPour "deleted." Thu, 14 Jan 2021 15:32:01 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-5830-2/#c7370 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7370 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-5830-2

deleted.

]]> UI-DEN-5830-2: comment by Behrouz NematiPour "Good catch, Dleted." Thu, 14 Jan 2021 15:31:37 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-5830-2/#c7369 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7369 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-5830-2

Good catch,
Dleted.

]]> UI-DEN-5830-2: comment by Behrouz NematiPour "You actually had it with the value of 0.1 ms an..." Thu, 14 Jan 2021 15:27:16 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-5830-2/#c7367 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7367 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-5830-2

You actually had it with the value of 0.1 ms and I increased it to 0.5 because after running the test multiple times I figured it is not enough time.
I will review the waits in the pTx-UF COCO.

]]> UI-DEN-5830-2: comment by Behrouz NematiPour "I kept it for debugging. The usual behavior of..." Thu, 14 Jan 2021 15:14:46 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-5830-2/#c7366 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7366 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-5830-2

I kept it for debugging.
The usual behavior of the SquishQt is to continue even if an error happens to stop it if an error happens this value needs to be set.
I'm still trying to figure out how exactly this works and later may move it in a better file.

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Wed, 13 Jan 2021 11:21:31 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7305 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7305 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Wed, 13 Jan 2021 11:20:40 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7304 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7304 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]>