Fisheye on dialin/tests/hd_test_script.py https://devapps.diality.us/changelog/~br%3DDEN-3964-Maintenance/dialin/tests/hd_test_script.py Recent activity in "dialin" under directory /tests/hd_test_script.py DIALIN-DEN-4211-1: closed by Dara Navaei Thu, 19 Oct 2023 13:17:18 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-4211-1 https://devapps.diality.us/cru/DIALIN-DEN-4211-1 Dara Navaei Closed DIALIN-DEN-4211-1 ]]> DIALIN-DEN-4211-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 13:17:04 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-4211-1/#c19199 https://devapps.diality.us/cru/DIALIN-DEN-4211-1/#c19199 Dara Navaei replied to plucia  (deleted user) in DIALIN-DEN-4211-1

RESOLVED

]]> DIALIN-DEN-4211-1: started by Dara Navaei Thu, 19 Oct 2023 13:16:35 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-4211-1 https://devapps.diality.us/cru/DIALIN-DEN-4211-1 Dara Navaei started review DIALIN-DEN-4211-1 ]]> DIALIN-DEN-4308-1: closed by Dara Navaei Mon, 19 Oct 2020 14:37:30 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-4308-1 https://devapps.diality.us/cru/DIALIN-DEN-4308-1 Dara Navaei Closed DIALIN-DEN-4308-1 ]]> DIALIN-DEN-4308-1: reviewers finished Fri, 16 Oct 2020 14:21:43 -0700 https://devapps.diality.us/cru/DIALIN-DEN-4308-1 https://devapps.diality.us/cru/DIALIN-DEN-4308-1 plucia  (deleted user) finished reviewing DIALIN-DEN-4308-1 DIALIN-DEN-4308_HD Valve Control (1 of 2) ]]> DIALIN-DEN-4308-1: reviewers finished Wed, 14 Oct 2020 08:55:49 -0700 https://devapps.diality.us/cru/DIALIN-DEN-4308-1 https://devapps.diality.us/cru/DIALIN-DEN-4308-1 Sean Nash and pmontazemi  (deleted user) finished reviewing DIALIN-DEN-4308-1 DIALIN-DEN-4308_HD Valve Control (1 of 2) ]]> DIALIN-DEN-4308-1: started by Dara Navaei Wed, 14 Oct 2020 08:50:36 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-4308-1 https://devapps.diality.us/cru/DIALIN-DEN-4308-1 Dara Navaei started review DIALIN-DEN-4308-1 ]]> DIALIN-DEN-4308-1: comment by Sean Nash "RESOLVED." Thu, 08 Oct 2020 10:14:13 -0700 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5427 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5427 Sean Nash replied to Dara Navaei in DIALIN-DEN-4308-1

RESOLVED.

]]> DIALIN-DEN-4308-1: comment by Dara Navaei "I removed try and except and added has_value me..." Thu, 08 Oct 2020 09:57:14 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5426 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5426 Dara Navaei replied to Dara Navaei in DIALIN-DEN-4308-1

I removed try and except and added has_value method.

]]> DIALIN-DEN-4308-1: comment by plucia "RESOLVED" Thu, 08 Oct 2020 09:18:15 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5425 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5425 plucia  (deleted user) replied to Dara Navaei in DIALIN-DEN-4308-1

RESOLVED

]]> DIALIN-DEN-4308-1: comment by pmontazemi "RESOLVED." Tue, 06 Oct 2020 09:40:41 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5254 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5254 pmontazemi  (deleted user) replied to pmontazemi  (deleted user) in DIALIN-DEN-4308-1

RESOLVED.

]]> DIALIN-DEN-4308-1: comment by pmontazemi "Last ")" comes after vPWM))." Mon, 05 Oct 2020 15:43:40 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5209 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5209 pmontazemi  (deleted user) commented on DIALIN-DEN-4308-1

Last ")" comes after vPWM)).

]]> DIALIN-DEN-4308-1: comment by Dara Navaei "This is not just to check the range of the valv..." Mon, 05 Oct 2020 15:02:38 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5180 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5180 Dara Navaei replied to Sean Nash in DIALIN-DEN-4308-1

This is not just to check the range of the valves. All the other enums that we have such as valves positions and valves states also need to be tried to make sure nothing out of range was selected.

]]> DIALIN-DEN-4308-1: comment by Sean Nash "RESOLVED." Mon, 05 Oct 2020 11:10:57 -0700 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5165 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5165 Sean Nash replied to Dara Navaei in DIALIN-DEN-4308-1

RESOLVED.

]]> DIALIN-DEN-4308-1: comment by Sean Nash "RESOLVED." Mon, 05 Oct 2020 11:08:50 -0700 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5162 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5162 Sean Nash replied to Dara Navaei in DIALIN-DEN-4308-1

RESOLVED.

]]> DIALIN-DEN-4308-1: comment by Sean Nash "Can't we just range check vlv_ID instead of usi..." Mon, 05 Oct 2020 11:07:56 -0700 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5159 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5159 Sean Nash commented on DIALIN-DEN-4308-1

Can't we just range check vlv_ID instead of using try?

]]> DIALIN-DEN-4308-1: comment by Dara Navaei "It has been removed." Fri, 02 Oct 2020 16:31:29 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5136 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5136 Dara Navaei replied to Dara Navaei in DIALIN-DEN-4308-1

It has been removed.

]]> DIALIN-DEN-4308-1: comment by plucia "RESOLVED" Fri, 02 Oct 2020 10:23:02 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5135 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5135 plucia  (deleted user) replied to Dara Navaei in DIALIN-DEN-4308-1

RESOLVED

]]> DIALIN-DEN-4308-1: comment by plucia "RESOLVED" Fri, 02 Oct 2020 10:22:16 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5134 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5134 plucia  (deleted user) replied to Dara Navaei in DIALIN-DEN-4308-1

RESOLVED

]]> DIALIN-DEN-4308-1: comment by plucia "RESOLVED." Fri, 02 Oct 2020 10:20:39 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5133 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5133 plucia  (deleted user) replied to Dara Navaei in DIALIN-DEN-4308-1

RESOLVED.

]]> DIALIN-DEN-4308-1: comment by plucia "RESOLVED" Fri, 02 Oct 2020 10:19:35 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5132 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5132 plucia  (deleted user) replied to Dara Navaei in DIALIN-DEN-4308-1

RESOLVED

]]> DIALIN-DEN-4308-1: comment by plucia "RESOLVED" Thu, 01 Oct 2020 17:30:43 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5122 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5122 plucia  (deleted user) replied to Dara Navaei in DIALIN-DEN-4308-1

RESOLVED

]]> DIALIN-DEN-4308-1: comment by Dara Navaei "Done" Thu, 01 Oct 2020 17:26:30 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5121 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5121 Dara Navaei replied to plucia  (deleted user) in DIALIN-DEN-4308-1

Done

]]> DIALIN-DEN-4308-1: comment by Dara Navaei "Done" Thu, 01 Oct 2020 17:26:11 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5120 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5120 Dara Navaei replied to Sean Nash in DIALIN-DEN-4308-1

Done

]]> DIALIN-DEN-4308-1: comment by Dara Navaei "Done" Thu, 01 Oct 2020 17:26:01 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5119 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5119 Dara Navaei replied to Sean Nash in DIALIN-DEN-4308-1

Done

]]> DIALIN-DEN-4308-1: comment by Dara Navaei "Done" Thu, 01 Oct 2020 09:29:31 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5113 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5113 Dara Navaei replied to plucia  (deleted user) in DIALIN-DEN-4308-1

Done

]]> DIALIN-DEN-4308-1: comment by Dara Navaei "During testing, I have been commenting and unco..." Wed, 30 Sep 2020 15:31:46 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5042 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5042 Dara Navaei replied to plucia  (deleted user) in DIALIN-DEN-4308-1

During testing, I have been commenting and uncommenting code to test different parts of code. Since this is in tests, does that really matter?

]]> DIALIN-DEN-4308-1: comment by Dara Navaei "During testing, I have been commenting and unco..." Wed, 30 Sep 2020 15:31:06 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5041 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5041 Dara Navaei replied to plucia  (deleted user) in DIALIN-DEN-4308-1

During testing, I have been commenting and uncommenting code to test different parts of code. Since this is in tests, does that really matter?

]]> DIALIN-DEN-4308-1: comment by Dara Navaei "This handler will be removed." Wed, 30 Sep 2020 15:30:16 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5040 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5040 Dara Navaei replied to plucia  (deleted user) in DIALIN-DEN-4308-1

This handler will be removed.

]]> DIALIN-DEN-4308-1: comment by plucia "Any reason to keep this?" Wed, 30 Sep 2020 15:14:57 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5026 https://devapps.diality.us/cru/DIALIN-DEN-4308-1/#c5026 plucia  (deleted user) commented on DIALIN-DEN-4308-1

Any reason to keep this?

]]>